diff mbox

[v2] package: add bcusdk

Message ID 1352192728-4816-2-git-send-email-gregory.hermant@calao-systems.com
State Superseded
Headers show

Commit Message

Gregory Hermant Nov. 6, 2012, 9:05 a.m. UTC
Signed-off-by: Gregory Hermant <gregory.hermant@calao-systems.com>
---
 package/Config.in        |    1 +
 package/bcusdk/Config.in |   11 +++++++++++
 package/bcusdk/bcusdk.mk |   20 ++++++++++++++++++++
 3 files changed, 32 insertions(+)
 create mode 100644 package/bcusdk/Config.in
 create mode 100644 package/bcusdk/bcusdk.mk

Comments

Arnout Vandecappelle Nov. 8, 2012, 8:34 a.m. UTC | #1
BTW, we usually give such patches the title

bcusdk: new package

On 11/06/12 10:05, Gregory Hermant wrote:
> Signed-off-by: Gregory Hermant<gregory.hermant@calao-systems.com>
[snip]
> diff --git a/package/bcusdk/Config.in b/package/bcusdk/Config.in
> new file mode 100644
> index 0000000..c7b1b95
> --- /dev/null
> +++ b/package/bcusdk/Config.in
> @@ -0,0 +1,11 @@
> +config BR2_PACKAGE_BCUSDK
> +	bool "bcusdk"
> +	depends on BR2_INSTALL_LIBSTDCPP
> +	select BR2_PACKAGE_LIBPTHSEM

  ... and the architecture dependencies of libpthsem...

> +	help
> +	  A free development environment for BCU1 and BCU2

  It would be nice if there was a description of what BCU is.

  Otherwise, it looks good!


  Regards,
  Arnout

[snip]
Gregory Hermant Nov. 8, 2012, 10:52 a.m. UTC | #2
Le 08/11/2012 09:34, Arnout Vandecappelle a écrit :
>> diff --git a/package/bcusdk/Config.in b/package/bcusdk/Config.in
>> new file mode 100644
>> index 0000000..c7b1b95
>> --- /dev/null
>> +++ b/package/bcusdk/Config.in
>> @@ -0,0 +1,11 @@
>> +config BR2_PACKAGE_BCUSDK
>> +    bool "bcusdk"
>> +    depends on BR2_INSTALL_LIBSTDCPP
>> +    select BR2_PACKAGE_LIBPTHSEM
> 
>  ... and the architecture dependencies of libpthsem...

Could you please enlighten me on this point ?

BR,
gregory



CALAO SYSTEMS <http://www.calao-systems.com/>


*CALAO SYSTEMS*
Le Magistère II
334, rue des Vingt Toises
38950 Saint Martin le Vinoux
France
Phone : *+33 (0)4 76 56 38 05*
Fax     : *+33 (0)4 76 56 38 06*

Cette communication (y compris les pièces jointes) est réservée à l'usage exclusif du destinataire (des destinataires) et peut contenir des informations privilégiées, confidentielles, exemptées de
divulgation selon la loi ou protégées par les droits d'auteur. Si vous n'êtes pas un destinataire, toute utilisation, divulgation, distribution, reproduction, examen ou copie (totale ou partielle) est
non-autorisée et peut être illégale. Tout message électronique est susceptible d'altération et son intégrité ne peut être assurée. CALAO SYSTEMS décline toute responsabilité au titre de ce message
s'il a été modifié ou falsifié. Si vous n'êtes pas destinataire de ce message, merci de le détruire immédiatement et d'avertir l'expéditeur de l'erreur de distribution et de la destruction du message.
Merci.

This transmission (including any attachments) is intended solely for the use of the addressee(s) and may contain confidential information including trade secrets which are privileged, confidential,
exempt from disclosure under applicable law and/or subject to copyright. If you are not an intended recipient, any use, disclosure, distribution, reproduction, review or copying (either whole or
partial) is unauthorized and may be unlawful. E-mails are susceptible to alteration and their integrity cannot be guaranteed. CALAO SYSTEMS shall not be liable for this e-mail if modified or
falsified. If you are not the intended recipient of this e-mail, please delete it immediately from your system and notify the sender of the wrong delivery and the mail deletion. Thank you.
Arnout Vandecappelle Nov. 8, 2012, 11:05 a.m. UTC | #3
On 11/08/12 11:52, Grégory Hermant wrote:
>>> >>  +    select BR2_PACKAGE_LIBPTHSEM
>> >
>> >    ... and the architecture dependencies of libpthsem...
> Could you please enlighten me on this point ?

  As I wrote in the review of libpthsem, pth doesn't work on a number
of the architectures we support.  Since libpthsem is a fork of pth,
it's likely that it doesn't work in libpthsem either.  Therefore, it
is likely that libpthsem requires some
depends on !BR2_microblaze && !BR2_...
which have to be inherited by the packages that select libpthsem.

  (Thomas Petazzoni reported that pth doesn't work on arm-glibc, for
instance...).

  Regards,
  Arnout
diff mbox

Patch

diff --git a/package/Config.in b/package/Config.in
index 941b458..1a545ef 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -555,6 +555,7 @@  source "package/argus/Config.in"
 source "package/arptables/Config.in"
 source "package/avahi/Config.in"
 source "package/axel/Config.in"
+source "package/bcusdk/Config.in"
 source "package/bluez_utils/Config.in"
 source "package/boa/Config.in"
 source "package/bind/Config.in"
diff --git a/package/bcusdk/Config.in b/package/bcusdk/Config.in
new file mode 100644
index 0000000..c7b1b95
--- /dev/null
+++ b/package/bcusdk/Config.in
@@ -0,0 +1,11 @@ 
+config BR2_PACKAGE_BCUSDK
+	bool "bcusdk"
+	depends on BR2_INSTALL_LIBSTDCPP
+	select BR2_PACKAGE_LIBPTHSEM
+	help
+	  A free development environment for BCU1 and BCU2
+
+	  http://www.auto.tuwien.ac.at/~mkoegler/eib/
+
+comment "bcusdk requires a toolchain with C++ "
+	depends on !BR2_INSTALL_LIBSTDCPP
diff --git a/package/bcusdk/bcusdk.mk b/package/bcusdk/bcusdk.mk
new file mode 100644
index 0000000..18e3673
--- /dev/null
+++ b/package/bcusdk/bcusdk.mk
@@ -0,0 +1,20 @@ 
+#############################################################
+#
+# bcusck
+#
+#############################################################
+
+BCUSDK_VERSION = 0.0.5
+BCUSDK_SOURCE = bcusdk_$(BCUSDK_VERSION).tar.gz
+BCUSDK_SITE = http://www.auto.tuwien.ac.at/~mkoegler/eib/
+BCUSDK_LICENSE = GPLv2+
+BCUSDK_LICENSE_FILES = COPYING
+BCUSDK_INSTALL_STAGING = YES
+BCUSDK_CONF_OPT =  --enable-onlyeibd --enable-ft12 --enable-pei16 \
+		 --enable-eibnetip --enable-eibnetipserver \
+		 --enable-eibnetiptunnel --without-pth-test \
+		 --with-pth=$(STAGING_DIR)/usr 
+
+BCUSDK_DEPENDENCIES = libpthsem
+
+$(eval $(autotools-package))