| Message ID | 1351113973-17237-7-git-send-email-yann.morin.1998@free.fr |
|---|---|
| State | Changes Requested |
| Headers | show |
Package should be called celt, not celt051 On 24/10/12 23:25, Yann E. MORIN wrote: > Signed-off-by: "Yann E. MORIN"<yann.morin.1998@free.fr> > Reviewed-by: Thomas Petazzoni<thomas.petazzoni@free-electrons.com> [snip] > diff --git a/package/multimedia/celt051/celt.mk b/package/multimedia/celt051/celt.mk > new file mode 100644 > index 0000000..9baaa82 > --- /dev/null > +++ b/package/multimedia/celt051/celt.mk > @@ -0,0 +1,30 @@ > +############################################################# > +# > +# celt051 > +# > +############################################################# > + > +# Although version newer than 0.5.1.3 exists, we're > +# stuck with 0.5.1.3 for use by Spice (coming later) How come spice requires a specific version of celt? > +CELT051_VERSION = 0.5.1.3 > +CELT051_SOURCE = celt-$(CELT051_VERSION).tar.gz If it's called celt, this is the default so can be left out. Regards, Arnout [snip]
Arnout, All, On Saturday 27 October 2012 Arnout Vandecappelle wrote: > Package should be called celt, not celt051 Nope, see below. > On 24/10/12 23:25, Yann E. MORIN wrote: > > Signed-off-by: "Yann E. MORIN"<yann.morin.1998@free.fr> > > Reviewed-by: Thomas Petazzoni<thomas.petazzoni@free-electrons.com> > [snip] > > diff --git a/package/multimedia/celt051/celt.mk b/package/multimedia/celt051/celt.mk > > new file mode 100644 > > index 0000000..9baaa82 > > --- /dev/null > > +++ b/package/multimedia/celt051/celt.mk > > @@ -0,0 +1,30 @@ > > +############################################################# > > +# > > +# celt051 > > +# > > +############################################################# > > + > > +# Although version newer than 0.5.1.3 exists, we're > > +# stuck with 0.5.1.3 for use by Spice (coming later) > > How come spice requires a specific version of celt? The build instructions say: celt = 0.5.1.3 (this is important, newer versions use a different protocol) (from: http://www.spice-space.org/page/Building_Instructions) Also, their ./configure enforce this check. > > +CELT051_VERSION = 0.5.1.3 > > +CELT051_SOURCE = celt-$(CELT051_VERSION).tar.gz > > If it's called celt, this is the default so can be left out. I called it 'celt051' because it's not the latest version, and I want to make it clear that the version shall *not* be updated. See the discussion we had with Thomas last August: http://lists.busybox.net/pipermail/buildroot/2012-August/057562.html I think we should keep calling it 'celt051' and not just 'celt', so that the version is never updated. To be noted: celt is now deprecated, as it was merged into Opus, as it's now standardised by RFC6716: http://www.celt-codec.org/ (at the bottom of the page) http://opus-codec.org/ https://tools.ietf.org/html/rfc6716 However, spice still requires celt-0.5.1.3. Regards, Yann E. MORIN.
diff --git a/package/multimedia/Config.in b/package/multimedia/Config.in index 273d9bc..5e8d60c 100644 --- a/package/multimedia/Config.in +++ b/package/multimedia/Config.in @@ -2,6 +2,7 @@ menu "Audio and video applications" source "package/multimedia/alsa-utils/Config.in" source "package/multimedia/aumix/Config.in" source "package/multimedia/bellagio/Config.in" +source "package/multimedia/celt051/Config.in" source "package/multimedia/faad2/Config.in" source "package/multimedia/flac/Config.in" source "package/multimedia/ffmpeg/Config.in" diff --git a/package/multimedia/celt051/Config.in b/package/multimedia/celt051/Config.in new file mode 100644 index 0000000..50ed069 --- /dev/null +++ b/package/multimedia/celt051/Config.in @@ -0,0 +1,15 @@ +config BR2_PACKAGE_CELT051 + bool "celt051" + select BR2_PACKAGE_LIBOGG + help + The CELT ultra-low delay audio codec + + The CELT codec is a compression algorithm for audio. Like MP3, + Vorbis, and AAC it is suitable for transmitting music with high + quality. Unlike these formats CELT imposes very little delay on + the signal, even less than is typical for speech centric formats + like Speex, GSM, or G.729. + + Note: this is version 0.5.1.3 of celt. + + http://www.celt-codec.org/ diff --git a/package/multimedia/celt051/celt.mk b/package/multimedia/celt051/celt.mk new file mode 100644 index 0000000..9baaa82 --- /dev/null +++ b/package/multimedia/celt051/celt.mk @@ -0,0 +1,30 @@ +############################################################# +# +# celt051 +# +############################################################# + +# Although version newer than 0.5.1.3 exists, we're +# stuck with 0.5.1.3 for use by Spice (coming later) +CELT051_VERSION = 0.5.1.3 +CELT051_SOURCE = celt-$(CELT051_VERSION).tar.gz +CELT051_SITE = http://downloads.xiph.org/releases/celt +CELT051_LICENSE = BSD-2c +CELT051_LICENSE_FILES = COPYING +CELT051_INSTALL_STAGING = YES +CELT051_DEPENDENCIES = libogg + +# Need to specify --with-ogg, otherwise /usr/lib may be searched for +# if target is the same kind as host (ie. same arch, same bitness, +# same endianness, so that /usr/lib contains libraries linkable by +# our cross-compiler) +CELT051_CONF_OPT = \ + --enable-fixed-point \ + --disable-fixed-point-debug \ + --disable-experimental-postfilter \ + --disable-static-modes \ + --disable-assertions \ + --disable-oggtest \ + --with-ogg=$(STAGING_DIR)/usr \ + +$(eval $(autotools-package))