| Message ID | 1351267989.4013.20.camel@lorien2 |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
From: Shuah Khan <shuah.khan@hp.com> Date: Fri, 26 Oct 2012 10:13:09 -0600 > Add support for debug_dma_mapping_error() call to avoid warning from > debug_dma_unmap() interface when it checks for mapping error checked > status. Without this patch, device driver failed to check map error > warning is generated. > > Signed-off-by: Shuah Khan <shuah.khan@hp.com> Why are you resending this? When you resend patches, you have to give a reason. Did the patch change? Are you updating the CC: list of the patch posting? Are you correcting something else? -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: David Miller <davem@davemloft.net> Date: Fri, 26 Oct 2012 15:01:53 -0400 (EDT) > From: Shuah Khan <shuah.khan@hp.com> > Date: Fri, 26 Oct 2012 10:13:09 -0600 > >> Add support for debug_dma_mapping_error() call to avoid warning from >> debug_dma_unmap() interface when it checks for mapping error checked >> status. Without this patch, device driver failed to check map error >> warning is generated. >> >> Signed-off-by: Shuah Khan <shuah.khan@hp.com> > > Why are you resending this? > > When you resend patches, you have to give a reason. Did the patch > change? Are you updating the CC: list of the patch posting? Are > you correcting something else? In fact you sent this _3_ times. Please, don't do this, or at least explain why you are reposting something each time. -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 2012-10-26 at 15:10 -0400, David Miller wrote: > From: David Miller <davem@davemloft.net> > Date: Fri, 26 Oct 2012 15:01:53 -0400 (EDT) > > > From: Shuah Khan <shuah.khan@hp.com> > > Date: Fri, 26 Oct 2012 10:13:09 -0600 > > > >> Add support for debug_dma_mapping_error() call to avoid warning from > >> debug_dma_unmap() interface when it checks for mapping error checked > >> status. Without this patch, device driver failed to check map error > >> warning is generated. > >> > >> Signed-off-by: Shuah Khan <shuah.khan@hp.com> > > > > Why are you resending this? > > > > When you resend patches, you have to give a reason. Did the patch > > change? Are you updating the CC: list of the patch posting? Are > > you correcting something else? > > In fact you sent this _3_ times. Please, don't do this, or at least > explain why you are reposting something each time. I am really sorry for the noise. I forgot to mark this explicitly for linux-next the first time and this patch depends on a patch that went into linux-next. I sent a few patches for several architectures and lost track. I meant to add explanation before I hit send. The reason for resend is to tag it for linux-next. -- Shuah -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Shuah Khan <shuah.khan@hp.com> Date: Fri, 26 Oct 2012 10:13:09 -0600 > Add support for debug_dma_mapping_error() call to avoid warning from > debug_dma_unmap() interface when it checks for mapping error checked > status. Without this patch, device driver failed to check map error > warning is generated. > > Signed-off-by: Shuah Khan <shuah.khan@hp.com> This doesn't even compile: /home/davem/src/GIT/sparc/arch/sparc/include/asm/dma-mapping.h: In function 'dma_mapping_error': /home/davem/src/GIT/sparc/arch/sparc/include/asm/dma-mapping.h:62:2: error: implicit declaration of function 'debug_dma _mapping_error' [-Werror=implicit-function-declaration] cc1: some warnings being treated as errors In file included from include/linux/dma-mapping.h:76:0, from include/linux/skbuff.h:33, from include/linux/icmpv6.h:4, from include/linux/ipv6.h:58, from include/net/ipv6.h:16, from include/linux/sunrpc/clnt.h:26, from include/linux/nfs_fs.h:30, from init/do_mounts.c:30: -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 2012-11-09 at 19:38 -0500, David Miller wrote: > From: Shuah Khan <shuah.khan@hp.com> > Date: Fri, 26 Oct 2012 10:13:09 -0600 > > > Add support for debug_dma_mapping_error() call to avoid warning from > > debug_dma_unmap() interface when it checks for mapping error checked > > status. Without this patch, device driver failed to check map error > > warning is generated. > > > > Signed-off-by: Shuah Khan <shuah.khan@hp.com> > > This doesn't even compile: > > /home/davem/src/GIT/sparc/arch/sparc/include/asm/dma-mapping.h: In function 'dma_mapping_error': > /home/davem/src/GIT/sparc/arch/sparc/include/asm/dma-mapping.h:62:2: error: implicit declaration of function 'debug_dma > _mapping_error' [-Werror=implicit-function-declaration] > cc1: some warnings being treated as errors > In file included from include/linux/dma-mapping.h:76:0, > from include/linux/skbuff.h:33, > from include/linux/icmpv6.h:4, > from include/linux/ipv6.h:58, > from include/net/ipv6.h:16, > from include/linux/sunrpc/clnt.h:26, > from include/linux/nfs_fs.h:30, > from init/do_mounts.c:30: The problem the dependent patch is in linux-next and not in arch trees yet. That is why I am trying it get this through linux-next and/or dma-debug tree. I am open to suggestions on what is the best route. linux-next commit-id is: commit 6c9c6d6301287e369a754d628230fa6e50cdb74b I have another one that I sent to linux-next that fixes the dependency on get_dma_ops(): https://lkml.org/lkml/2012/11/3/219 Thanks, -- Shuah -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Shuah Khan <shuah.khan@hp.com> Date: Fri, 09 Nov 2012 17:52:23 -0700 > On Fri, 2012-11-09 at 19:38 -0500, David Miller wrote: >> From: Shuah Khan <shuah.khan@hp.com> >> Date: Fri, 26 Oct 2012 10:13:09 -0600 >> >> > Add support for debug_dma_mapping_error() call to avoid warning from >> > debug_dma_unmap() interface when it checks for mapping error checked >> > status. Without this patch, device driver failed to check map error >> > warning is generated. >> > >> > Signed-off-by: Shuah Khan <shuah.khan@hp.com> >> >> This doesn't even compile: >> >> /home/davem/src/GIT/sparc/arch/sparc/include/asm/dma-mapping.h: In function 'dma_mapping_error': >> /home/davem/src/GIT/sparc/arch/sparc/include/asm/dma-mapping.h:62:2: error: implicit declaration of function 'debug_dma >> _mapping_error' [-Werror=implicit-function-declaration] >> cc1: some warnings being treated as errors >> In file included from include/linux/dma-mapping.h:76:0, >> from include/linux/skbuff.h:33, >> from include/linux/icmpv6.h:4, >> from include/linux/ipv6.h:58, >> from include/net/ipv6.h:16, >> from include/linux/sunrpc/clnt.h:26, >> from include/linux/nfs_fs.h:30, >> from init/do_mounts.c:30: > > The problem the dependent patch is in linux-next and not in arch trees > yet. That is why I am trying it get this through linux-next and/or > dma-debug tree. I am open to suggestions on what is the best route. Then please put this in via the dma-debug tree: Acked-by: David S. Miller <davem@davemloft.net> -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 2012-11-09 at 19:54 -0500, David Miller wrote: > From: Shuah Khan <shuah.khan@hp.com> > Date: Fri, 09 Nov 2012 17:52:23 -0700 > > > On Fri, 2012-11-09 at 19:38 -0500, David Miller wrote: > >> From: Shuah Khan <shuah.khan@hp.com> > >> Date: Fri, 26 Oct 2012 10:13:09 -0600 > >> > >> > Add support for debug_dma_mapping_error() call to avoid warning from > >> > debug_dma_unmap() interface when it checks for mapping error checked > >> > status. Without this patch, device driver failed to check map error > >> > warning is generated. > >> > > >> > Signed-off-by: Shuah Khan <shuah.khan@hp.com> > >> > >> This doesn't even compile: > >> > >> /home/davem/src/GIT/sparc/arch/sparc/include/asm/dma-mapping.h: In function 'dma_mapping_error': > >> /home/davem/src/GIT/sparc/arch/sparc/include/asm/dma-mapping.h:62:2: error: implicit declaration of function 'debug_dma > >> _mapping_error' [-Werror=implicit-function-declaration] > >> cc1: some warnings being treated as errors > >> In file included from include/linux/dma-mapping.h:76:0, > >> from include/linux/skbuff.h:33, > >> from include/linux/icmpv6.h:4, > >> from include/linux/ipv6.h:58, > >> from include/net/ipv6.h:16, > >> from include/linux/sunrpc/clnt.h:26, > >> from include/linux/nfs_fs.h:30, > >> from init/do_mounts.c:30: > > > > The problem the dependent patch is in linux-next and not in arch trees > > yet. That is why I am trying it get this through linux-next and/or > > dma-debug tree. I am open to suggestions on what is the best route. > > Then please put this in via the dma-debug tree: > > Acked-by: David S. Miller <davem@davemloft.net> Thanks -- Shuah -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 2012-11-09 at 19:54 -0500, David Miller wrote: > From: Shuah Khan <shuah.khan@hp.com> > Date: Fri, 09 Nov 2012 17:52:23 -0700 > > > On Fri, 2012-11-09 at 19:38 -0500, David Miller wrote: > >> From: Shuah Khan <shuah.khan@hp.com> > >> Date: Fri, 26 Oct 2012 10:13:09 -0600 > >> > >> > Add support for debug_dma_mapping_error() call to avoid warning from > >> > debug_dma_unmap() interface when it checks for mapping error checked > >> > status. Without this patch, device driver failed to check map error > >> > warning is generated. > >> > > >> > Signed-off-by: Shuah Khan <shuah.khan@hp.com> > >> > >> This doesn't even compile: > >> > >> /home/davem/src/GIT/sparc/arch/sparc/include/asm/dma-mapping.h: In function 'dma_mapping_error': > >> /home/davem/src/GIT/sparc/arch/sparc/include/asm/dma-mapping.h:62:2: error: implicit declaration of function 'debug_dma > >> _mapping_error' [-Werror=implicit-function-declaration] > >> cc1: some warnings being treated as errors > >> In file included from include/linux/dma-mapping.h:76:0, > >> from include/linux/skbuff.h:33, > >> from include/linux/icmpv6.h:4, > >> from include/linux/ipv6.h:58, > >> from include/net/ipv6.h:16, > >> from include/linux/sunrpc/clnt.h:26, > >> from include/linux/nfs_fs.h:30, > >> from init/do_mounts.c:30: > > > > The problem the dependent patch is in linux-next and not in arch trees > > yet. That is why I am trying it get this through linux-next and/or > > dma-debug tree. I am open to suggestions on what is the best route. > > Then please put this in via the dma-debug tree: > > Acked-by: David S. Miller <davem@davemloft.net> Marek, This is for sparc to go through your tree. Thanks, -- Shuah -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/sparc/include/asm/dma-mapping.h b/arch/sparc/include/asm/dma-mapping.h index 8493fd3..05fe53f 100644 --- a/arch/sparc/include/asm/dma-mapping.h +++ b/arch/sparc/include/asm/dma-mapping.h @@ -59,6 +59,7 @@ static inline void dma_free_attrs(struct device *dev, size_t size, static inline int dma_mapping_error(struct device *dev, dma_addr_t dma_addr) { + debug_dma_mapping_error(dev, dma_addr); return (dma_addr == DMA_ERROR_CODE); }
Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated. Signed-off-by: Shuah Khan <shuah.khan@hp.com> --- arch/sparc/include/asm/dma-mapping.h | 1 + 1 file changed, 1 insertion(+)