| Message ID | 1345488308-10410-1-git-send-email-brogers@suse.com |
|---|---|
| State | New |
| Headers | show |
On 20 August 2012 19:45, Bruce Rogers <brogers@suse.com> wrote: > When building qemu-kvm for openSUSE:Factory, I am getting a > warning in the pipe2 detection performed by configure, which > prevents using --enable-werror. > > Change detection code to use return value of pipe2. > > Signed-off-by: Bruce Rogers <brogers@suse.com> Reviewed-by: Peter Maydell <peter.maydell@linaro.org> -- PMM
Ping! Just ran into this bug today and noticed this patch never got applied. Patch still applies OK, patchwork url is: http://patchwork.ozlabs.org/patch/178920/ thanks -- PMM On 20 August 2012 19:45, Bruce Rogers <brogers@suse.com> wrote: > When building qemu-kvm for openSUSE:Factory, I am getting a > warning in the pipe2 detection performed by configure, which > prevents using --enable-werror. > > Change detection code to use return value of pipe2. > > Signed-off-by: Bruce Rogers <brogers@suse.com> > --- > configure | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index 5808764..2e1f7f8 100755 > --- a/configure > +++ b/configure > @@ -2399,8 +2399,7 @@ cat > $TMPC << EOF > int main(void) > { > int pipefd[2]; > - pipe2(pipefd, O_CLOEXEC); > - return 0; > + return pipe2(pipefd, O_CLOEXEC); > } > EOF > if compile_prog "" "" ; then > -- > 1.7.7 > >
Am 24.10.2012 18:48, schrieb Peter Maydell: > Ping! Just ran into this bug today and noticed this > patch never got applied. > Patch still applies OK, patchwork url is: > http://patchwork.ozlabs.org/patch/178920/ ...and since it was noticed while packaging v1.2, it should go into stable as well (cc'ed). Andreas > On 20 August 2012 19:45, Bruce Rogers <brogers@suse.com> wrote: >> When building qemu-kvm for openSUSE:Factory, I am getting a >> warning in the pipe2 detection performed by configure, which >> prevents using --enable-werror. >> >> Change detection code to use return value of pipe2. >> >> Signed-off-by: Bruce Rogers <brogers@suse.com> >> --- >> configure | 3 +-- >> 1 files changed, 1 insertions(+), 2 deletions(-) >> >> diff --git a/configure b/configure >> index 5808764..2e1f7f8 100755 >> --- a/configure >> +++ b/configure >> @@ -2399,8 +2399,7 @@ cat > $TMPC << EOF >> int main(void) >> { >> int pipefd[2]; >> - pipe2(pipefd, O_CLOEXEC); >> - return 0; >> + return pipe2(pipefd, O_CLOEXEC); >> } >> EOF >> if compile_prog "" "" ; then >> -- >> 1.7.7
Thanks, applied. On Mon, Aug 20, 2012 at 6:45 PM, Bruce Rogers <brogers@suse.com> wrote: > When building qemu-kvm for openSUSE:Factory, I am getting a > warning in the pipe2 detection performed by configure, which > prevents using --enable-werror. > > Change detection code to use return value of pipe2. > > Signed-off-by: Bruce Rogers <brogers@suse.com> > --- > configure | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index 5808764..2e1f7f8 100755 > --- a/configure > +++ b/configure > @@ -2399,8 +2399,7 @@ cat > $TMPC << EOF > int main(void) > { > int pipefd[2]; > - pipe2(pipefd, O_CLOEXEC); > - return 0; > + return pipe2(pipefd, O_CLOEXEC); > } > EOF > if compile_prog "" "" ; then > -- > 1.7.7 > >
diff --git a/configure b/configure index 5808764..2e1f7f8 100755 --- a/configure +++ b/configure @@ -2399,8 +2399,7 @@ cat > $TMPC << EOF int main(void) { int pipefd[2]; - pipe2(pipefd, O_CLOEXEC); - return 0; + return pipe2(pipefd, O_CLOEXEC); } EOF if compile_prog "" "" ; then
When building qemu-kvm for openSUSE:Factory, I am getting a warning in the pipe2 detection performed by configure, which prevents using --enable-werror. Change detection code to use return value of pipe2. Signed-off-by: Bruce Rogers <brogers@suse.com> --- configure | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)