| Message ID | 1348746947-2349-1-git-send-email-zajec5@gmail.com |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, 2012-09-27 at 13:55 +0200, Rafał Miłecki wrote: > This is required by NAND flash driver for initializing wait counters. > > Signed-off-by: Rafał Miłecki <zajec5@gmail.com> > --- > 0001-bcma-export-PLL-reading-function.patch > Successfully built configuration "mips-bcm47xx_defconfig,mips,mips-linux-", no issues I think you did not enable the driver in the defconfig. Tested the patch(es) on top of the following commits: e3134a5 Quick fixes - applied by aiaiai a7c1993 mtd: fsl_elbc_nand: remove unnecessary badblock_pattern 03ba2bf mtd: ofpart: Fix incorrect NULL check in parse_ofoldpart_partitions() c525349 mtd: m25p80: add support for the windbond w25q256 chip -------------------------------------------------------------------------------- Successfully built configuration "mips-bcm47xx_defconfig,mips,mips-linux-", results: --- before_patching.log +++ after_patching.log @@ @@ +drivers/mtd/nand/bcm47xxnflash/ops_bcm4706.c: In function 'bcm47xxnflash_ops_bcm4706_init': +drivers/mtd/nand/bcm47xxnflash/ops_bcm4706.c:253:6: warning: variable 'col_mask' set but not used [-Wunused-but-set-variable] -------------------------------------------------------------------------------- checkpatch.pl has some complaints: -------------------------------------------------------------------------------- checkpatch.pl results for patch "[PATCH 2/6] mtd: prepare place for BCMA NAND flash driver(s)" WARNING:CONFIG_DESCRIPTION: please write a paragraph that describes the config symbol fully #33: FILE: drivers/mtd/nand/Kconfig:449: +config MTD_NAND_BCM47XXNFLASH WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const #113: FILE: drivers/mtd/nand/bcm47xxnflash/main.c:24: +static const char *probes[] = { "bcm47xxpart", NULL }; total: 0 errors, 2 warnings, 145 lines checked -------------------------------------------------------------------------------- checkpatch.pl results for patch "[PATCH 4/6] mtd: bcm47xxnflash: support for NAND_CMD_READID command" WARNING:LONG_LINE: line over 80 characters #120: FILE: drivers/mtd/nand/bcm47xxnflash/ops_bcm4706.c:106: + b47n->id_data[i] = bcma_cc_read32(b47n->cc, BCMA_CC_NFLASH_DATA) & 0xFF; total: 0 errors, 1 warnings, 134 lines checked --------------------------------------------------------------------------------
diff --git a/drivers/bcma/driver_chipcommon_pmu.c b/drivers/bcma/driver_chipcommon_pmu.c index 8b8f2f3..c7d94b47 100644 --- a/drivers/bcma/driver_chipcommon_pmu.c +++ b/drivers/bcma/driver_chipcommon_pmu.c @@ -13,12 +13,13 @@ #include <linux/export.h> #include <linux/bcma/bcma.h> -static u32 bcma_chipco_pll_read(struct bcma_drv_cc *cc, u32 offset) +u32 bcma_chipco_pll_read(struct bcma_drv_cc *cc, u32 offset) { bcma_cc_write32(cc, BCMA_CC_PLLCTL_ADDR, offset); bcma_cc_read32(cc, BCMA_CC_PLLCTL_ADDR); return bcma_cc_read32(cc, BCMA_CC_PLLCTL_DATA); } +EXPORT_SYMBOL_GPL(bcma_chipco_pll_read); void bcma_chipco_pll_write(struct bcma_drv_cc *cc, u32 offset, u32 value) { diff --git a/include/linux/bcma/bcma.h b/include/linux/bcma/bcma.h index 1954a4e..b58fae0 100644 --- a/include/linux/bcma/bcma.h +++ b/include/linux/bcma/bcma.h @@ -345,6 +345,7 @@ extern void bcma_core_set_clockmode(struct bcma_device *core, enum bcma_clkmode clkmode); extern void bcma_core_pll_ctl(struct bcma_device *core, u32 req, u32 status, bool on); +extern u32 bcma_chipco_pll_read(struct bcma_drv_cc *cc, u32 offset); #define BCMA_DMA_TRANSLATION_MASK 0xC0000000 #define BCMA_DMA_TRANSLATION_NONE 0x00000000 #define BCMA_DMA_TRANSLATION_DMA32_CMT 0x40000000 /* Client Mode Translation for 32-bit DMA */
This is required by NAND flash driver for initializing wait counters. Signed-off-by: Rafał Miłecki <zajec5@gmail.com> --- 0001-bcma-export-PLL-reading-function.patch Successfully built configuration "mips-bcm47xx_defconfig,mips,mips-linux-", no issues --- drivers/bcma/driver_chipcommon_pmu.c | 3 ++- include/linux/bcma/bcma.h | 1 + 2 files changed, 3 insertions(+), 1 deletions(-)