| Message ID | 1343053494-21248-1-git-send-email-spdawson@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
>>>>> "spdawson" == spdawson <spdawson@gmail.com> writes:
Hi,
Sorry for the slow response - See below for comments.
spdawson> +++ b/package/googlefontdirectory/Config.in
spdawson> @@ -0,0 +1,13 @@
spdawson> +config BR2_PACKAGE_GOOGLEFONTDIRECTORY
spdawson> + bool "Google Web Fonts"
It's a bit odd to see such a difference in Kconfig symbol name and help
text - But OK, they mix it up on the website as well.
spdawson> + help
spdawson> + Download Google Web Fonts
Please drop 'Download'. All packages download.
spdawson> +++ b/package/googlefontdirectory/googlefontdirectory.mk
spdawson> @@ -0,0 +1,36 @@
spdawson> +#############################################################
spdawson> +#
spdawson> +# googlefontdirectory
spdawson> +#
spdawson> +#############################################################
spdawson> +GOOGLEFONTDIRECTORY_VERSION = 1.0
spdawson> +GOOGLEFONTDIRECTORY_SITE = \
spdawson> + https://s3.amazonaws.com/joemaller_google_webfonts
Is that the official location? I don't seem to see anything referring to
a 1.0 release on the google code page.
Please add a license tag as well.
spdawson> +GOOGLEFONTDIRECTORY_SOURCE = googlewebfonts.tgz
spdawson> +
spdawson> +GOOGLEFONTDIRECTORY_FONTS = \
spdawson> + $(call qstrip,$(BR2_PACKAGE_GOOGLEFONTDIRECTORY_FONTS))
spdawson> +
spdawson> +define GOOGLEFONTDIRECTORY_INSTALL_SINGLE_FONT
spdawson> + $(info Installing single font $(1))
spdawson> + $(INSTALL) -d $(TARGET_DIR)/usr/share/fonts/$(1)
spdawson> + cp -a $(@D)/$(1)/*.ttf $(TARGET_DIR)/usr/share/fonts/$(1)
spdawson> + chmod 0644 $(TARGET_DIR)/usr/share/fonts/$(1)/*.ttf
spdawson> +endef
A simple loop for all fonts seems simpler / more standard than this
single-font macro.
On 10 October 2012 22:17, Peter Korsgaard <jacmet@uclibc.org> wrote:
> Sorry for the slow response - See below for comments.
Thanks for the comments Peter; I'll rework the patch and resubmit.
Simon.
diff --git a/package/Config.in b/package/Config.in index f664b8e..89dc036 100644 --- a/package/Config.in +++ b/package/Config.in @@ -498,6 +498,7 @@ endmenu menu "Miscellaneous" source "package/collectd/Config.in" source "package/empty/Config.in" +source "package/googlefontdirectory/Config.in" source "package/mobile-broadband-provider-info/Config.in" source "package/shared-mime-info/Config.in" source "package/sound-theme-borealis/Config.in" diff --git a/package/googlefontdirectory/Config.in b/package/googlefontdirectory/Config.in new file mode 100644 index 0000000..2ff81b7 --- /dev/null +++ b/package/googlefontdirectory/Config.in @@ -0,0 +1,13 @@ +config BR2_PACKAGE_GOOGLEFONTDIRECTORY + bool "Google Web Fonts" + help + Download Google Web Fonts + + http://code.google.com/p/googlefontdirectory/ + +config BR2_PACKAGE_GOOGLEFONTDIRECTORY_FONTS + string "List of fonts to install" + default "droid" + depends on BR2_PACKAGE_GOOGLEFONTDIRECTORY + help + Specify a space-separated list of fonts to install diff --git a/package/googlefontdirectory/googlefontdirectory.mk b/package/googlefontdirectory/googlefontdirectory.mk new file mode 100644 index 0000000..f13c100 --- /dev/null +++ b/package/googlefontdirectory/googlefontdirectory.mk @@ -0,0 +1,36 @@ +############################################################# +# +# googlefontdirectory +# +############################################################# +GOOGLEFONTDIRECTORY_VERSION = 1.0 +GOOGLEFONTDIRECTORY_SITE = \ + https://s3.amazonaws.com/joemaller_google_webfonts +GOOGLEFONTDIRECTORY_SOURCE = googlewebfonts.tgz + +GOOGLEFONTDIRECTORY_FONTS = \ + $(call qstrip,$(BR2_PACKAGE_GOOGLEFONTDIRECTORY_FONTS)) + +define GOOGLEFONTDIRECTORY_INSTALL_SINGLE_FONT + $(info Installing single font $(1)) + $(INSTALL) -d $(TARGET_DIR)/usr/share/fonts/$(1) + cp -a $(@D)/$(1)/*.ttf $(TARGET_DIR)/usr/share/fonts/$(1) + chmod 0644 $(TARGET_DIR)/usr/share/fonts/$(1)/*.ttf +endef + +define GOOGLEFONTDIRECTORY_UNINSTALL_SINGLE_FONT + $(info Uninstalling single font $(1)) + $(RM) -r $(TARGET_DIR)/usr/share/fonts/$(1) +endef + +define GOOGLEFONTDIRECTORY_INSTALL_TARGET_CMDS + $(foreach thing,$(GOOGLEFONTDIRECTORY_FONTS),\ + $(call GOOGLEFONTDIRECTORY_INSTALL_SINGLE_FONT,$(thing))) +endef + +define GOOGLEFONTDIRECTORY_UNINSTALL_TARGET_CMDS + $(foreach thing,$(GOOGLEFONTDIRECTORY_FONTS),\ + $(call GOOGLEFONTDIRECTORY_UNINSTALL_SINGLE_FONT,$(thing))) +endef + +$(eval $(generic-package))