| Message ID | 20121010112725.57a6f4a6@nehalam.linuxnetplumber.net |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Stephen Hemminger <shemminger@vyatta.com> Date: Wed, 10 Oct 2012 11:27:25 -0700 > Sparse complains about RTA_MARK which is should be host order according > to include file and usage in iproute. > > net/ipv4/route.c:2223:46: warning: incorrect type in argument 3 (different base types) > net/ipv4/route.c:2223:46: expected restricted __be32 [usertype] value > net/ipv4/route.c:2223:46: got unsigned int [unsigned] [usertype] flowic_mark > > Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- a/net/ipv4/route.c 2012-10-09 10:35:03.323140263 -0700 +++ b/net/ipv4/route.c 2012-10-10 10:59:08.774798362 -0700 @@ -2220,7 +2220,7 @@ static int rt_fill_info(struct net *net, goto nla_put_failure; if (fl4->flowi4_mark && - nla_put_be32(skb, RTA_MARK, fl4->flowi4_mark)) + nla_put_u32(skb, RTA_MARK, fl4->flowi4_mark)) goto nla_put_failure; error = rt->dst.error;
Sparse complains about RTA_MARK which is should be host order according to include file and usage in iproute. net/ipv4/route.c:2223:46: warning: incorrect type in argument 3 (different base types) net/ipv4/route.c:2223:46: expected restricted __be32 [usertype] value net/ipv4/route.c:2223:46: got unsigned int [unsigned] [usertype] flowic_mark Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html