Message ID | 1349443899-23353-1-git-send-email-ludovic.desroches@atmel.com |
---|---|
State | Superseded |
Headers | show |
On 05/10/12 15:31, ludovic.desroches@atmel.com wrote: > From: Ludovic Desroches<ludovic.desroches@atmel.com> Add a Signed-off-by line for yourself. This is a short way for you to assert that you are entitled to contribute the patch under buildroot's GPL license. See http://kerneltrap.org/files/Jeremy/DCO.txt for more details. [snip] > diff --git a/package/fb-test-app/Config.in b/package/fb-test-app/Config.in > new file mode 100644 > index 0000000..6b682ce > --- /dev/null > +++ b/package/fb-test-app/Config.in > @@ -0,0 +1,4 @@ > +config BR2_PACKAGE_FB_TEST_APP > + bool "fb-test-app" > + help > + Test suite for Linux framebuffer. Could you add an upstream URL to the help text? > diff --git a/package/fb-test-app/fb-test-app.mk b/package/fb-test-app/fb-test-app.mk > new file mode 100644 > index 0000000..ce31f05 > --- /dev/null > +++ b/package/fb-test-app/fb-test-app.mk > @@ -0,0 +1,34 @@ > +############################################################# > +# > +# fb-test-app > +# > +############################################################# > + > +FB_TEST_APP_VERSION = v1.0.0 > +FB_TEST_APP_SITE = git://github.com/prpplague/fb-test-app.git FB_TEST_APP_SITE = http://github.com/prpplague/fb-test-app/tarball downloads a lot faster. Otherwise, looks great. Regards, Arnout [snip]
Hi Ludovic, On Fri, Oct 05, 2012 at 03:31:39PM +0200, ludovic.desroches@atmel.com wrote: > +define FB_TEST_APP_INSTALL_TARGET_CMDS > + $(INSTALL) -D -m 0755 $(@D)/perf $(TARGET_DIR)/usr/bin/perf This might collide with the Linux kernel's perf utility. > + $(INSTALL) -D -m 0755 $(@D)/rect $(TARGET_DIR)/usr/bin/rect > + $(INSTALL) -D -m 0755 $(@D)/fb-test $(TARGET_DIR)/usr/bin/fb-test > + $(INSTALL) -D -m 0755 $(@D)/offset $(TARGET_DIR)/usr/bin/offset > +endef baruch
Hi Arnout Le 10/06/2012 01:14 AM, Arnout Vandecappelle a écrit : > On 05/10/12 15:31, ludovic.desroches@atmel.com wrote: >> From: Ludovic Desroches<ludovic.desroches@atmel.com> > > Add a Signed-off-by line for yourself. This is a short way for you to > assert that you are entitled to contribute the patch under buildroot's > GPL license. See http://kerneltrap.org/files/Jeremy/DCO.txt for more > details. Sorry for the omission. > > [snip] >> diff --git a/package/fb-test-app/Config.in >> b/package/fb-test-app/Config.in >> new file mode 100644 >> index 0000000..6b682ce >> --- /dev/null >> +++ b/package/fb-test-app/Config.in >> @@ -0,0 +1,4 @@ >> +config BR2_PACKAGE_FB_TEST_APP >> + bool "fb-test-app" >> + help >> + Test suite for Linux framebuffer. > > Could you add an upstream URL to the help text? > Yes I'll add the github url. >> diff --git a/package/fb-test-app/fb-test-app.mk >> b/package/fb-test-app/fb-test-app.mk >> new file mode 100644 >> index 0000000..ce31f05 >> --- /dev/null >> +++ b/package/fb-test-app/fb-test-app.mk >> @@ -0,0 +1,34 @@ >> +############################################################# >> +# >> +# fb-test-app >> +# >> +############################################################# >> + >> +FB_TEST_APP_VERSION = v1.0.0 >> +FB_TEST_APP_SITE = git://github.com/prpplague/fb-test-app.git > > FB_TEST_APP_SITE = http://github.com/prpplague/fb-test-app/tarball > > downloads a lot faster. Ok I'll change it. Regards Ludovic > > Otherwise, looks great. > > > Regards, > Arnout > > [snip] > >
Hi Baruch, Le 10/06/2012 11:03 PM, Baruch Siach a écrit : > Hi Ludovic, > > On Fri, Oct 05, 2012 at 03:31:39PM +0200, ludovic.desroches@atmel.com wrote: >> +define FB_TEST_APP_INSTALL_TARGET_CMDS >> + $(INSTALL) -D -m 0755 $(@D)/perf $(TARGET_DIR)/usr/bin/perf > > This might collide with the Linux kernel's perf utility. > I can add fb-test prefix to to the binary names, isn't it? Regards Ludovic >> + $(INSTALL) -D -m 0755 $(@D)/rect $(TARGET_DIR)/usr/bin/rect >> + $(INSTALL) -D -m 0755 $(@D)/fb-test $(TARGET_DIR)/usr/bin/fb-test >> + $(INSTALL) -D -m 0755 $(@D)/offset $(TARGET_DIR)/usr/bin/offset >> +endef > > baruch >
On Mon, 8 Oct 2012 09:26:23 +0200, ludovic.desroches wrote: > Hi Baruch, > > Le 10/06/2012 11:03 PM, Baruch Siach a écrit : > > Hi Ludovic, > > > > On Fri, Oct 05, 2012 at 03:31:39PM +0200, > > ludovic.desroches@atmel.com wrote: > >> +define FB_TEST_APP_INSTALL_TARGET_CMDS > >> + $(INSTALL) -D -m 0755 $(@D)/perf > >> $(TARGET_DIR)/usr/bin/perf > > > > This might collide with the Linux kernel's perf utility. > > > > I can add fb-test prefix to to the binary names, isn't it? Sounds good, yes. So you would have: fb-test-perf fb-test fb-test-rect fb-test-offset Best regards, Thomas
diff --git a/package/Config.in b/package/Config.in index 50b7631..a1ca25d 100644 --- a/package/Config.in +++ b/package/Config.in @@ -117,6 +117,7 @@ source "package/fbset/Config.in" endif source "package/fbterm/Config.in" source "package/fbv/Config.in" +source "package/fb-test-app/Config.in" source "package/imagemagick/Config.in" source "package/linux-fusion/Config.in" source "package/lite/Config.in" diff --git a/package/fb-test-app/Config.in b/package/fb-test-app/Config.in new file mode 100644 index 0000000..6b682ce --- /dev/null +++ b/package/fb-test-app/Config.in @@ -0,0 +1,4 @@ +config BR2_PACKAGE_FB_TEST_APP + bool "fb-test-app" + help + Test suite for Linux framebuffer. diff --git a/package/fb-test-app/fb-test-app.mk b/package/fb-test-app/fb-test-app.mk new file mode 100644 index 0000000..ce31f05 --- /dev/null +++ b/package/fb-test-app/fb-test-app.mk @@ -0,0 +1,34 @@ +############################################################# +# +# fb-test-app +# +############################################################# + +FB_TEST_APP_VERSION = v1.0.0 +FB_TEST_APP_SITE = git://github.com/prpplague/fb-test-app.git +FB_TEST_APP_LICENSE = GPLv2 +FB_TEST_APP_LICENSE_FILE = COPYING + +define FB_TEST_APP_BUILD_CMDS + $(MAKE) CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D) all +endef + +define FB_TEST_APP_INSTALL_TARGET_CMDS + $(INSTALL) -D -m 0755 $(@D)/perf $(TARGET_DIR)/usr/bin/perf + $(INSTALL) -D -m 0755 $(@D)/rect $(TARGET_DIR)/usr/bin/rect + $(INSTALL) -D -m 0755 $(@D)/fb-test $(TARGET_DIR)/usr/bin/fb-test + $(INSTALL) -D -m 0755 $(@D)/offset $(TARGET_DIR)/usr/bin/offset +endef + +define FB_TEST_APP_UNINSTALL_TARGET_CMDS + rm -f $(TARGET_DIR)/usr/bin/perf + rm -f $(TARGET_DIR)/usr/bin/rect + rm -f $(TARGET_DIR)/usr/bin/fb-test + rm -f $(TARGET_DIR)/usr/bin/offset +endef + +define FB_TEST_APP_CLEAN_CMDS + $(MAKE) -C $(@D) clean +endef + +$(eval $(generic-package))
From: Ludovic Desroches <ludovic.desroches@atmel.com> --- package/Config.in | 1 + package/fb-test-app/Config.in | 4 ++++ package/fb-test-app/fb-test-app.mk | 34 ++++++++++++++++++++++++++++++++++ 3 files changed, 39 insertions(+) create mode 100644 package/fb-test-app/Config.in create mode 100644 package/fb-test-app/fb-test-app.mk