| Message ID | 1349177616-5341-1-git-send-email-quintela@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 10/02/2012 05:33 AM, Juan Quintela wrote: > It indicates how many pages were dirtied during the last second. > > Signed-off-by: Juan Quintela <quintela@redhat.com> > --- > +# @dirty-pages-rate: number of pages dirtied by second by the Reads slightly better as: pages dirtied per second by the guest > +# guest (since 1.3) > # > # Since: 0.14.0 > ## > { 'type': 'MigrationStats', > 'data': {'transferred': 'int', 'remaining': 'int', 'total': 'int' , > - 'duplicate': 'int', 'normal': 'int', 'normal-bytes': 'int' } } > + 'duplicate': 'int', 'normal': 'int', 'normal-bytes': 'int', > + 'dirty-pages-rate' : 'int' } } Consistent formatting: s/ :/:/
Hi v2: (20121001) - fix qemu_in_vcpu_thread: marcelo - fix "fix migration sync on setup" - addressed all marcelo comments Please, review. v1: (20120921) This is the mergable part of migration thread work that I am doing. What it does: - cleanups left and right - 2nd patch is a (fix migration sync) should be applied to stable IMHO Othrewise, we "could" be sending zero pages 2 times. - It introduces the stats discused previously * expected_downtime * downtime * dirty_pages_rate All Eric & Luiz comments have been addressed - buffered file has been basically unfolded. It was used only once, with one user. So we de-abstracted it. Notice that with migration patches, it makes no sense anymore - migration bitmap Now the bitmap is 1bit per page. Notice that this only affects to migration. For the rest (aka TCG & VGA), we still use the old bitmap. - remove qemu_file* functions that were not used or used only once - last_error: we have made that almost all error paths return one error instead of zero, so we use much, much less the error on the qemu_file. Some of the last remmants are: * still there due to callbacks (can be removed when the thread is integrated) * are on the read path (I haven't touched a lot of those yet) - qemu_cpu_is_vcpu() We used to test if we were _not_ an vcpu testing if we were the iothread. With the migration thread that is not true anymore. So create a function that does the right thing. Please review. Thanks, Juan. The following changes since commit e744c06fca438dc08271e626034e632a270c91c8: fpu/softfloat.c: Return correctly signed values from uint64_to_float32 (2012-10-01 22:06:39 +0200) are available in the git repository at: http://repo.or.cz/r/qemu/quintela.git migration-next-20121001 for you to fetch changes up to 7708df6346690e7b93d6c162d6e97f0428559bd5: cpus: create qemu_in_vcpu_thread() (2012-10-02 13:13:47 +0200) Juan Quintela (40): buffered_file: g_realloc() can't fail fix migration sync migration: store end_time in a local variable migration: print total downtime for final phase of migration migration: rename expected_time to expected_downtime migration: export migrate_get_current() migration: print expected downtime in info migrate savevm: Factorize ram globals reset in its own function ram: introduce migration_bitmap_set_dirty() ram: Introduce migration_bitmap_test_and_reset_dirty() ram: Export last_ram_offset() ram: introduce migration_bitmap_sync() ram: create trace event for migration sync bitmap Separate migration bitmap migration: Add dirty_pages_rate to query migrate output buffered_file: rename opaque to migration_state buffered_file: opaque is MigrationState buffered_file: unfold migrate_fd_put_buffer buffered_file: unfold migrate_fd_put_ready buffered_file: unfold migrate_fd_wait_for_unfreeze buffered_file: unfold migrate_fd_close buffered_file: We can access directly to bandwidth_limit buffered_file: callers of buffered_flush() already check for errors buffered_file: make buffered_flush return the error code migration: make migrate_fd_wait_for_unfreeze() return errors savevm: unexport qemu_fflush virtio-net: use qemu_get_buffer() in a temp buffer savevm: Remove qemu_fseek() savevm: make qemu_fflush() return an error code savevm: unfold qemu_fclose_internal() savevm: unexport qemu_ftell() savevm: make qemu_fill_buffer() be consistent savevm: Only qemu_fflush() can generate errors buffered_file: buffered_put_buffer() don't need to set last_error block-migration: make flush_blks() return errors block-migration: Switch meaning of return value block-migration: handle errors with the return codes correctly savevm: un-export qemu_file_set_error() savevm: make qemu_file_put_notify() return errors cpus: create qemu_in_vcpu_thread() Paolo Bonzini (1): BufferedFile: append, then flush arch_init.c | 141 +++++++++++++++++++++++++++++++++++++++++------------- block-migration.c | 56 +++++++++++----------- buffered_file.c | 129 ++++++++++++++++++------------------------------- buffered_file.h | 12 +---- cpu-all.h | 3 +- cpus.c | 9 +++- exec-obsolete.h | 10 ---- exec.c | 2 +- hmp.c | 12 +++++ hw/virtio-net.c | 4 +- migration.c | 46 +++++++++--------- migration.h | 10 ++++ qapi-schema.json | 20 ++++++-- qemu-file.h | 8 +--- qmp-commands.hx | 9 ++++ savevm.c | 117 +++++++++++++++++--------------------------- trace-events | 4 ++ 17 files changed, 320 insertions(+), 272 deletions(-)