Message ID | 1348934029.10238.15.camel@cr0 |
---|---|
State | Rejected |
Headers | show |
On Saturday 2012-09-29 17:53, Cong Wang wrote: >Hi, netfilter experts, > >A customer wants to increase XT_EXTENSION_MAXNAMELEN to at least 31 (1 >for '\0'), so I just increase it to 32. Do you have any comments or >objections for the following patch? This is a no-no. You are breaking the ABI. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, Sep 29, 2012 at 06:46:22PM +0200, Jan Engelhardt wrote: > On Saturday 2012-09-29 17:53, Cong Wang wrote: > > >Hi, netfilter experts, > > > >A customer wants to increase XT_EXTENSION_MAXNAMELEN to at least 31 (1 > >for '\0'), so I just increase it to 32. Do you have any comments or > >objections for the following patch? > > This is a no-no. You are breaking the ABI. Agreed. Sorry Cong, you cannot do that. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, 2012-09-29 at 20:47 +0200, Pablo Neira Ayuso wrote: > On Sat, Sep 29, 2012 at 06:46:22PM +0200, Jan Engelhardt wrote: > > On Saturday 2012-09-29 17:53, Cong Wang wrote: > > > > >Hi, netfilter experts, > > > > > >A customer wants to increase XT_EXTENSION_MAXNAMELEN to at least 31 (1 > > >for '\0'), so I just increase it to 32. Do you have any comments or > > >objections for the following patch? > > > > This is a no-no. You are breaking the ABI. > > Agreed. Sorry Cong, you cannot do that. Ok, no problem. I knew this could break user-space iptables, so there must be some other applications relying on this ABI too, hmm... I will tell the customer this is not possible to change. Thanks! -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/linux/netfilter/x_tables.h b/include/linux/netfilter/x_tables.h index 8d674a7..24b4dd4 100644 --- a/include/linux/netfilter/x_tables.h +++ b/include/linux/netfilter/x_tables.h @@ -4,7 +4,7 @@ #include <linux/types.h> #define XT_FUNCTION_MAXNAMELEN 30 -#define XT_EXTENSION_MAXNAMELEN 29 +#define XT_EXTENSION_MAXNAMELEN 32 #define XT_TABLE_MAXNAMELEN 32 struct xt_entry_match {