| Message ID | 1348667065-27138-2-git-send-email-luk0104@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
Dear Lukasz Dalek, > PXA25x gadget implements common function usb_disconnect(). > This patch adds this function prototype into usb.h for boards using it. [...] > +/* > + * This isn't host > + */ The comment doesn't need to be multiline. It'd be cool if it was meaningful ... like "pxa25x can only do gadget mode, thus the following ... etc". Otherwise, we're basically there. Can you repost the whole patchset please? > +#elif defined(CONFIG_USB_GADGET_PXA2XX) > + > +extern void udc_disconnect(void); > + > #else > #error USB Lowlevel not defined > #endif Best regards, Marek Vasut
On 26.09.2012 17:31, Marek Vasut wrote: > Dear Lukasz Dalek, > >> PXA25x gadget implements common function usb_disconnect(). >> This patch adds this function prototype into usb.h for boards using it. > [...] > >> +/* >> + * This isn't host >> + */ > The comment doesn't need to be multiline. It'd be cool if it was meaningful ... > like "pxa25x can only do gadget mode, thus the following ... etc". Otherwise, > we're basically there. Ok > > Can you repost the whole patchset please? Whole? Including ethernet driver, pxa cpu detection etc...? If so, I'll resend them. Łukasz Dałek
Dear Łukasz Dałek, > On 26.09.2012 17:31, Marek Vasut wrote: > > Dear Lukasz Dalek, > > > >> PXA25x gadget implements common function usb_disconnect(). > >> This patch adds this function prototype into usb.h for boards using it. > > > > [...] > > > >> +/* > >> + * This isn't host > >> + */ > > > > The comment doesn't need to be multiline. It'd be cool if it was > > meaningful ... like "pxa25x can only do gadget mode, thus the following > > ... etc". Otherwise, we're basically there. > > Ok > > > Can you repost the whole patchset please? > > Whole? Including ethernet driver, pxa cpu detection etc...? > If so, I'll resend them. Yes, in correct order please. We're almost there now. btw. do you want to hack further on uboot? Maybe some PXA improvements cleanups etc? > Łukasz Dałek Best regards, Marek Vasut
On 27.09.2012 01:58, Marek Vasut wrote: > Dear Łukasz Dałek, > >> On 26.09.2012 17:31, Marek Vasut wrote: >>> Dear Lukasz Dalek, >>> >>>> PXA25x gadget implements common function usb_disconnect(). >>>> This patch adds this function prototype into usb.h for boards using it. >>> [...] >>> >>>> +/* >>>> + * This isn't host >>>> + */ >>> The comment doesn't need to be multiline. It'd be cool if it was >>> meaningful ... like "pxa25x can only do gadget mode, thus the following >>> ... etc". Otherwise, we're basically there. >> Ok >> >>> Can you repost the whole patchset please? >> Whole? Including ethernet driver, pxa cpu detection etc...? >> If so, I'll resend them. > Yes, in correct order please. We're almost there now. > > btw. do you want to hack further on uboot? Maybe some PXA improvements cleanups > etc? Yes, but before I want to complete what I've started with h2200... Łukasz Dałek
Dear Łukasz Dałek, > On 27.09.2012 01:58, Marek Vasut wrote: > > Dear Łukasz Dałek, > > > >> On 26.09.2012 17:31, Marek Vasut wrote: > >>> Dear Lukasz Dalek, > >>> > >>>> PXA25x gadget implements common function usb_disconnect(). > >>>> This patch adds this function prototype into usb.h for boards using > >>>> it. > >>> > >>> [...] > >>> > >>>> +/* > >>>> + * This isn't host > >>>> + */ > >>> > >>> The comment doesn't need to be multiline. It'd be cool if it was > >>> meaningful ... like "pxa25x can only do gadget mode, thus the following > >>> ... etc". Otherwise, we're basically there. > >> > >> Ok > >> > >>> Can you repost the whole patchset please? > >> > >> Whole? Including ethernet driver, pxa cpu detection etc...? > >> If so, I'll resend them. > > > > Yes, in correct order please. We're almost there now. > > > > btw. do you want to hack further on uboot? Maybe some PXA improvements > > cleanups etc? > > Yes, but before I want to complete what I've started with h2200... You're basically there! btw sorry if I sound a bit crazy, I've been pretty loaded recently so I might have forgotten what I have told you a few days ago ... > Łukasz Dałek Best regards, Marek Vasut
On 27.09.2012 02:06, Marek Vasut wrote: > Dear Łukasz Dałek, > >> On 27.09.2012 01:58, Marek Vasut wrote: >>> Dear Łukasz Dałek, >>> >>>> On 26.09.2012 17:31, Marek Vasut wrote: >>>>> Dear Lukasz Dalek, >>>>> >>>>>> PXA25x gadget implements common function usb_disconnect(). >>>>>> This patch adds this function prototype into usb.h for boards using >>>>>> it. >>>>> [...] >>>>> >>>>>> +/* >>>>>> + * This isn't host >>>>>> + */ >>>>> The comment doesn't need to be multiline. It'd be cool if it was >>>>> meaningful ... like "pxa25x can only do gadget mode, thus the following >>>>> ... etc". Otherwise, we're basically there. >>>> Ok >>>> >>>>> Can you repost the whole patchset please? >>>> Whole? Including ethernet driver, pxa cpu detection etc...? >>>> If so, I'll resend them. >>> Yes, in correct order please. We're almost there now. >>> >>> btw. do you want to hack further on uboot? Maybe some PXA improvements >>> cleanups etc? >> Yes, but before I want to complete what I've started with h2200... > You're basically there! What do you mean saying that I am there? > > btw sorry if I sound a bit crazy, I've been pretty loaded recently so I might > have forgotten what I have told you a few days ago ... No problem. Łukasz Dałek
Dear Łukasz Dałek, > On 27.09.2012 02:06, Marek Vasut wrote: > > Dear Łukasz Dałek, > > > >> On 27.09.2012 01:58, Marek Vasut wrote: > >>> Dear Łukasz Dałek, > >>> > >>>> On 26.09.2012 17:31, Marek Vasut wrote: > >>>>> Dear Lukasz Dalek, > >>>>> > >>>>>> PXA25x gadget implements common function usb_disconnect(). > >>>>>> This patch adds this function prototype into usb.h for boards using > >>>>>> it. > >>>>> > >>>>> [...] > >>>>> > >>>>>> +/* > >>>>>> + * This isn't host > >>>>>> + */ > >>>>> > >>>>> The comment doesn't need to be multiline. It'd be cool if it was > >>>>> meaningful ... like "pxa25x can only do gadget mode, thus the > >>>>> following ... etc". Otherwise, we're basically there. > >>>> > >>>> Ok > >>>> > >>>>> Can you repost the whole patchset please? > >>>> > >>>> Whole? Including ethernet driver, pxa cpu detection etc...? > >>>> If so, I'll resend them. > >>> > >>> Yes, in correct order please. We're almost there now. > >>> > >>> btw. do you want to hack further on uboot? Maybe some PXA improvements > >>> cleanups etc? > >> > >> Yes, but before I want to complete what I've started with h2200... > > > > You're basically there! > > What do you mean saying that I am there? That you've walked most of the journey already, there's only the one small final step for you to do ... > > btw sorry if I sound a bit crazy, I've been pretty loaded recently so I > > might have forgotten what I have told you a few days ago ... > > No problem. > > Łukasz Dałek Best regards, Marek Vasut
On 27.09.2012 02:30, Marek Vasut wrote: > Dear Łukasz Dałek, > >> On 27.09.2012 02:06, Marek Vasut wrote: >>> Dear Łukasz Dałek, >>> >>>> On 27.09.2012 01:58, Marek Vasut wrote: >>>>> Dear Łukasz Dałek, >>>>> >>>>>> On 26.09.2012 17:31, Marek Vasut wrote: >>>>>>> Dear Lukasz Dalek, >>>>>>> >>>>>>>> PXA25x gadget implements common function usb_disconnect(). >>>>>>>> This patch adds this function prototype into usb.h for boards using >>>>>>>> it. >>>>>>> [...] >>>>>>> >>>>>>>> +/* >>>>>>>> + * This isn't host >>>>>>>> + */ >>>>>>> The comment doesn't need to be multiline. It'd be cool if it was >>>>>>> meaningful ... like "pxa25x can only do gadget mode, thus the >>>>>>> following ... etc". Otherwise, we're basically there. >>>>>> Ok >>>>>> >>>>>>> Can you repost the whole patchset please? >>>>>> Whole? Including ethernet driver, pxa cpu detection etc...? >>>>>> If so, I'll resend them. >>>>> Yes, in correct order please. We're almost there now. >>>>> >>>>> btw. do you want to hack further on uboot? Maybe some PXA improvements >>>>> cleanups etc? >>>> Yes, but before I want to complete what I've started with h2200... >>> You're basically there! >> What do you mean saying that I am there? > That you've walked most of the journey already, there's only the one small final > step for you to do ... Yes, indeed. Łukasz Dałek
diff --git a/include/usb.h b/include/usb.h index ba3d169..25c3255 100644 --- a/include/usb.h +++ b/include/usb.h @@ -166,6 +166,13 @@ int submit_int_msg(struct usb_device *dev, unsigned long pipe, void *buffer, #define USB_UHCI_VEND_ID 0x8086 #define USB_UHCI_DEV_ID 0x7112 +/* + * This isn't host + */ +#elif defined(CONFIG_USB_GADGET_PXA2XX) + +extern void udc_disconnect(void); + #else #error USB Lowlevel not defined #endif
PXA25x gadget implements common function usb_disconnect(). This patch adds this function prototype into usb.h for boards using it. Signed-off-by: Lukasz Dalek <luk0104@gmail.com> --- include/usb.h | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-)