| Message ID | 1348257653-22002-1-git-send-email-fabio.estevam@freescale.com |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Stefano Babic |
| Headers | show |
Dear Fabio Estevam, > fecmxc_mii_postcall() is specific to the KSZ9021 PHY on m28evk and > should not be used on mx28evk, which has LAN8270 instead. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> Acked-by: Marek Vasut <marex@denx.de> This is a fix, so should go into current release. > --- > board/freescale/mx28evk/mx28evk.c | 25 ------------------------- > 1 file changed, 25 deletions(-) > > diff --git a/board/freescale/mx28evk/mx28evk.c > b/board/freescale/mx28evk/mx28evk.c index d782aea..6e719ff 100644 > --- a/board/freescale/mx28evk/mx28evk.c > +++ b/board/freescale/mx28evk/mx28evk.c > @@ -100,19 +100,6 @@ int board_mmc_init(bd_t *bis) > > #ifdef CONFIG_CMD_NET > > -#define MII_OPMODE_STRAP_OVERRIDE 0x16 > -#define MII_PHY_CTRL1 0x1e > -#define MII_PHY_CTRL2 0x1f > - > -int fecmxc_mii_postcall(int phy) > -{ > - miiphy_write("FEC1", phy, MII_BMCR, 0x9000); > - miiphy_write("FEC1", phy, MII_OPMODE_STRAP_OVERRIDE, 0x0202); > - if (phy == 3) > - miiphy_write("FEC1", 3, MII_PHY_CTRL2, 0x8180); > - return 0; > -} > - > int board_eth_init(bd_t *bis) > { > struct mxs_clkctrl_regs *clkctrl_regs = > @@ -152,24 +139,12 @@ int board_eth_init(bd_t *bis) > return -EINVAL; > } > > - ret = fecmxc_register_mii_postcall(dev, fecmxc_mii_postcall); > - if (ret) { > - puts("FEC MXS: Unable to register FEC0 mii postcall\n"); > - return ret; > - } > - > dev = eth_get_dev_by_name("FEC1"); > if (!dev) { > puts("FEC MXS: Unable to get FEC1 device entry\n"); > return -EINVAL; > } > > - ret = fecmxc_register_mii_postcall(dev, fecmxc_mii_postcall); > - if (ret) { > - puts("FEC MXS: Unable to register FEC1 mii postcall\n"); > - return ret; > - } > - > return ret; > } Best regards, Marek Vasut
On 21/09/2012 22:00, Fabio Estevam wrote: > fecmxc_mii_postcall() is specific to the KSZ9021 PHY on m28evk and > should not be used on mx28evk, which has LAN8270 instead. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- Applied to u-boot-imx (fix), thanks. Best regards, Stefano Babic
diff --git a/board/freescale/mx28evk/mx28evk.c b/board/freescale/mx28evk/mx28evk.c index d782aea..6e719ff 100644 --- a/board/freescale/mx28evk/mx28evk.c +++ b/board/freescale/mx28evk/mx28evk.c @@ -100,19 +100,6 @@ int board_mmc_init(bd_t *bis) #ifdef CONFIG_CMD_NET -#define MII_OPMODE_STRAP_OVERRIDE 0x16 -#define MII_PHY_CTRL1 0x1e -#define MII_PHY_CTRL2 0x1f - -int fecmxc_mii_postcall(int phy) -{ - miiphy_write("FEC1", phy, MII_BMCR, 0x9000); - miiphy_write("FEC1", phy, MII_OPMODE_STRAP_OVERRIDE, 0x0202); - if (phy == 3) - miiphy_write("FEC1", 3, MII_PHY_CTRL2, 0x8180); - return 0; -} - int board_eth_init(bd_t *bis) { struct mxs_clkctrl_regs *clkctrl_regs = @@ -152,24 +139,12 @@ int board_eth_init(bd_t *bis) return -EINVAL; } - ret = fecmxc_register_mii_postcall(dev, fecmxc_mii_postcall); - if (ret) { - puts("FEC MXS: Unable to register FEC0 mii postcall\n"); - return ret; - } - dev = eth_get_dev_by_name("FEC1"); if (!dev) { puts("FEC MXS: Unable to get FEC1 device entry\n"); return -EINVAL; } - ret = fecmxc_register_mii_postcall(dev, fecmxc_mii_postcall); - if (ret) { - puts("FEC MXS: Unable to register FEC1 mii postcall\n"); - return ret; - } - return ret; }
fecmxc_mii_postcall() is specific to the KSZ9021 PHY on m28evk and should not be used on mx28evk, which has LAN8270 instead. Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> --- board/freescale/mx28evk/mx28evk.c | 25 ------------------------- 1 file changed, 25 deletions(-)