| Message ID | 1347390507-27299-2-git-send-email-marex@denx.de |
|---|---|
| State | Accepted |
| Delegated to: | Sonic Zhang |
| Headers | show |
Acked-by: Mike Frysinger <vapier@gentoo.org>
-mike
Dear Marek Vasut, > The buf variable in bfin_mac.c is not used and produces warning, > fix it. > > bfin_mac.c: In function 'bfin_EMAC_send': > bfin_mac.c:125:16: warning: variable 'buf' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Mike Frysinger <vapier@gentoo.org> Guess I should have Cced Joe too ... > --- > drivers/net/bfin_mac.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/bfin_mac.c b/drivers/net/bfin_mac.c > index c63398e..0ffd59d 100644 > --- a/drivers/net/bfin_mac.c > +++ b/drivers/net/bfin_mac.c > @@ -122,8 +122,6 @@ static int bfin_EMAC_send(struct eth_device *dev, void > *packet, int length) { > int i; > int result = 0; > - unsigned int *buf; > - buf = (unsigned int *)packet; > > if (length <= 0) { > printf("Ethernet: bad packet size: %d\n", length); Best regards, Marek Vasut
On Wed, Sep 12, 2012 at 4:51 AM, Marek Vasut <marex@denx.de> wrote: > Dear Marek Vasut, > >> The buf variable in bfin_mac.c is not used and produces warning, >> fix it. >> >> bfin_mac.c: In function 'bfin_EMAC_send': >> bfin_mac.c:125:16: warning: variable 'buf' set but not used >> [-Wunused-but-set-variable] >> >> Signed-off-by: Marek Vasut <marex@denx.de> >> Cc: Mike Frysinger <vapier@gentoo.org> > > Guess I should have Cced Joe too ... > Acked-by: Joe Hershberger <joe.hershberger@ni.com>
On Wed, Sep 12, 2012 at 10:32 AM, Joe Hershberger wrote: > On Wed, Sep 12, 2012 at 4:51 AM, Marek Vasut wrote: >> Dear Marek Vasut, >>> The buf variable in bfin_mac.c is not used and produces warning, >>> fix it. >>> >>> bfin_mac.c: In function 'bfin_EMAC_send': >>> bfin_mac.c:125:16: warning: variable 'buf' set but not used >>> [-Wunused-but-set-variable] >>> >>> Signed-off-by: Marek Vasut <marex@denx.de> >>> Cc: Mike Frysinger <vapier@gentoo.org> >> >> Guess I should have Cced Joe too ... > > Acked-by: Joe Hershberger <joe.hershberger@ni.com> i can pick this up, or you can. it'll be another week before i'm back home & working on u-boot though. -mike
diff --git a/drivers/net/bfin_mac.c b/drivers/net/bfin_mac.c index c63398e..0ffd59d 100644 --- a/drivers/net/bfin_mac.c +++ b/drivers/net/bfin_mac.c @@ -122,8 +122,6 @@ static int bfin_EMAC_send(struct eth_device *dev, void *packet, int length) { int i; int result = 0; - unsigned int *buf; - buf = (unsigned int *)packet; if (length <= 0) { printf("Ethernet: bad packet size: %d\n", length);
The buf variable in bfin_mac.c is not used and produces warning, fix it. bfin_mac.c: In function 'bfin_EMAC_send': bfin_mac.c:125:16: warning: variable 'buf' set but not used [-Wunused-but-set-variable] Signed-off-by: Marek Vasut <marex@denx.de> Cc: Mike Frysinger <vapier@gentoo.org> --- drivers/net/bfin_mac.c | 2 -- 1 file changed, 2 deletions(-)