Message ID | 20120830093701.2eaad208@coso |
---|---|
State | New |
Headers | show |
On 08/30/2012 06:37 PM, Benjamin De Kosnik wrote: > Nice! Thanks. > > Here's a small patchlet to set the abi version to .18. With this, > check-abi will pass. > > tested x86/linux Benjamin, is this still uncommitted? I'm seeing abi_check failing... Thanks, Paolo.
On 09/05/2012 11:53 AM, Paolo Carlini wrote: > On 08/30/2012 06:37 PM, Benjamin De Kosnik wrote: >> Nice! Thanks. >> >> Here's a small patchlet to set the abi version to .18. With this, >> check-abi will pass. >> >> tested x86/linux > Benjamin, is this still uncommitted? I'm seeing abi_check failing... Ok, now I see that the patch is in and a default configured build is fine abi-wise. Sorry about the false alarm. If you are curious, the reason why I sent the message is that adding --enable-libstdcxx-time=rt (which should be more or less the default in the C++11 era) used not to lead to abi_check failures and it does now. Should look more into it... Paolo.
2012-08-30 Benjamin Kosnik <bkoz@redhat.com> * testsuite/util/testsuite_abi.cc (check_version): Add GLIBCXX_3.4.18. diff --git a/libstdc++-v3/testsuite/util/testsuite_abi.cc b/libstdc++-v3/testsuite/util/testsuite_abi.cc index 4721ccd..a5066cc 100644 --- a/libstdc++-v3/testsuite/util/testsuite_abi.cc +++ b/libstdc++-v3/testsuite/util/testsuite_abi.cc @@ -195,6 +195,7 @@ check_version(symbol& test, bool added) known_versions.push_back("GLIBCXX_3.4.15"); known_versions.push_back("GLIBCXX_3.4.16"); known_versions.push_back("GLIBCXX_3.4.17"); + known_versions.push_back("GLIBCXX_3.4.18"); known_versions.push_back("GLIBCXX_LDBL_3.4"); known_versions.push_back("GLIBCXX_LDBL_3.4.7"); known_versions.push_back("GLIBCXX_LDBL_3.4.10"); @@ -222,7 +223,7 @@ check_version(symbol& test, bool added) test.version_status = symbol::incompatible; // Check that added symbols are added in the latest pre-release version. - bool latestp = (test.version_name == "GLIBCXX_3.4.17" + bool latestp = (test.version_name == "GLIBCXX_3.4.18" || test.version_name == "CXXABI_1.3.6" || test.version_name == "CXXABI_TM_1"); if (added && !latestp)