| Message ID | 503F7F31.10708@gmail.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Thu 30-08-12 16:56:49, Marco Stornelli wrote: > Removed lock/unlock super. > > Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com> You can add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > fs/ext3/super.c | 6 ------ > 1 files changed, 0 insertions(+), 6 deletions(-) > > diff --git a/fs/ext3/super.c b/fs/ext3/super.c > index 8c892e9..9b3d498 100644 > --- a/fs/ext3/super.c > +++ b/fs/ext3/super.c > @@ -2571,11 +2571,9 @@ out: > static int ext3_unfreeze(struct super_block *sb) > { > if (!(sb->s_flags & MS_RDONLY)) { > - lock_super(sb); > /* Reser the needs_recovery flag before the fs is unlocked. */ > EXT3_SET_INCOMPAT_FEATURE(sb, EXT3_FEATURE_INCOMPAT_RECOVER); > ext3_commit_super(sb, EXT3_SB(sb)->s_es, 1); > - unlock_super(sb); > journal_unlock_updates(EXT3_SB(sb)->s_journal); > } > return 0; > @@ -2595,7 +2593,6 @@ static int ext3_remount (struct super_block * sb, int * flags, char * data) > #endif > > /* Store the original options */ > - lock_super(sb); > old_sb_flags = sb->s_flags; > old_opts.s_mount_opt = sbi->s_mount_opt; > old_opts.s_resuid = sbi->s_resuid; > @@ -2701,8 +2698,6 @@ static int ext3_remount (struct super_block * sb, int * flags, char * data) > old_opts.s_qf_names[i] != sbi->s_qf_names[i]) > kfree(old_opts.s_qf_names[i]); > #endif > - unlock_super(sb); > - > if (enable_quota) > dquot_resume(sb, -1); > return 0; > @@ -2721,7 +2716,6 @@ restore_opts: > sbi->s_qf_names[i] = old_opts.s_qf_names[i]; > } > #endif > - unlock_super(sb); > return err; > } > > -- > 1.7.3.4
diff --git a/fs/ext3/super.c b/fs/ext3/super.c index 8c892e9..9b3d498 100644 --- a/fs/ext3/super.c +++ b/fs/ext3/super.c @@ -2571,11 +2571,9 @@ out: static int ext3_unfreeze(struct super_block *sb) { if (!(sb->s_flags & MS_RDONLY)) { - lock_super(sb); /* Reser the needs_recovery flag before the fs is unlocked. */ EXT3_SET_INCOMPAT_FEATURE(sb, EXT3_FEATURE_INCOMPAT_RECOVER); ext3_commit_super(sb, EXT3_SB(sb)->s_es, 1); - unlock_super(sb); journal_unlock_updates(EXT3_SB(sb)->s_journal); } return 0; @@ -2595,7 +2593,6 @@ static int ext3_remount (struct super_block * sb, int * flags, char * data) #endif /* Store the original options */ - lock_super(sb); old_sb_flags = sb->s_flags; old_opts.s_mount_opt = sbi->s_mount_opt; old_opts.s_resuid = sbi->s_resuid; @@ -2701,8 +2698,6 @@ static int ext3_remount (struct super_block * sb, int * flags, char * data) old_opts.s_qf_names[i] != sbi->s_qf_names[i]) kfree(old_opts.s_qf_names[i]); #endif - unlock_super(sb); - if (enable_quota) dquot_resume(sb, -1); return 0; @@ -2721,7 +2716,6 @@ restore_opts: sbi->s_qf_names[i] = old_opts.s_qf_names[i]; } #endif - unlock_super(sb); return err; }
Removed lock/unlock super. Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com> --- fs/ext3/super.c | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-)