| Message ID | CAPgLHd86W5X=Tb_fXoz_Ood-w_s282QNePTXG9m_6ESdG-rG2A@mail.gmail.com |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
On 08/28/2012 08:11 AM, Wei Yongjun wrote: > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > Remove pointless conditional before kfree_skb(). > > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > --- > drivers/net/wireless/rtlwifi/rtl8192de/fw.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Acked-by: Larry Finger <Larry.Finger.net> Thanks, Larry > > diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/fw.c b/drivers/net/wireless/rtlwifi/rtl8192de/fw.c > index 895ae6c..a3aede0 100644 > --- a/drivers/net/wireless/rtlwifi/rtl8192de/fw.c > +++ b/drivers/net/wireless/rtlwifi/rtl8192de/fw.c > @@ -570,8 +570,7 @@ static bool _rtl92d_cmd_send_packet(struct ieee80211_hw *hw, > > ring = &rtlpci->tx_ring[BEACON_QUEUE]; > pskb = __skb_dequeue(&ring->queue); > - if (pskb) > - kfree_skb(pskb); > + kfree_skb(pskb); > spin_lock_irqsave(&rtlpriv->locks.irq_th_lock, flags); > pdesc = &ring->desc[idx]; > /* discard output from call below */ > > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/fw.c b/drivers/net/wireless/rtlwifi/rtl8192de/fw.c index 895ae6c..a3aede0 100644 --- a/drivers/net/wireless/rtlwifi/rtl8192de/fw.c +++ b/drivers/net/wireless/rtlwifi/rtl8192de/fw.c @@ -570,8 +570,7 @@ static bool _rtl92d_cmd_send_packet(struct ieee80211_hw *hw, ring = &rtlpci->tx_ring[BEACON_QUEUE]; pskb = __skb_dequeue(&ring->queue); - if (pskb) - kfree_skb(pskb); + kfree_skb(pskb); spin_lock_irqsave(&rtlpriv->locks.irq_th_lock, flags); pdesc = &ring->desc[idx]; /* discard output from call below */