| Message ID | 1345546460-32050-1-git-send-email-yhalperi@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 08/21/12 12:54, Yonit Halperin wrote: > Added all spice options to the help string. This can be used by libvirt > to determine which spice related features are supported by qemu. Patch added to spice patch queue. thanks, Gerd
On 08/21/2012 04:54 AM, Yonit Halperin wrote: > Added all spice options to the help string. This can be used by libvirt > to determine which spice related features are supported by qemu. For older released, this is true; but for future versions of qemu, libvirt would much rather learn this information from QMP commands than from scraping -help output. Can we get at all of this information from QMP?
On 08/21/2012 03:31 PM, Eric Blake wrote: > On 08/21/2012 04:54 AM, Yonit Halperin wrote: >> Added all spice options to the help string. This can be used by libvirt >> to determine which spice related features are supported by qemu. > > For older released, this is true; but for future versions of qemu, > libvirt would much rather learn this information from QMP commands than > from scraping -help output. Can we get at all of this information from QMP? > No, we don't have qmp commands for any of spice config options. I don't think it should be in the scope of this patch.
On 08/26/2012 12:38 AM, Yonit Halperin wrote: > On 08/21/2012 03:31 PM, Eric Blake wrote: >> On 08/21/2012 04:54 AM, Yonit Halperin wrote: >>> Added all spice options to the help string. This can be used by libvirt >>> to determine which spice related features are supported by qemu. >> >> For older released, this is true; but for future versions of qemu, >> libvirt would much rather learn this information from QMP commands than >> from scraping -help output. Can we get at all of this information >> from QMP? >> > No, we don't have qmp commands for any of spice config options. I don't > think it should be in the scope of this patch. But since we have already declared that 1.2 is the last release where libvirt will be scraping -help output, and that 1.3 and later will allow libvirt to query all configuration information via QMP commands, I think that you really _do_ need to consider QMP commands in the scope of this patch series, if you expect libvirt to be able to react to this information in qemu 1.3.
diff --git a/qemu-options.hx b/qemu-options.hx index 0727f4f..3872e70 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -835,7 +835,23 @@ Enable SDL. ETEXI DEF("spice", HAS_ARG, QEMU_OPTION_spice, - "-spice <args> enable spice\n", QEMU_ARCH_ALL) + "-spice [port=port][,tls-port=secured-port][,x509-dir=<dir>]\n" + " [,x509-key-file=<file>][,x509-key-password=<file>]\n" + " [,x509-cert-file=<file>][,x509-cacert-file=<file>]\n" + " [,x509-dh-key-file=<file>][,addr=addr][,ipv4|ipv6]\n" + " [,tls-ciphers=<list>]\n" + " [,tls-channel=[main|display|cursor|inputs|record|playback]]\n" + " [,plaintext-channel=[main|display|cursor|inputs|record|playback]]\n" + " [,sasl][,password=<secret>][,disable-ticketing]\n" + " [,image-compression=[auto_glz|auto_lz|quic|glz|lz|off]]\n" + " [,jpeg-wan-compression=[auto|never|always]]\n" + " [,zlib-glz-wan-compression=[auto|never|always]]\n" + " [,streaming-video=[off|all|filter]][,disable-copy-paste]\n" + " [,agent-mouse=[on|off]][,playback-compression=[on|off]]\n" + " [,seamless-migration=[on|off]]\n" + " enable spice\n" + " at least one of {port, tls-port} is mandatory\n", + QEMU_ARCH_ALL) STEXI @item -spice @var{option}[,@var{option}[,...]] @findex -spice
Added all spice options to the help string. This can be used by libvirt to determine which spice related features are supported by qemu. Signed-off-by: Yonit Halperin <yhalperi@redhat.com> --- qemu-options.hx | 18 +++++++++++++++++- 1 files changed, 17 insertions(+), 1 deletions(-)