| Message ID | 20120824135559.GA15501@bromo.med.uc.edu |
|---|---|
| State | New |
| Headers | show |
Jack Howarth <howarth@bromo.med.uc.edu> writes: > =================================================================== > --- gcc/testsuite/gcc.target/i386/asm-dialect-1.c (revision 190647) > +++ gcc/testsuite/gcc.target/i386/asm-dialect-1.c (working copy) > @@ -1,4 +1,5 @@ > /* { dg-options "-masm=intel" } */ > +/* { dg-skip-if "" { *-*-darwin* } { "*" } { "" } } */ Please add a comment explaining why this is skipped (that's what the dg-skip-if comment field is for) and omit the default arguments. I'll leave the actual approval to a darwin maintainer. Rainer
Index: gcc/testsuite/gcc.target/i386/asm-dialect-1.c warth@bromo ~]$ vi =================================================================== --- gcc/testsuite/gcc.target/i386/asm-dialect-1.c (revision 190647) +++ gcc/testsuite/gcc.target/i386/asm-dialect-1.c (working copy) @@ -1,4 +1,5 @@ /* { dg-options "-masm=intel" } */ +/* { dg-skip-if "" { *-*-darwin* } { "*" } { "" } } */ extern void abort (void);
Currently the new gcc.target/i386/asm-dialect-1.c testcase is failing on darwin due the absence of support for -masm=intel on that target. The attached patch skips this test on darwin. Tested on x86_64-apple-darwin12... http://gcc.gnu.org/ml/gcc-testresults/2012-08/msg02042.html Okay for gcc trunk? Jack 2012-08-24 Jack Howarth <howarth@bromo.med.uc.edu> PR target/54255 * gcc.target/i386/asm-dialect-1.c: Skip on darwin.