Message ID | 1345619321-4644-1-git-send-email-spdawson@gmail.com |
---|---|
State | Accepted |
Headers | show |
Le Wed, 22 Aug 2012 08:08:40 +0100, spdawson@gmail.com a écrit : > From: Simon Dawson <spdawson@gmail.com> > > Signed-off-by: Simon Dawson <spdawson@gmail.com> > --- > package/inotify-tools/inotify-tools.mk | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/package/inotify-tools/inotify-tools.mk b/package/inotify-tools/inotify-tools.mk > index 52a1701..7c37929 100644 > --- a/package/inotify-tools/inotify-tools.mk > +++ b/package/inotify-tools/inotify-tools.mk > @@ -6,3 +6,5 @@ > INOTIFY_TOOLS_VERSION = 3.14 > INOTIFY_TOOLS_SITE = http://github.com/downloads/rvoicilas/inotify-tools/ > $(eval $(autotools-package)) > +INOTIFY_TOOLS_LICENSE = GPLv2+ > +INOTIFY_TOOLS_LICENSE_FILES = COPYING I've applied this one, but modified the two licensing-related lines to be above the $(eval $(autotools-package)). Also, I am not 100% sure how to decide whether this package is GPLv2 or GPLv2+. The COPYING file contains the text of the GPLv2, but I haven't found any other place in the source code where the license was mentioned. So we don't know whether it is GPLv2 only, or "GPLv2 or later". I've applied your patch with GPLv2+, and we'll listen to comments from others if they have a better idea on how to take the proper decision on this. Thanks! Thomas
Thomas Petazzoni wrote: > Le Wed, 22 Aug 2012 08:08:40 +0100, > spdawson@gmail.com a écrit : > >> From: Simon Dawson <spdawson@gmail.com> >> >> Signed-off-by: Simon Dawson <spdawson@gmail.com> >> --- >> package/inotify-tools/inotify-tools.mk | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/package/inotify-tools/inotify-tools.mk b/package/inotify-tools/inotify-tools.mk >> index 52a1701..7c37929 100644 >> --- a/package/inotify-tools/inotify-tools.mk >> +++ b/package/inotify-tools/inotify-tools.mk >> @@ -6,3 +6,5 @@ >> INOTIFY_TOOLS_VERSION = 3.14 >> INOTIFY_TOOLS_SITE = http://github.com/downloads/rvoicilas/inotify-tools/ >> $(eval $(autotools-package)) >> +INOTIFY_TOOLS_LICENSE = GPLv2+ >> +INOTIFY_TOOLS_LICENSE_FILES = COPYING > > I've applied this one, but modified the two licensing-related lines to > be above the $(eval $(autotools-package)). > > Also, I am not 100% sure how to decide whether this package is GPLv2 or > GPLv2+. The COPYING file contains the text of the GPLv2, but I haven't > found any other place in the source code where the license was > mentioned. So we don't know whether it is GPLv2 only, or "GPLv2 or > later". > > I've applied your patch with GPLv2+, and we'll listen to comments from > others if they have a better idea on how to take the proper decision on > this. iostat has the same licensing policy. The GPLv2 (reported in the COPYING file for inotify-tools, as well as iostat) states: If the Program does not specify a version number of this License, you may choose any version ever published by the Free Software Foundation. So: INOTIFY_TOOLS_LICENSE = GPL Luca
Le Wed, 22 Aug 2012 21:54:31 +0200, Luca Ceresoli <luca@lucaceresoli.net> a écrit : > > I've applied your patch with GPLv2+, and we'll listen to comments from > > others if they have a better idea on how to take the proper decision on > > this. > > iostat has the same licensing policy. > > The GPLv2 (reported in the COPYING file for inotify-tools, as well as > iostat) > states: > > If the Program does not specify a version number of > this License, you may choose any version ever published by the Free > Software > Foundation. > > So: > INOTIFY_TOOLS_LICENSE = GPL Even if the program includes a specific version of the GPL in its COPYING file (in this case GPLv2) ? Thomas
Thomas Petazzoni wrote: > Le Wed, 22 Aug 2012 21:54:31 +0200, > Luca Ceresoli <luca@lucaceresoli.net> a écrit : > >>> I've applied your patch with GPLv2+, and we'll listen to comments from >>> others if they have a better idea on how to take the proper decision on >>> this. >> >> iostat has the same licensing policy. >> >> The GPLv2 (reported in the COPYING file for inotify-tools, as well as >> iostat) >> states: >> >> If the Program does not specify a version number of >> this License, you may choose any version ever published by the Free >> Software >> Foundation. >> >> So: >> INOTIFY_TOOLS_LICENSE = GPL > > Even if the program includes a specific version of the GPL in its > COPYING file (in this case GPLv2) ? That's the file that contains the text I quoted, so I'd say yes. I just sent a patch to fix this, but of course you should wait for other comments before applying if you're in doubt. Luca
diff --git a/package/inotify-tools/inotify-tools.mk b/package/inotify-tools/inotify-tools.mk index 52a1701..7c37929 100644 --- a/package/inotify-tools/inotify-tools.mk +++ b/package/inotify-tools/inotify-tools.mk @@ -6,3 +6,5 @@ INOTIFY_TOOLS_VERSION = 3.14 INOTIFY_TOOLS_SITE = http://github.com/downloads/rvoicilas/inotify-tools/ $(eval $(autotools-package)) +INOTIFY_TOOLS_LICENSE = GPLv2+ +INOTIFY_TOOLS_LICENSE_FILES = COPYING