| Message ID | 1345214124-5478-6-git-send-email-richard.genoud@gmail.com |
|---|---|
| State | New, archived |
| Headers | show |
Hi Richard, On Fri, 17 Aug 2012 16:35:21 +0200 Richard Genoud <richard.genoud@gmail.com> wrote: > + /* > + * A value of 0 is forced to the default value to keep the same > + * behavior between ubiattach command and module parameter > + */ Minor thing. Since the module parameter is not yet introduced (only in a later patch), and since last part of sentence isn't that important, I would simply state: + * Use the default if max_beb_per1024 isn't provided. or alike. Regards, Shmulik
Hi Shmulik, 2012/8/19 Shmulik Ladkani <shmulik.ladkani@gmail.com>: > Hi Richard, > > On Fri, 17 Aug 2012 16:35:21 +0200 Richard Genoud <richard.genoud@gmail.com> wrote: >> + /* >> + * A value of 0 is forced to the default value to keep the same >> + * behavior between ubiattach command and module parameter >> + */ > > Minor thing. > > Since the module parameter is not yet introduced (only in a later > patch), and since last part of sentence isn't that important, I would > simply state: > > + * Use the default if max_beb_per1024 isn't provided. > That's right, I'll correct that in next version. Thanks !
On Mon, 2012-08-20 at 08:31 +0200, Richard Genoud wrote: > That's right, I'll correct that in next version. > Thanks ! I've amended this patch, added Shmulik's reviewed-by and pushed to linux-ubi.git, thanks!
On Mon, 2012-08-20 at 11:25 +0300, Artem Bityutskiy wrote: > On Mon, 2012-08-20 at 08:31 +0200, Richard Genoud wrote: > > That's right, I'll correct that in next version. > > Thanks ! > > I've amended this patch, added Shmulik's reviewed-by and pushed to > linux-ubi.git, thanks! Sorry, actually I've dropped it - it does not compile :-) Please, send bisectable patch-sets. Anyway, I expect you to re-send patches 5-8. P.S. I am not sure we need to CC arm mailing list and lkml - I think we spam them unnecessarily and the MTD list is enough.
diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c index 58fe53d..ec7311f 100644 --- a/drivers/mtd/ubi/build.c +++ b/drivers/mtd/ubi/build.c @@ -855,6 +855,16 @@ int ubi_attach_mtd_dev(struct mtd_info *mtd, int ubi_num, struct ubi_device *ubi; int i, err, ref = 0; + if (max_beb_per1024 < 0) + return -EINVAL; + + /* + * A value of 0 is forced to the default value to keep the same + * behavior between ubiattach command and module parameter + */ + if (!max_beb_per1024) + max_beb_per1024 = CONFIG_MTD_UBI_BEB_LIMIT; + /* * Check if we already have the same MTD device attached. *
max_beb_per1024 shouldn't be negative, and a 0 value will be treated as the default value. Signed-off-by: Richard Genoud <richard.genoud@gmail.com> --- drivers/mtd/ubi/build.c | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-)