Message ID | 50290FFE.9000105@sfr.fr |
---|---|
State | New |
Headers | show |
On 08/13/2012 04:32 PM, Mikael Morin wrote: > here is a fix for PR47586: missing deep copy for the case: > dt_w_alloc = ptr_func(arg) The patch set looks okay. I am not 100% sure how compatible your changes are with regards to finalization and coarray components, but I have the impression they don't make thinks worse. Regarding the comment: "A data-pointer-returning function should be considered as a variable too." That's actually true according to the standard, which since F2008 allows: f() = 7 where f() returns a pointer. Well, gfortran doesn't support this yet and there are also some issues if the LHS is an operator expression (see current interpretation request discussions), but I thought I mention it for completeness. Thanks for the patch! - And for the thorough patch reviews! Tobias
2012-08-13 Mikael Morin <mikael@gcc.gnu.org> PR fortran/47586 * gfortran.dg/typebound_proc_20.f90: Enable runtime test. * gfortran.dg/typebound_proc_26.f03: New test. diff --git a/gcc/testsuite/gfortran.dg/typebound_proc_20.f90 b/gcc/testsuite/gfortran.dg/typebound_proc_20.f90 index b63daf9..47c131c 100644 --- a/gcc/testsuite/gfortran.dg/typebound_proc_20.f90 +++ b/gcc/testsuite/gfortran.dg/typebound_proc_20.f90 @@ -1,5 +1,4 @@ -! { dg-do compile } -! TODO: make runtime testcase once bug is fixed +! { dg-do run } ! ! PR fortran/47455 !