Message ID | 20120810161021.GG3306@bill-the-cat |
---|---|
State | Changes Requested |
Delegated to: | Albert ARIBAUD |
Headers | show |
Dear Tom, In message <20120810161021.GG3306@bill-the-cat> you wrote: > > To try and ease the backlog of ARM changes, I've taken the liberty of > grabbing the Snowball and Raspberry Pi model B board support patches and > putting them into the staging tree. Both of these series have been > posted for some time and been reviewed. Wolfgang, if you would like to > wait for Albert to pick up this request, that's fine. I just wanted to > make sure the submitters weren't left waiting. Thanks! Thanks, highly appreciated. As this contains a lot of ARM, indeed I would like to wait for Albert's ACK or pulling (whichever he prefers). Best regards, Wolfgang Denk
Hi Tom, On Fri, 10 Aug 2012 22:06:59 +0200, Wolfgang Denk <wd@denx.de> wrote: > Dear Tom, > > In message <20120810161021.GG3306@bill-the-cat> you wrote: > > > > To try and ease the backlog of ARM changes, I've taken the liberty > > of grabbing the Snowball and Raspberry Pi model B board support > > patches and putting them into the staging tree. Both of these > > series have been posted for some time and been reviewed. Wolfgang, > > if you would like to wait for Albert to pick up this request, > > that's fine. I just wanted to make sure the submitters weren't > > left waiting. Thanks! > > Thanks, highly appreciated. > > As this contains a lot of ARM, indeed I would like to wait for > Albert's ACK or pulling (whichever he prefers). > > Best regards, > > Wolfgang Denk > Applied to u-boot-arm/master, thanks! Amicalement,
Hi Albert, On Tue, 14 Aug 2012 02:04:15 +0200, Albert ARIBAUD (U-Boot) <albert.u.boot@aribaud.net> wrote: > Hi Tom, > > On Fri, 10 Aug 2012 22:06:59 +0200, Wolfgang Denk <wd@denx.de> wrote: > > > Dear Tom, > > > > In message <20120810161021.GG3306@bill-the-cat> you wrote: > > > > > > To try and ease the backlog of ARM changes, I've taken the liberty > > > of grabbing the Snowball and Raspberry Pi model B board support > > > patches and putting them into the staging tree. Both of these > > > series have been posted for some time and been reviewed. > > > Wolfgang, if you would like to wait for Albert to pick up this > > > request, that's fine. I just wanted to make sure the submitters > > > weren't left waiting. Thanks! > > > > Thanks, highly appreciated. > > > > As this contains a lot of ARM, indeed I would like to wait for > > Albert's ACK or pulling (whichever he prefers). > > > > Best regards, > > > > Wolfgang Denk > > > > Applied to u-boot-arm/master, thanks! But I might hold this a little, as commit "snowball: Adding architecture dependent initialisation" 7e2b895eb5aa10890910eed8921d042d13b828c0 seems to play bad with my stock Ubuntu 12.04 GCC on u8500_href: uboot@lilith:~/src/u-boot-arm$ git checkout f917361b988f69ddc0dbe2bd2beb93b296065b70^ HEAD is now at 1b5d8d5... u8500: Moving prcmu to cpu directory uboot@lilith:~/src/u-boot-arm$ LANG=C ./MAKEALL u8500_href Configuring for u8500_href board... text data bss dec hex filename 139584 4408 221728 365720 59498 ./u-boot --------------------- SUMMARY ---------------------------- Boards compiled: 1 ---------------------------------------------------------- uboot@lilith:~/src/u-boot-arm$ git checkout f917361b988f69ddc0dbe2bd2beb93b296065b70 Previous HEAD position was 1b5d8d5... u8500: Moving prcmu to cpu directory HEAD is now at f917361... snowball: Adding architecture dependent initialisation uboot@lilith:~/src/u-boot-arm$ LANG=C ./MAKEALL u8500_href Configuring for u8500_href board... text data bss dec hex filename 139744 4408 221696 365848 59518 ./u-boot u8500_href.c:45:0: warning: "PRCMU_BASE" redefined [enabled by default] /home/uboot/src/u-boot-arm/include/asm/arch/prcmu.h:30:0: note: this is the location of the previous definition --------------------- SUMMARY ---------------------------- Boards compiled: 1 Boards with warnings but no errors: 1 ( u8500_href ) ---------------------------------------------------------- Granted, this is only a warning, but I'd like to see it fixed. Amicalement,
I will fix this right away. Mathieu. On 12-08-13 07:06 PM, Albert ARIBAUD (U-Boot) wrote: > Hi Albert, > > On Tue, 14 Aug 2012 02:04:15 +0200, Albert ARIBAUD (U-Boot) > <albert.u.boot@aribaud.net> wrote: > >> Hi Tom, >> >> On Fri, 10 Aug 2012 22:06:59 +0200, Wolfgang Denk <wd@denx.de> wrote: >> >>> Dear Tom, >>> >>> In message <20120810161021.GG3306@bill-the-cat> you wrote: >>>> >>>> To try and ease the backlog of ARM changes, I've taken the liberty >>>> of grabbing the Snowball and Raspberry Pi model B board support >>>> patches and putting them into the staging tree. Both of these >>>> series have been posted for some time and been reviewed. >>>> Wolfgang, if you would like to wait for Albert to pick up this >>>> request, that's fine. I just wanted to make sure the submitters >>>> weren't left waiting. Thanks! >>> >>> Thanks, highly appreciated. >>> >>> As this contains a lot of ARM, indeed I would like to wait for >>> Albert's ACK or pulling (whichever he prefers). >>> >>> Best regards, >>> >>> Wolfgang Denk >>> >> >> Applied to u-boot-arm/master, thanks! > > But I might hold this a little, as commit "snowball: Adding > architecture dependent initialisation" > 7e2b895eb5aa10890910eed8921d042d13b828c0 seems to play bad with my > stock Ubuntu 12.04 GCC on u8500_href: > > uboot@lilith:~/src/u-boot-arm$ git checkout > f917361b988f69ddc0dbe2bd2beb93b296065b70^ HEAD is now at 1b5d8d5... > u8500: Moving prcmu to cpu directory uboot@lilith:~/src/u-boot-arm$ > LANG=C ./MAKEALL u8500_href Configuring for u8500_href board... > text data bss dec > hex filename 139584 4408 221728 > 365720 59498 ./u-boot > > --------------------- SUMMARY ---------------------------- > Boards compiled: 1 > ---------------------------------------------------------- > uboot@lilith:~/src/u-boot-arm$ git checkout > f917361b988f69ddc0dbe2bd2beb93b296065b70 Previous HEAD position was > 1b5d8d5... u8500: Moving prcmu to cpu directory HEAD is now at > f917361... snowball: Adding architecture dependent initialisation > uboot@lilith:~/src/u-boot-arm$ LANG=C ./MAKEALL u8500_href Configuring > for u8500_href board... text data bss > dec hex filename 139744 4408 > 221696 365848 59518 ./u-boot u8500_href.c:45:0: > warning: "PRCMU_BASE" redefined [enabled by > default] /home/uboot/src/u-boot-arm/include/asm/arch/prcmu.h:30:0: > note: this is the location of the previous definition > > --------------------- SUMMARY ---------------------------- > Boards compiled: 1 > Boards with warnings but no errors: 1 ( u8500_href ) > ---------------------------------------------------------- > > Granted, this is only a warning, but I'd like to see it fixed. > > Amicalement,
On Tue, Aug 14, 2012 at 03:06:17AM +0200, Albert ARIBAUD wrote: > Hi Albert, > > On Tue, 14 Aug 2012 02:04:15 +0200, Albert ARIBAUD (U-Boot) > <albert.u.boot@aribaud.net> wrote: > > > Hi Tom, > > > > On Fri, 10 Aug 2012 22:06:59 +0200, Wolfgang Denk <wd@denx.de> wrote: > > > > > Dear Tom, > > > > > > In message <20120810161021.GG3306@bill-the-cat> you wrote: > > > > > > > > To try and ease the backlog of ARM changes, I've taken the liberty > > > > of grabbing the Snowball and Raspberry Pi model B board support > > > > patches and putting them into the staging tree. Both of these > > > > series have been posted for some time and been reviewed. > > > > Wolfgang, if you would like to wait for Albert to pick up this > > > > request, that's fine. I just wanted to make sure the submitters > > > > weren't left waiting. Thanks! > > > > > > Thanks, highly appreciated. > > > > > > As this contains a lot of ARM, indeed I would like to wait for > > > Albert's ACK or pulling (whichever he prefers). > > > > > > Best regards, > > > > > > Wolfgang Denk > > > > > > > Applied to u-boot-arm/master, thanks! > > But I might hold this a little, as commit "snowball: Adding > architecture dependent initialisation" > 7e2b895eb5aa10890910eed8921d042d13b828c0 seems to play bad with my > stock Ubuntu 12.04 GCC on u8500_href: > > uboot@lilith:~/src/u-boot-arm$ git checkout > f917361b988f69ddc0dbe2bd2beb93b296065b70^ HEAD is now at 1b5d8d5... > u8500: Moving prcmu to cpu directory uboot@lilith:~/src/u-boot-arm$ > LANG=C ./MAKEALL u8500_href Configuring for u8500_href board... > text data bss dec > hex filename 139584 4408 221728 > 365720 59498 ./u-boot > > --------------------- SUMMARY ---------------------------- > Boards compiled: 1 > ---------------------------------------------------------- > uboot@lilith:~/src/u-boot-arm$ git checkout > f917361b988f69ddc0dbe2bd2beb93b296065b70 Previous HEAD position was > 1b5d8d5... u8500: Moving prcmu to cpu directory HEAD is now at > f917361... snowball: Adding architecture dependent initialisation > uboot@lilith:~/src/u-boot-arm$ LANG=C ./MAKEALL u8500_href Configuring > for u8500_href board... text data bss > dec hex filename 139744 4408 > 221696 365848 59518 ./u-boot u8500_href.c:45:0: > warning: "PRCMU_BASE" redefined [enabled by > default] /home/uboot/src/u-boot-arm/include/asm/arch/prcmu.h:30:0: > note: this is the location of the previous definition > > --------------------- SUMMARY ---------------------------- > Boards compiled: 1 > Boards with warnings but no errors: 1 ( u8500_href ) > ---------------------------------------------------------- > > Granted, this is only a warning, but I'd like to see it fixed. I've taken Mathieu's updated patch and pushed the series again to u-boot-staging/trini@ti.com. A git reset --hard a1cd53c6b6e2e7fbf4ffa20d3548646e4c94efe5 and then pull of my tree will get things back in shape. I've done a MAKEALL -s u8500 and it's fine now and I'm kicking off a -a arm.