Message ID | 20120811155109.GB14041@kam.mff.cuni.cz |
---|---|
State | New |
Headers | show |
On Sat, Aug 11, 2012 at 5:51 PM, Jan Hubicka <hubicka@ucw.cz> wrote: > Hi, > my prevoius LTO cleanup run into problem with plugin enabled builds; > lto-plugin is stupid enought to confused symtab_nodes section with symtab > because it ignores the suffixes. Err, I suppose we should fix the plugin as well. It likely does that because it thinks its suffixes for the partial-link stuff? Richard. > Fixed thus. Comitted as obvoius. > Honza > > Index: ChangeLog > =================================================================== > --- ChangeLog (revision 190316) > +++ ChangeLog (working copy) > @@ -1,3 +1,8 @@ > +2012-08-11 Jan Hubicka <jh@suse.cz> > + > + * lto-section-in.c (lto_section_name): Do not use "symtab" as part of > + symtab_node sectoin name; it confuses plugin. > + > 2012-08-11 Uros Bizjak <ubizjak@gmail.com> > > * config/alpha/alpha.c (alpha_stdarg_optimize_hook): Shift DECL_UID > Index: lto-section-in.c > =================================================================== > --- lto-section-in.c (revision 190312) > +++ lto-section-in.c (working copy) > @@ -55,7 +55,7 @@ const char *lto_section_name[LTO_N_SECTI > "jmpfuncs", > "pureconst", > "reference", > - "symtab_nodes", > + "symbol_nodes", > "opts", > "cgraphopt", > "inline"
> On Sat, Aug 11, 2012 at 5:51 PM, Jan Hubicka <hubicka@ucw.cz> wrote: > > Hi, > > my prevoius LTO cleanup run into problem with plugin enabled builds; > > lto-plugin is stupid enought to confused symtab_nodes section with symtab > > because it ignores the suffixes. > > Err, I suppose we should fix the plugin as well. It likely does that because > it thinks its suffixes for the partial-link stuff? Yes, I will test patch matching symtab. instead of symtab string. That should be enough. Honza > > Richard. > > > Fixed thus. Comitted as obvoius. > > Honza > > > > Index: ChangeLog > > =================================================================== > > --- ChangeLog (revision 190316) > > +++ ChangeLog (working copy) > > @@ -1,3 +1,8 @@ > > +2012-08-11 Jan Hubicka <jh@suse.cz> > > + > > + * lto-section-in.c (lto_section_name): Do not use "symtab" as part of > > + symtab_node sectoin name; it confuses plugin. > > + > > 2012-08-11 Uros Bizjak <ubizjak@gmail.com> > > > > * config/alpha/alpha.c (alpha_stdarg_optimize_hook): Shift DECL_UID > > Index: lto-section-in.c > > =================================================================== > > --- lto-section-in.c (revision 190312) > > +++ lto-section-in.c (working copy) > > @@ -55,7 +55,7 @@ const char *lto_section_name[LTO_N_SECTI > > "jmpfuncs", > > "pureconst", > > "reference", > > - "symtab_nodes", > > + "symbol_nodes", > > "opts", > > "cgraphopt", > > "inline"
Index: ChangeLog =================================================================== --- ChangeLog (revision 190316) +++ ChangeLog (working copy) @@ -1,3 +1,8 @@ +2012-08-11 Jan Hubicka <jh@suse.cz> + + * lto-section-in.c (lto_section_name): Do not use "symtab" as part of + symtab_node sectoin name; it confuses plugin. + 2012-08-11 Uros Bizjak <ubizjak@gmail.com> * config/alpha/alpha.c (alpha_stdarg_optimize_hook): Shift DECL_UID Index: lto-section-in.c =================================================================== --- lto-section-in.c (revision 190312) +++ lto-section-in.c (working copy) @@ -55,7 +55,7 @@ const char *lto_section_name[LTO_N_SECTI "jmpfuncs", "pureconst", "reference", - "symtab_nodes", + "symbol_nodes", "opts", "cgraphopt", "inline"