| Message ID | 1344591170-13638-2-git-send-email-u.kleine-koenig@pengutronix.de |
|---|---|
| State | New |
| Headers | show |
On 8/10/12, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > + serial@43f90000 { > + status = "okay"; > + }; > + > + serial@43f94000 { > + status = "okay"; > + }; On other i.MX boards the format is:
On 8/10/12, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > + serial@43f90000 { > + status = "okay"; > + }; > + > + serial@43f94000 { > + status = "okay"; On other i.mx boards the format is: uart1: serial@43f90000 Should the same be done here? This would allow to quickly recognize the port number without having to look at the datasheet or .dtsi file. Regards, Fabio Estevam
Hello Fabio, On Fri, Aug 10, 2012 at 10:38:02AM -0300, Fabio Estevam wrote: > On 8/10/12, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > > + serial@43f90000 { > > + status = "okay"; > > + }; > > + > > + serial@43f94000 { > > + status = "okay"; > > On other i.mx boards the format is: > > uart1: serial@43f90000 > > Should the same be done here? I don't care much, but I like to minimize duplication. As dtc bails out if you get it wrong it would be ok for me to keep the label. Best regards Uwe
On Fri, Aug 10, 2012 at 11:32:50AM +0200, Uwe Kleine-König wrote: > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > -- > changes since (implicit) v1 > (id:1343922986-32469-2-git-send-email-u.kleine-koenig@pengutronix.de) > > - add newlines between nodes > - adapt to changes in patch 1 > --- > arch/arm/boot/dts/phytec-pcm043.dtsi | 57 ++++++++++++++++++++++++++++++++++ > 1 file changed, 57 insertions(+) > create mode 100644 arch/arm/boot/dts/phytec-pcm043.dtsi > Follow the imx dts naming pattern to name it imx35-phytec-pcm043.dtsi?
diff --git a/arch/arm/boot/dts/phytec-pcm043.dtsi b/arch/arm/boot/dts/phytec-pcm043.dtsi new file mode 100644 index 0000000..e3b8690 --- /dev/null +++ b/arch/arm/boot/dts/phytec-pcm043.dtsi @@ -0,0 +1,57 @@ +/include/ "imx35.dtsi" + +/ { + soc { + aips@40000000 { /* AIPS1 */ + i2c@43f80000 { + status = "okay"; + + tempsens@4a { + compatible = "maxim,ds75"; + reg = <0x4a>; + }; + + rtc8564@51 { + compatible = "nxp,pcf8563"; + reg = <0x51>; + }; + + at24@52 { + compatible = "at,24c32"; + reg = <0x52>; + pagesize = <32>; + }; + }; + + serial@43f90000 { + status = "okay"; + }; + + serial@43f94000 { + status = "okay"; + }; + }; + + spba@50000000 { + serial@5000c000 { + status = "okay"; + }; + + fec@50038000 { + status = "okay"; + }; + }; + + emi@80000000 { + nor@a0000000 { + compatible = "cfi-flash"; + reg = <0xa0000000 0x2000000>; + bank-width = <2>; + }; + + nand@bb000000 { + status = "okay"; + }; + }; + }; +};
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> -- changes since (implicit) v1 (id:1343922986-32469-2-git-send-email-u.kleine-koenig@pengutronix.de) - add newlines between nodes - adapt to changes in patch 1 --- arch/arm/boot/dts/phytec-pcm043.dtsi | 57 ++++++++++++++++++++++++++++++++++ 1 file changed, 57 insertions(+) create mode 100644 arch/arm/boot/dts/phytec-pcm043.dtsi