Message ID | 7C6479EB2BF52547AC332FD6034646DA01448EB694@exchdb03.mips.com |
---|---|
State | New |
Headers | show |
On Thu, 9 Aug 2012, Fu, Chao-Ying wrote: > How about this patch? Just enable it for MIPS that provides link.h in Android NDK. > Thanks a lot! Please don't put this sort of architecture conditional in an architecture-independent source file. In this case it should be fine for libgcc's configure to try compiling a file that #includes <link.h> (obviously, make sure the configure test gets the right results both when it's present and when it's absent), and use the results of that configure test instead of defined(__mips__). (In a bootstrap where libc headers aren't yet present, inhibit_libc should be defined anyway to disable those libgcc features depending on system headers from libc.)
Index: unwind-dw2-fde-dip.c =================================================================== --- unwind-dw2-fde-dip.c (revision 190260) +++ unwind-dw2-fde-dip.c (working copy) @@ -55,6 +55,7 @@ #if !defined(inhibit_libc) && defined(HAVE_LD_EH_FRAME_HDR) \ && defined(__BIONIC__) + && defined(__mips__) # define USE_PT_GNU_EH_FRAME #endif