[U-Boot,v4] at91: Add support for taskit AT91SAM9G20 boards.

This adds support for the AT91SAM9G20 boards by taskit GmbH.
Both boards, Stamp9G20 and PortuxG20, are integrated in one
file. PortuxG20 is basically a SBC built around the Stamp9G20.

Signed-off-by: Markus Hubig <mhubig@imko.de>
Cc: Andreas Bießmann <andreas.devel@googlemail.com>
---
 MAINTAINERS                        |   16 ++-
 board/taskit/stamp9g20/Makefile    |   53 +++++++
 board/taskit/stamp9g20/led.c       |  134 ++++++++++++++++++
 board/taskit/stamp9g20/stamp9g20.c |  192 ++++++++++++++++++++++++++
 boards.cfg                         |    2 +
 include/configs/stamp9g20.h        |  267 ++++++++++++++++++++++++++++++++++++
 6 files changed, 658 insertions(+), 6 deletions(-)
 create mode 100644 board/taskit/stamp9g20/Makefile
 create mode 100644 board/taskit/stamp9g20/led.c
 create mode 100644 board/taskit/stamp9g20/stamp9g20.c
 create mode 100644 include/configs/stamp9g20.h

Dear Markus Hubig,

On 06.08.2012 11:11, Markus Hubig wrote:
> This adds support for the AT91SAM9G20 boards by taskit GmbH.
> Both boards, Stamp9G20 and PortuxG20, are integrated in one
> file. PortuxG20 is basically a SBC built around the Stamp9G20.
> 
> Signed-off-by: Markus Hubig <mhubig@imko.de>
> Cc: Andreas Bießmann <andreas.devel@googlemail.com>
> ---

please read http://www.denx.de/wiki/U-Boot/Patches, especially
http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions

(patch changes missing)

>  MAINTAINERS                        |   16 ++-
>  board/taskit/stamp9g20/Makefile    |   53 +++++++
>  board/taskit/stamp9g20/led.c       |  134 ++++++++++++++++++
>  board/taskit/stamp9g20/stamp9g20.c |  192 ++++++++++++++++++++++++++
>  boards.cfg                         |    2 +
>  include/configs/stamp9g20.h        |  267 ++++++++++++++++++++++++++++++++++++
>  6 files changed, 658 insertions(+), 6 deletions(-)
>  create mode 100644 board/taskit/stamp9g20/Makefile
>  create mode 100644 board/taskit/stamp9g20/led.c
>  create mode 100644 board/taskit/stamp9g20/stamp9g20.c
>  create mode 100644 include/configs/stamp9g20.h
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 84413de..7eb55db 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -243,12 +243,6 @@ Klaus Heydeck <heydeck@kieback-peter.de>
>  	KUP4K		MPC855
>  	KUP4X		MPC859
>  
> -Ilko Iliev <iliev@ronetix.at>
> -
> -	PM9261		AT91SAM9261
> -	PM9263		AT91SAM9263
> -	PM9G45		ARM926EJS (AT91SAM9G45 SoC)
> -

NAK, this is a separate patch (already on the list)

>  Gary Jennejohn <garyj@denx.de>
>  
>  	quad100hd	PPC405EP
> @@ -681,10 +675,20 @@ Vaibhav Hiremath <hvaibhav@ti.com>
>  
>  	am3517_evm	ARM ARMV7 (AM35x SoC)
>  
> +Markus Hubig <mhubig@imko.de>
> +
> +	STAMP9G20	ARM926EJS
> +
>  Grazvydas Ignotas <notasas@gmail.com>
>  
>  	omap3_pandora	ARM ARMV7 (OMAP3xx SoC)
>  
> +Ilko Iliev <iliev@ronetix.at>
> +
> +	PM9261		AT91SAM9261
> +	PM9263		AT91SAM9263
> +	PM9G45		ARM926EJS (AT91SAM9G45 SoC)
> +
>  Michael Jones <michael.jones@matrix-vision.de>
>  
>  	omap3_mvblx	ARM ARMV7 (OMAP3xx SoC)
> diff --git a/board/taskit/stamp9g20/Makefile b/board/taskit/stamp9g20/Makefile
> new file mode 100644
> index 0000000..4f17a27
> --- /dev/null
> +++ b/board/taskit/stamp9g20/Makefile
> @@ -0,0 +1,53 @@
> +#
> +# (C) Copyright 2003-2008
> +# Wolfgang Denk, DENX Software Engineering, wd@denx.de.
> +#
> +# (C) Copyright 2008
> +# Stelian Pop <stelian@popies.net>
> +# Lead Tech Design <www.leadtechdesign.com>
> +#
> +# (C) Copyright 2012
> +# Markus Hubig <mhubig@imko.de>
> +# IMKO GmbH <www.imko.de>
> +#
> +# See file CREDITS for list of people who contributed to this
> +# project.
> +#
> +# This program is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU General Public License as
> +# published by the Free Software Foundation; either version 2 of
> +# the License, or (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write to the Free Software
> +# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> +# MA 02111-1307 USA
> +#
> +
> +include $(TOPDIR)/config.mk
> +
> +LIB	= $(obj)lib$(BOARD).o
> +
> +COBJS-y	+= stamp9g20.o
> +COBJS-y	+= led.o
> +
> +SRCS	:= $(SOBJS:.o=.S) $(COBJS-y:.o=.c)
> +OBJS	:= $(addprefix $(obj),$(COBJS-y))
> +SOBJS	:= $(addprefix $(obj),$(SOBJS))
> +
> +$(LIB):	$(obj).depend $(OBJS) $(SOBJS)
> +	$(call cmd_link_o_target, $(OBJS) $(SOBJS))
> +
> +#########################################################################
> +
> +# defines $(obj).depend target
> +include $(SRCTREE)/rules.mk
> +
> +sinclude $(obj).depend
> +
> +#########################################################################
> diff --git a/board/taskit/stamp9g20/led.c b/board/taskit/stamp9g20/led.c
> new file mode 100644
> index 0000000..13dae39
> --- /dev/null
> +++ b/board/taskit/stamp9g20/led.c
> @@ -0,0 +1,134 @@
> +/*
> + * Copyright (c) 2009 Wind River Systems, Inc.
> + * Tom Rix <Tom.Rix@windriver.com>
> + * (C) Copyright 2009
> + * Eric Benard <eric@eukrea.com>
> + *
> + * (C) Copyright 2012
> + * Markus Hubig <mhubig@imko.de>
> + * IMKO GmbH <www.imko.de>
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +#include <common.h>
> +#include <asm/io.h>
> +#include <asm/arch/gpio.h>
> +#include <status_led.h>
> +
> +static unsigned int saved_state[3] = {STATUS_LED_OFF,
> +	STATUS_LED_OFF, STATUS_LED_OFF};
> +
> +void coloured_LED_init(void)
> +{
> +	/* Clock is enabled in board_early_init_f() */

But coloured_LED_init() is called way before!

Beware, this coloured LED stuff is sometimes used for very early debug
purposes. To get this working you will need to switch the clocks here.

If you not insist on this colour LED framework I would appreciate to not
add this coloured_LED_init for the stamp9g20 but use the status LED
framework -> README.LED

> +
> +	at91_set_gpio_output(CONFIG_RED_LED, 1);
> +	at91_set_gpio_output(CONFIG_GREEN_LED, 1);
> +	at91_set_gpio_output(CONFIG_YELLOW_LED, 1);
> +
> +	at91_set_gpio_value(CONFIG_RED_LED, 0);
> +	at91_set_gpio_value(CONFIG_GREEN_LED, 1);
> +	at91_set_gpio_value(CONFIG_YELLOW_LED, 0);
> +}
> +
> +void red_led_on(void)
> +{
> +	at91_set_gpio_value(CONFIG_RED_LED, 1);
> +	saved_state[STATUS_LED_RED] = STATUS_LED_ON;
> +}
> +
> +void red_led_off(void)
> +{
> +	at91_set_gpio_value(CONFIG_RED_LED, 0);
> +	saved_state[STATUS_LED_RED] = STATUS_LED_OFF;
> +}
> +
> +void green_led_on(void)
> +{
> +	at91_set_gpio_value(CONFIG_GREEN_LED, 1);
> +	saved_state[STATUS_LED_GREEN] = STATUS_LED_ON;
> +}
> +
> +void green_led_off(void)
> +{
> +	at91_set_gpio_value(CONFIG_GREEN_LED, 0);
> +	saved_state[STATUS_LED_GREEN] = STATUS_LED_OFF;
> +}
> +
> +void yellow_led_on(void)
> +{
> +	at91_set_gpio_value(CONFIG_YELLOW_LED, 1);
> +	saved_state[STATUS_LED_YELLOW] = STATUS_LED_ON;
> +}
> +
> +void yellow_led_off(void)
> +{
> +	at91_set_gpio_value(CONFIG_YELLOW_LED, 0);
> +	saved_state[STATUS_LED_YELLOW] = STATUS_LED_OFF;
> +}
> +
> +void __led_init(led_id_t mask, int state)
> +{
> +	__led_set(mask, state);
> +}
> +
> +void __led_toggle(led_id_t mask)
> +{
> +	if (STATUS_LED_RED == mask) {
> +		if (STATUS_LED_ON == saved_state[STATUS_LED_RED])
> +			red_led_off();
> +		else
> +			red_led_on();
> +
> +	} else if (STATUS_LED_GREEN == mask) {
> +		if (STATUS_LED_ON == saved_state[STATUS_LED_GREEN])
> +			green_led_off();
> +		else
> +			green_led_on();
> +
> +	} else if (STATUS_LED_YELLOW == mask) {
> +		if (STATUS_LED_ON == saved_state[STATUS_LED_YELLOW])
> +			yellow_led_off();
> +		else
> +			yellow_led_on();
> +	}
> +}
> +
> +void __led_set(led_id_t mask, int state)
> +{
> +	if (STATUS_LED_RED == mask) {
> +		if (STATUS_LED_ON == state)
> +			red_led_on();
> +		else
> +			red_led_off();
> +
> +	} else if (STATUS_LED_GREEN == mask) {
> +		if (STATUS_LED_ON == state)
> +			green_led_on();
> +		else
> +			green_led_off();
> +
> +	} else if (STATUS_LED_YELLOW == mask) {
> +		if (STATUS_LED_ON == state)
> +			yellow_led_on();
> +		else
> +			yellow_led_off();
> +	}
> +}
> diff --git a/board/taskit/stamp9g20/stamp9g20.c b/board/taskit/stamp9g20/stamp9g20.c
> new file mode 100644
> index 0000000..c85e6c3
> --- /dev/null
> +++ b/board/taskit/stamp9g20/stamp9g20.c
> @@ -0,0 +1,192 @@
> +/*
> + * (C) Copyright 2007-2008
> + * Stelian Pop <stelian@popies.net>
> + * Lead Tech Design <www.leadtechdesign.com>
> + *
> + * Achim Ehrlich <aehrlich@taskit.de>
> + * taskit GmbH <www.taskit.de>
> + *
> + * (C) Copyright 2012-
> + * Markus Hubig <mhubig@imko.de>
> + * IMKO GmbH <www.imko.de>
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +#include <common.h>
> +#include <asm/io.h>
> +#include <asm/arch/at91sam9260_matrix.h>
> +#include <asm/arch/at91sam9_smc.h>
> +#include <asm/arch/at91_common.h>
> +#include <asm/arch/at91_pmc.h>
> +#include <asm/arch/at91_rstc.h>
> +#include <asm/arch/gpio.h>
> +#include <watchdog.h>
> +
> +#ifdef CONFIG_MACB
> +# include <net.h>
> +# include <netdev.h>
> +#endif
> +
> +DECLARE_GLOBAL_DATA_PTR;
> +
> +static void stamp9G20_nand_hw_init(void)
> +{
> +	struct at91_smc *smc = (struct at91_smc *)ATMEL_BASE_SMC;
> +	struct at91_matrix *matrix = (struct at91_matrix *)ATMEL_BASE_MATRIX;
> +	unsigned long csa;
> +
> +	/* Assign CS3 to NAND/SmartMedia Interface */
> +	csa = readl(&matrix->ebicsa);
> +	csa |= AT91_MATRIX_CS3A_SMC_SMARTMEDIA;
> +	writel(csa, &matrix->ebicsa);
> +
> +	/* Configure SMC CS3 for NAND/SmartMedia */
> +	writel(AT91_SMC_SETUP_NWE(1) | AT91_SMC_SETUP_NCS_WR(0) |
> +		AT91_SMC_SETUP_NRD(1) | AT91_SMC_SETUP_NCS_RD(0),
> +		&smc->cs[3].setup);
> +	writel(AT91_SMC_PULSE_NWE(3) | AT91_SMC_PULSE_NCS_WR(3) |
> +		AT91_SMC_PULSE_NRD(3) | AT91_SMC_PULSE_NCS_RD(3),
> +		&smc->cs[3].pulse);
> +	writel(AT91_SMC_CYCLE_NWE(5) | AT91_SMC_CYCLE_NRD(5),
> +		&smc->cs[3].cycle);
> +	writel(AT91_SMC_MODE_RM_NRD | AT91_SMC_MODE_WM_NWE |
> +		AT91_SMC_MODE_EXNW_DISABLE |
> +		AT91_SMC_MODE_DBW_8 |
> +		AT91_SMC_MODE_TDF_CYCLE(2),
> +		&smc->cs[3].mode);
> +
> +	/* Configure RDY/BSY */
> +	at91_set_gpio_input(CONFIG_SYS_NAND_READY_PIN, 1);
> +
> +	/* Enable NandFlash */
> +	at91_set_gpio_output(CONFIG_SYS_NAND_ENABLE_PIN, 1);
> +}
> +
> +#ifdef CONFIG_MACB
> +static void stamp9G20_macb_hw_init(void)
> +{
> +	struct at91_port *pioa = (struct at91_port *)ATMEL_BASE_PIOA;
> +	struct at91_rstc *rstc = (struct at91_rstc *)ATMEL_BASE_RSTC;
> +	unsigned long erstl;
> +
> +	/* Enable the PHY Chip via PA26 on the Stamp 2 Adaptor */
> +	at91_set_gpio_output(AT91_PIN_PA26, 0);
> +
> +	/*
> +	 * Disable pull-up on:
> +	 *	RXDV (PA17) => PHY normal mode (not Test mode)
> +	 *	ERX0 (PA14) => PHY ADDR0
> +	 *	ERX1 (PA15) => PHY ADDR1
> +	 *	ERX2 (PA25) => PHY ADDR2
> +	 *	ERX3 (PA26) => PHY ADDR3
> +	 *	ECRS (PA28) => PHY ADDR4  => PHYADDR = 0x0
> +	 *
> +	 * PHY has internal pull-down
> +	 */
> +	writel(pin_to_mask(AT91_PIN_PA14) |
> +		pin_to_mask(AT91_PIN_PA15) |
> +		pin_to_mask(AT91_PIN_PA17) |
> +		pin_to_mask(AT91_PIN_PA18) |
> +		pin_to_mask(AT91_PIN_PA28),
> +		&pioa->pudr);
> +
> +	erstl = readl(&rstc->mr) & AT91_RSTC_MR_ERSTL_MASK;
> +
> +	/* Need to reset PHY -> 500ms reset */
> +	writel(AT91_RSTC_KEY | AT91_RSTC_MR_ERSTL(13)
> +		& ~AT91_RSTC_MR_URSTEN, &rstc->mr);
> +	writel(AT91_RSTC_KEY | AT91_RSTC_CR_EXTRST, &rstc->cr);
> +
> +	/* Wait for end of hardware reset */
> +	unsigned long start = get_timer(0);
> +	unsigned long timeout = 1000; /* 1000ms */
> +
> +	while (!(readl(&rstc->sr) & AT91_RSTC_SR_NRSTL)) {
> +
> +		/* avoid shutdown by watchdog */
> +		WATCHDOG_RESET();
> +		mdelay(10);
> +
> +		/* timeout for not getting stuck in an endless loop */
> +		if (get_timer(start) >= timeout) {
> +			puts("*** ERROR: Timeout waiting for PHY reset!\n");
> +			break;
> +		};
> +	};
> +
> +	/* Restore NRST value */
> +	writel(AT91_RSTC_KEY | erstl | AT91_RSTC_MR_URSTEN,
> +		&rstc->mr);
> +
> +	/* Re-enable pull-up */
> +	writel(pin_to_mask(AT91_PIN_PA14) |
> +		pin_to_mask(AT91_PIN_PA15) |
> +		pin_to_mask(AT91_PIN_PA17) |
> +		pin_to_mask(AT91_PIN_PA18) |
> +		pin_to_mask(AT91_PIN_PA28),
> +		&pioa->puer);
> +
> +	/* Initialize EMAC=MACB hardware */
> +	at91_macb_hw_init();
> +}
> +#endif /* CONFIG_MACB */
> +
> +int board_early_init_f(void)
> +{
> +	struct at91_pmc *pmc = (struct at91_pmc *)ATMEL_BASE_PMC;
> +
> +	/* Enable clocks for all PIOs */
> +	writel((1 << ATMEL_ID_PIOA) | (1 << ATMEL_ID_PIOB) |
> +		(1 << ATMEL_ID_PIOC), &pmc->pcer);
> +
> +	return 0;
> +}
> +
> +int board_init(void)
> +{
> +	/* adress of boot parameters */
> +	gd->bd->bi_boot_params = CONFIG_SYS_SDRAM_BASE + 0x100;
> +
> +	/* Enables the serial interface */
> +	at91_set_gpio_output(AT91_PIN_PC9, 1);
> +	at91_seriald_hw_init();
> +
> +	stamp9G20_nand_hw_init();
> +#ifdef CONFIG_MACB
> +	stamp9G20_macb_hw_init();
> +#endif
> +	return 0;
> +}
> +
> +int dram_init(void)
> +{
> +	gd->ram_size = get_ram_size(
> +		(void *)CONFIG_SYS_SDRAM_BASE,
> +		CONFIG_SYS_SDRAM_SIZE);
> +	return 0;
> +}
> +
> +#ifdef CONFIG_MACB
> +int board_eth_init(bd_t *bis)
> +{
> +	int rc = 0;
please remove this unused value

> +	return macb_eth_initialize(0, (void *)ATMEL_BASE_EMAC0, 0x00);
> +}
> +#endif /* CONFIG_MACB */
> diff --git a/boards.cfg b/boards.cfg
> index 1af87c0..8ee772b 100644
> --- a/boards.cfg
> +++ b/boards.cfg
> @@ -120,6 +120,8 @@ cpu9G20_nand_128M            arm         arm926ejs   cpu9260             eukrea
>  pm9261                       arm         arm926ejs   pm9261              ronetix        at91        pm9261:AT91SAM9261
>  pm9263                       arm         arm926ejs   pm9263              ronetix        at91        pm9263:AT91SAM9263
>  pm9g45                       arm         arm926ejs   pm9g45              ronetix        at91        pm9g45:AT91SAM9G45
> +portuxg20                    arm         arm926ejs   stamp9g20           taskit         at91        stamp9g20:AT91SAM9G20,PORTUXG20
> +stamp9g20                    arm         arm926ejs   stamp9g20           taskit         at91        stamp9g20:AT91SAM9G20
>  cam_enc_4xx                  arm         arm926ejs   cam_enc_4xx         ait            davinci     cam_enc_4xx
>  da830evm                     arm         arm926ejs   da8xxevm            davinci        davinci
>  da850_am18xxevm              arm         arm926ejs   da8xxevm            davinci        davinci     da850evm:DA850_AM18X_EVM,MAC_ADDR_IN_EEPROM,SYS_I2C_EEPROM_ADDR_LEN=2,SYS_I2C_EEPROM_ADDR=0x50
> diff --git a/include/configs/stamp9g20.h b/include/configs/stamp9g20.h
> new file mode 100644
> index 0000000..976107a
> --- /dev/null
> +++ b/include/configs/stamp9g20.h
> @@ -0,0 +1,267 @@
> +/*
> + * (C) Copyright 2007-2008
> + * Stelian Pop <stelian@popies.net>
> + * Lead Tech Design <www.leadtechdesign.com>
> + *
> + * (C) Copyright 2010
> + * Achim Ehrlich <aehrlich@taskit.de>
> + * taskit GmbH <www.taskit.de>
> + *
> + * (C) Copyright 2012
> + * Markus Hubig <mhubig@imko.de>
> + * IMKO GmbH <www.imko.de>
> + *
> + * Configuation settings for the stamp9g20 CPU module.
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +#ifndef __CONFIG_H
> +#define __CONFIG_H
> +
> +/*
> + * SoC must be defined first, before hardware.h is included.
> + * In this case SoC is defined in boards.cfg.
> + */
> +#include <asm/hardware.h>
> +
> +/*
> + * Warning: changing CONFIG_SYS_TEXT_BASE requires adapting the initial boot
> + * program.  Since the linker has to swallow that define, we must use a pure
> + * hex number here!
> + */
> +#define CONFIG_SYS_TEXT_BASE		0x23f00000
> +
> +/* ARM asynchronous clock */
> +#define CONFIG_SYS_AT91_SLOW_CLOCK	32768		/* slow clock xtal */
> +#define CONFIG_SYS_AT91_MAIN_CLOCK	18432000	/* 18.432MHz crystal */
> +#define CONFIG_SYS_HZ			1000		/* 1ms resolution */
> +
> +/* Misc CPU related settings */
> +#define CONFIG_ARCH_CPU_INIT		/* call arch_cpu_init() */
please remove this, it is not longer required cause of
a21c65115bd95572cc80092a31b0e9ecb8710e9f

> +#define CONFIG_CMDLINE_TAG		/* pass commandline to Kernel */
> +#define CONFIG_SETUP_MEMORY_TAGS	/* pass memory defs to kernel */
> +#define CONFIG_INITRD_TAG		/* pass initrd param to kernel */
> +#define CONFIG_SKIP_LOWLEVEL_INIT	/* U-Boot is loaded by a bootloader */
> +#define CONFIG_BOARD_EARLY_INIT_f	/* call board_early_init_f() */
> +#define CONFIG_DISPLAY_CPUINFO		/* display CPU Info at startup */
> +
> +/* setting board spezific options */
-----------------------^

> +#ifdef CONFIG_PORTUXG20
> +# define CONFIG_MACH_TYPE		MACH_TYPE_PORTUXG20
> +# define CONFIG_MACB

This looks really good to me. Maybe a short comment showing why you
disable MACB for the stamp by default would be useful.

> +#else
> +# define CONFIG_MACH_TYPE		MACH_TYPE_STAMP9G20
> +#endif
> +
> +/*
> + * SDRAM: 1 bank, 64 MB, base address 0x20000000
> + * Already initialized before u-boot gets started.
> + */
> +#define CONFIG_NR_DRAM_BANKS		1
> +#define CONFIG_SYS_SDRAM_BASE		ATMEL_BASE_CS1
> +#define CONFIG_SYS_SDRAM_SIZE		(64 * (1024 << 10))

just a side note: shifting by 10 bit is KiB, shifting by 20 bit is MiB
-> 64<<20 == 64*(1024<<10)

> +
> +/*
> + * Perform a SDRAM Memtest from the start of SDRAM
> + * till the beginning of the U-Boot position in RAM.
> + */
> +#define CONFIG_SYS_MEMTEST_START	CONFIG_SYS_SDRAM_BASE
> +#define CONFIG_SYS_MEMTEST_END		(CONFIG_SYS_TEXT_BASE - 0x100000)
> +
> +/* Size of malloc() pool */
> +#define CONFIG_SYS_MALLOC_LEN \
> +	ROUND(3 * CONFIG_ENV_SIZE + 128 * 1024, 0x1000)
> +
> +/*
> + * Initial stack pointer: 4k - GENERATED_GBL_DATA_SIZE in internal SRAM,
> + * leaving the correct space for initial global data structure above that
> + * address while providing maximum stack area below.
> + */
> +#define CONFIG_SYS_INIT_SP_ADDR \
> +	(ATMEL_BASE_SRAM1 + 0x1000 - GENERATED_GBL_DATA_SIZE)
> +
> +/* NAND flash settings */
> +#define CONFIG_NAND_ATMEL
> +#define CONFIG_SYS_NO_FLASH
> +#define CONFIG_SYS_MAX_NAND_DEVICE	1
> +#define CONFIG_SYS_NAND_BASE		ATMEL_BASE_CS3
> +#define CONFIG_SYS_NAND_DBW_8
> +#define CONFIG_SYS_NAND_MASK_ALE	(1 << 21)
> +#define CONFIG_SYS_NAND_MASK_CLE	(1 << 22)
> +#define CONFIG_SYS_NAND_ENABLE_PIN	AT91_PIN_PC14
> +#define CONFIG_SYS_NAND_READY_PIN	AT91_PIN_PC13
> +
> +/* general purpose I/O */
> +#define CONFIG_ATMEL_LEGACY		/* required until (g)pio is fixed */
> +#define CONFIG_AT91_GPIO		/* enable the GPIO features */
> +#define CONFIG_AT91_GPIO_PULLUP	1	/* keep pullups on peripheral pins */
> +
> +/* serial console */
> +#define CONFIG_ATMEL_USART
> +#define CONFIG_USART_BASE		ATMEL_BASE_DBGU
> +#define CONFIG_USART_ID			ATMEL_ID_SYS
> +#define CONFIG_BAUDRATE			115200
> +
> +/* LED configuration */
> +#define CONFIG_STATUS_LED
> +#define CONFIG_BOARD_SPECIFIC_LED
> +
> +/* The LED PINs */
> +#define CONFIG_RED_LED			AT91_PIN_PC5
> +#define CONFIG_GREEN_LED		AT91_PIN_PC4
> +#define CONFIG_YELLOW_LED		AT91_PIN_PC10
> +
> +#define STATUS_LED_RED			0
> +#define STATUS_LED_GREEN		1
> +#define STATUS_LED_YELLOW		2
> +
> +/* Red LED */
> +#define STATUS_LED_BIT			STATUS_LED_RED
> +#define STATUS_LED_STATE		STATUS_LED_OFF
> +#define STATUS_LED_PERIOD		(CONFIG_SYS_HZ / 2)
> +
> +/* Green LED */
> +#define STATUS_LED_BIT1			STATUS_LED_GREEN
> +#define STATUS_LED_STATE1		STATUS_LED_OFF
> +#define STATUS_LED_PERIOD1		(CONFIG_SYS_HZ / 2)
> +
> +/* Yellow LED */
> +#define STATUS_LED_BIT2			STATUS_LED_YELLOW
> +#define STATUS_LED_STATE2		STATUS_LED_OFF
> +#define STATUS_LED_PERIOD2		(CONFIG_SYS_HZ / 2)
> +
> +/* Boot status LED */
> +#define STATUS_LED_BOOT			STATUS_LED_GREEN
> +
> +/*
> + * Ethernet configuration
> + *
> + * PortuxG20 has always ethernet but for Stamp9G20 you
> + * can enable it here if your baseboard features ethernet.
> + */
> +
> +/* #define CONFIG_MACB */
> +
> +#ifdef CONFIG_MACB
> +# define CONFIG_RMII			/* use reduced MII inteface */
> +# define CONFIG_NET_RETRY_COUNT	20      /* # of DHCP/BOOTP retries */
> +
> +/* BOOTP and DHCP options */
> +# define CONFIG_BOOTP_BOOTFILESIZE
> +# define CONFIG_BOOTP_BOOTPATH
> +# define CONFIG_BOOTP_GATEWAY
> +# define CONFIG_BOOTP_HOSTNAME
> +# define CONFIG_NFSBOOTCOMMAND						\
> +	"setenv autoload yes; setenv autoboot yes; "			\
> +	"setenv bootargs ${basicargs} ${mtdparts} "			\
> +	"root=/dev/nfs ip=dhcp nfsroot=${serverip}:/srv/nfs/rootfs; "	\
> +	"dhcp"
> +#endif /* CONFIG_MACB */
> +
> +/* Enable the watchdog */
> +#define CONFIG_AT91SAM9_WATCHDOG
> +#define CONFIG_HW_WATCHDOG
> +
> +/* USB configuration */
> +#define CONFIG_USB_ATMEL
> +#define CONFIG_USB_OHCI_NEW
> +#define CONFIG_USB_STORAGE
> +#define CONFIG_DOS_PARTITION
> +#define CONFIG_SYS_USB_OHCI_CPU_INIT
> +#define CONFIG_SYS_USB_OHCI_REGS_BASE	ATMEL_UHP_BASE
> +#define CONFIG_SYS_USB_OHCI_SLOT_NAME	"at91sam9260"
> +#define CONFIG_SYS_USB_OHCI_MAX_ROOT_PORTS	2
> +
> +/* General Boot Parameter */
> +#define CONFIG_BOOTDELAY		3
> +#define CONFIG_BOOTCOMMAND		"run flashboot"
> +#define CONFIG_SYS_PROMPT		"U-Boot> "
> +#define CONFIG_SYS_CBSIZE		256
> +#define CONFIG_SYS_MAXARGS		16
> +#define CONFIG_SYS_PBSIZE \
> +	(CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16)
> +#define CONFIG_SYS_LONGHELP
> +#define CONFIG_CMDLINE_EDITING
> +
> +/*
> + * RAM Memory address where to put the
> + * Linux Kernel befor starting.
> + */
> +#define CONFIG_SYS_LOAD_ADDR		0x22000000
> +
> +/*
> + * The NAND Flash partitions:
> + * ==========================================
> + * 0x0000000-0x001ffff -> 128k, bootstrap
> + * 0x0020000-0x005ffff -> 256k, u-boot
> + * 0x0060000-0x007ffff -> 128k, env1
> + * 0x0080000-0x009ffff -> 128k, env2 (backup)
> + * 0x0100000-0x06fffff ->   6M, kernel
> + * 0x0700000-0x8000000 -> 121M, RootFS
> + */
> +#define CONFIG_ENV_IS_IN_NAND
> +#define CONFIG_ENV_OFFSET		(128 + 256 << 10)
> +#define CONFIG_ENV_OFFSET_REDUND	(128 + 256 + 128 << 10)
> +#define CONFIG_ENV_SIZE			(128 << 10)
> +
> +/*
> + * Predefined environment variables.
> + * Usefull to define some easy to use boot commands.
> + */
> +#define	CONFIG_EXTRA_ENV_SETTINGS					\
> +									\
> +	"basicargs=console=ttyS0,115200\0"				\
> +									\
> +	"mtdparts=mtdparts=atmel_nand:128k(bootstrap)ro,"		\
> +		"256k(uboot)ro,128k(env1)ro,"				\
> +		"128k(env2)ro,6M(linux),-(root)rw\0"			\
> +									\
> +	"flashboot=setenv bootargs ${basicargs} ${mtdparts} "		\
> +		"root=/dev/mtdblock5 rootfstype=jffs2; "		\
> +		"nand read 0x22000000 0x100000 0x600000; "		\
> +		"bootm 22000000\0"					\
> +									\
> +	"sdboot=setenv bootargs ${basicargs} ${mtdparts} "		\
> +		"root=/dev/mmcblk0p1 rootwait; "			\
> +		"nand read 0x22000000 0x100000 0x600000; "		\
> +		"bootm 22000000"
> +
> +/* Command line & features configuration */
> +#include <config_cmd_default.h>
> +#undef CONFIG_CMD_FPGA
> +#undef CONFIG_CMD_IMI
> +#undef CONFIG_CMD_IMLS
> +#undef CONFIG_CMD_LOADS
> +
> +#define CONFIG_CMD_NAND
> +#define CONFIG_CMD_USB
> +#define CONFIG_CMD_FAT
> +#define CONFIG_CMD_LED
> +
> +#ifdef CONFIG_MACB
> +# define CONFIG_CMD_PING
> +# define CONFIG_CMD_DHCP
> +#else
> +# undef CONFIG_CMD_BOOTD
> +# undef CONFIG_CMD_NET
> +# undef CONFIG_CMD_NFS
> +#endif /* CONFIG_MACB */
> +
> +#endif /* __CONFIG_H */
> 

I think some minor tweaks for the led stuff and then we can apply this
patch.

best regards

Andreas Bießmman

Dear Markus Hubig,

One more thing to mention!

On 06.08.2012 15:01, Andreas Bießmann wrote:
> Dear Markus Hubig,

<snip>

>> diff --git a/board/taskit/stamp9g20/stamp9g20.c b/board/taskit/stamp9g20/stamp9g20.c
>> new file mode 100644
>> index 0000000..c85e6c3
>> --- /dev/null
>> +++ b/board/taskit/stamp9g20/stamp9g20.c
>> @@ -0,0 +1,192 @@
>> +/*
>> + * (C) Copyright 2007-2008
>> + * Stelian Pop <stelian@popies.net>
>> + * Lead Tech Design <www.leadtechdesign.com>
>> + *
>> + * Achim Ehrlich <aehrlich@taskit.de>
>> + * taskit GmbH <www.taskit.de>
>> + *
>> + * (C) Copyright 2012-
>> + * Markus Hubig <mhubig@imko.de>
>> + * IMKO GmbH <www.imko.de>
>> + *
>> + * See file CREDITS for list of people who contributed to this
>> + * project.
>> + *
>> + * This program is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU General Public License as
>> + * published by the Free Software Foundation; either version 2 of
>> + * the License, or (at your option) any later version.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> + * GNU General Public License for more details.
>> + *
>> + * You should have received a copy of the GNU General Public License
>> + * along with this program; if not, write to the Free Software
>> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
>> + * MA 02111-1307 USA
>> + */
>> +
>> +#include <common.h>
>> +#include <asm/io.h>
>> +#include <asm/arch/at91sam9260_matrix.h>
>> +#include <asm/arch/at91sam9_smc.h>
>> +#include <asm/arch/at91_common.h>
>> +#include <asm/arch/at91_pmc.h>
>> +#include <asm/arch/at91_rstc.h>
>> +#include <asm/arch/gpio.h>
>> +#include <watchdog.h>
>> +
>> +#ifdef CONFIG_MACB
>> +# include <net.h>
>> +# include <netdev.h>
>> +#endif
>> +
>> +DECLARE_GLOBAL_DATA_PTR;
>> +
>> +static void stamp9G20_nand_hw_init(void)
>> +{
>> +	struct at91_smc *smc = (struct at91_smc *)ATMEL_BASE_SMC;
>> +	struct at91_matrix *matrix = (struct at91_matrix *)ATMEL_BASE_MATRIX;
>> +	unsigned long csa;
>> +
>> +	/* Assign CS3 to NAND/SmartMedia Interface */
>> +	csa = readl(&matrix->ebicsa);
>> +	csa |= AT91_MATRIX_CS3A_SMC_SMARTMEDIA;
>> +	writel(csa, &matrix->ebicsa);
>> +
>> +	/* Configure SMC CS3 for NAND/SmartMedia */
>> +	writel(AT91_SMC_SETUP_NWE(1) | AT91_SMC_SETUP_NCS_WR(0) |
>> +		AT91_SMC_SETUP_NRD(1) | AT91_SMC_SETUP_NCS_RD(0),
>> +		&smc->cs[3].setup);
>> +	writel(AT91_SMC_PULSE_NWE(3) | AT91_SMC_PULSE_NCS_WR(3) |
>> +		AT91_SMC_PULSE_NRD(3) | AT91_SMC_PULSE_NCS_RD(3),
>> +		&smc->cs[3].pulse);
>> +	writel(AT91_SMC_CYCLE_NWE(5) | AT91_SMC_CYCLE_NRD(5),
>> +		&smc->cs[3].cycle);
>> +	writel(AT91_SMC_MODE_RM_NRD | AT91_SMC_MODE_WM_NWE |
>> +		AT91_SMC_MODE_EXNW_DISABLE |
>> +		AT91_SMC_MODE_DBW_8 |
>> +		AT91_SMC_MODE_TDF_CYCLE(2),
>> +		&smc->cs[3].mode);
>> +
>> +	/* Configure RDY/BSY */
>> +	at91_set_gpio_input(CONFIG_SYS_NAND_READY_PIN, 1);
>> +
>> +	/* Enable NandFlash */
>> +	at91_set_gpio_output(CONFIG_SYS_NAND_ENABLE_PIN, 1);
>> +}
>> +
>> +#ifdef CONFIG_MACB
>> +static void stamp9G20_macb_hw_init(void)
>> +{
>> +	struct at91_port *pioa = (struct at91_port *)ATMEL_BASE_PIOA;
>> +	struct at91_rstc *rstc = (struct at91_rstc *)ATMEL_BASE_RSTC;
>> +	unsigned long erstl;
>> +
>> +	/* Enable the PHY Chip via PA26 on the Stamp 2 Adaptor */
>> +	at91_set_gpio_output(AT91_PIN_PA26, 0);
>> +
>> +	/*
>> +	 * Disable pull-up on:
>> +	 *	RXDV (PA17) => PHY normal mode (not Test mode)
>> +	 *	ERX0 (PA14) => PHY ADDR0
>> +	 *	ERX1 (PA15) => PHY ADDR1
>> +	 *	ERX2 (PA25) => PHY ADDR2
>> +	 *	ERX3 (PA26) => PHY ADDR3
>> +	 *	ECRS (PA28) => PHY ADDR4  => PHYADDR = 0x0
>> +	 *
>> +	 * PHY has internal pull-down
>> +	 */
>> +	writel(pin_to_mask(AT91_PIN_PA14) |
>> +		pin_to_mask(AT91_PIN_PA15) |
>> +		pin_to_mask(AT91_PIN_PA17) |
>> +		pin_to_mask(AT91_PIN_PA18) |
>> +		pin_to_mask(AT91_PIN_PA28),
>> +		&pioa->pudr);
>> +
>> +	erstl = readl(&rstc->mr) & AT91_RSTC_MR_ERSTL_MASK;
>> +
>> +	/* Need to reset PHY -> 500ms reset */
>> +	writel(AT91_RSTC_KEY | AT91_RSTC_MR_ERSTL(13)
>> +		& ~AT91_RSTC_MR_URSTEN, &rstc->mr);

stamp9g20.c: In function 'stamp9G20_macb_hw_init':
stamp9g20.c:113:2: warning: suggest parentheses around arithmetic in
operand of '|' [-Wparentheses]

<snip>

Best regards

Andreas Bießmann

Dear Markus Hubig,

On 06.08.2012 15:46, Andreas Bießmann wrote:
> Dear Markus Hubig,
> 
> One more thing to mention!

and some more ;)

---8<---
Configuring for portuxg20 - Board: stamp9g20, Options: AT91SAM9G20,PORTUXG20
   text	   data	    bss	    dec	    hex	filename
 199941	   6040	 269068	 475049	  73fa9	/tmp/build_at91/u-boot
env_nand.c: In function 'saveenv':
env_nand.c:199:3: warning: suggest parentheses around '+' inside '<<'
[-Wparentheses]
env_nand.c:204:3: warning: suggest parentheses around '+' inside '<<'
[-Wparentheses]
env_nand.c:207:3: warning: suggest parentheses around '+' inside '<<'
[-Wparentheses]
env_nand.c:212:3: warning: suggest parentheses around '+' inside '<<'
[-Wparentheses]
env_nand.c: In function 'env_relocate_spec':
env_nand.c:345:2: warning: suggest parentheses around '+' inside '<<'
[-Wparentheses]
env_nand.c:348:2: warning: suggest parentheses around '+' inside '<<'
[-Wparentheses]
stamp9g20.c: In function 'stamp9G20_macb_hw_init':
stamp9g20.c:113:2: warning: suggest parentheses around arithmetic in
operand of '|' [-Wparentheses]
stamp9g20.c: In function 'board_eth_init':
stamp9g20.c:189:6: warning: unused variable 'rc' [-Wunused-variable]
Configuring for stamp9g20 - Board: stamp9g20, Options: AT91SAM9G20
   text	   data	    bss	    dec	    hex	filename
 174022	   5828	 256808	 436658	  6a9b2	/tmp/build_at91/u-boot
env_nand.c: In function 'saveenv':
env_nand.c:199:3: warning: suggest parentheses around '+' inside '<<'
[-Wparentheses]
env_nand.c:204:3: warning: suggest parentheses around '+' inside '<<'
[-Wparentheses]
env_nand.c:207:3: warning: suggest parentheses around '+' inside '<<'
[-Wparentheses]
env_nand.c:212:3: warning: suggest parentheses around '+' inside '<<'
[-Wparentheses]
env_nand.c: In function 'env_relocate_spec':
env_nand.c:345:2: warning: suggest parentheses around '+' inside '<<'
[-Wparentheses]
env_nand.c:348:2: warning: suggest parentheses around '+' inside '<<'
[-Wparentheses]
--->8---

Please test your code with the MAKEALL script before sending.

Best regards

Andreas Bießmann

On Mon, Aug 06, 2012 at 03:01:40PM +0200, Andreas Bießmann wrote:
> On 06.08.2012 11:11, Markus Hubig wrote:
> > This adds support for the AT91SAM9G20 boards by taskit GmbH.
> > Both boards, Stamp9G20 and PortuxG20, are integrated in one
> > file. PortuxG20 is basically a SBC built around the Stamp9G20.
> > 
> > Signed-off-by: Markus Hubig <mhubig@imko.de>
> > Cc: Andreas Bießmann <andreas.devel@googlemail.com>
> > ---
> 
> please read http://www.denx.de/wiki/U-Boot/Patches, especially
> http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions
> 
> (patch changes missing)

OK will include them onto my next patch!

> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 84413de..7eb55db 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -243,12 +243,6 @@ Klaus Heydeck <heydeck@kieback-peter.de>
> >  	KUP4K		MPC855
> >  	KUP4X		MPC859
> >  
> > -Ilko Iliev <iliev@ronetix.at>
> > -
> > -	PM9261		AT91SAM9261
> > -	PM9263		AT91SAM9263
> > -	PM9G45		ARM926EJS (AT91SAM9G45 SoC)
> > -
> 
> NAK, this is a separate patch (already on the list)

Ups ... Fixed!

> > +static unsigned int saved_state[3] = {STATUS_LED_OFF,
> > +	STATUS_LED_OFF, STATUS_LED_OFF};
> > +
> > +void coloured_LED_init(void)
> > +{
> > +	/* Clock is enabled in board_early_init_f() */
> 
> But coloured_LED_init() is called way before!
> 
> Beware, this coloured LED stuff is sometimes used for very early debug
> purposes. To get this working you will need to switch the clocks here.
> 
> If you not insist on this colour LED framework I would appreciate to not
> add this coloured_LED_init for the stamp9g20 but use the status LED
> framework -> README.LED

OK I'll try to get rid of the coloured_LED stuff but the README.LED should
better be called a CONFUSEME.LED ... Maybe later I can include a better
example ...

> > +#ifdef CONFIG_MACB
> > +int board_eth_init(bd_t *bis)
> > +{
> > +	int rc = 0;
> please remove this unused value

Fixed!

> > +/* Misc CPU related settings */
> > +#define CONFIG_ARCH_CPU_INIT		/* call arch_cpu_init() */
> please remove this, it is not longer required cause of
> a21c65115bd95572cc80092a31b0e9ecb8710e9f

Fixed!

> > +/* setting board spezific options */
> -----------------------^

Fixed!

> > +#ifdef CONFIG_PORTUXG20
> > +# define CONFIG_MACH_TYPE		MACH_TYPE_PORTUXG20
> > +# define CONFIG_MACB
> 
> This looks really good to me. Maybe a short comment showing why you
> disable MACB for the stamp by default would be useful.

There is already a comment, but a bit later at the ethernet "section".
I think this is the best place, someone who is missing ethernet support
will have a look ...

> > +/*
> > + * SDRAM: 1 bank, 64 MB, base address 0x20000000
> > + * Already initialized before u-boot gets started.
> > + */
> > +#define CONFIG_NR_DRAM_BANKS		1
> > +#define CONFIG_SYS_SDRAM_BASE		ATMEL_BASE_CS1
> > +#define CONFIG_SYS_SDRAM_SIZE		(64 * (1024 << 10))
> 
> just a side note: shifting by 10 bit is KiB, shifting by 20 bit is MiB
> -> 64<<20 == 64*(1024<<10)

Hmm OK. Now I unified all calculations to use the shifting OP '<<'.

> 
> I think some minor tweaks for the led stuff and then we can apply this
> patch.

Fine! ;-)

Cheers, Markus

On Mon, Aug 06, 2012 at 03:46:49PM +0200, Andreas Bießmann wrote:
> Dear Markus Hubig,
> 
> One more thing to mention!

<snipp>

> stamp9g20.c: In function 'stamp9G20_macb_hw_init':
> stamp9g20.c:113:2: warning: suggest parentheses around arithmetic in
> operand of '|' [-Wparentheses]

Fixed!

Cheers, Markus

On Mon, Aug 06, 2012 at 03:49:22PM +0200, Andreas Bießmann wrote:
> On 06.08.2012 15:46, Andreas Bießmann wrote:
> > 
> > One more thing to mention!
> 
> and some more ;)

<snipp>

> Please test your code with the MAKEALL script before sending.

| $ ./MAKEALL portuxg20 stamp9g20
| Configuring for portuxg20 - Board: stamp9g20, Options: AT91SAM9G20,PORTUXG20
|    text	   data	    bss	    dec	    hex	filename
|  200037	   6040	 268996	 475073	  73fc1	./u-boot
| Configuring for stamp9g20 - Board: stamp9g20, Options: AT91SAM9G20
|    text	   data	    bss	    dec	    hex	filename
|  173966	   5828	 256864	 436658	  6a9b2	./u-boot
| 
| --------------------- SUMMARY ----------------------------
| Boards compiled: 2
| ----------------------------------------------------------

Fixed! ;-)

Cheers, Markus

On Mon, Aug 06, 2012 at 03:01:40PM +0200, Andreas Bießmann wrote:
> On 06.08.2012 11:11, Markus Hubig wrote:
> >
> > +static unsigned int saved_state[3] = {STATUS_LED_OFF,
> > +	STATUS_LED_OFF, STATUS_LED_OFF};
> > +
> > +void coloured_LED_init(void)
> > +{
> > +	/* Clock is enabled in board_early_init_f() */
> 
> But coloured_LED_init() is called way before!
> 
> Beware, this coloured LED stuff is sometimes used for very early debug
> purposes. To get this working you will need to switch the clocks here.
> 
> If you not insist on this colour LED framework I would appreciate to not
> add this coloured_LED_init for the stamp9g20 but use the status LED
> framework -> README.LED

Are you shure about this? Is I just remove this and put the 

> > +	at91_set_gpio_output(CONFIG_RED_LED, 1);
> > +	at91_set_gpio_output(CONFIG_GREEN_LED, 1);
> > +	at91_set_gpio_output(CONFIG_YELLOW_LED, 1);

in __led_init() I have no LED's at all and the commandlie tool 'led'
stopps working... At all the Status LED stuff is a bit confusing ...

- It's not clear to me if the STATUS_LED_BIT should be e.g. 1 or
  e.g. AT91_PIN_PC5.

- It's not clear what the benefit of using this is.

- It's not clear if the coloured_LED stuff is part of it or something
  extra.

Maybe it's better is I just switch on the green LED in board_init?

For now I just switched the clock on in coloured_LED_init. At least I
have some LED now.

Cheers, Markus

Dear Markus Hubig,

On 06.08.2012 18:49, Markus Hubig wrote:
> On Mon, Aug 06, 2012 at 03:01:40PM +0200, Andreas Bießmann wrote:
>> On 06.08.2012 11:11, Markus Hubig wrote:
>>>
>>> +static unsigned int saved_state[3] = {STATUS_LED_OFF,
>>> +	STATUS_LED_OFF, STATUS_LED_OFF};
>>> +
>>> +void coloured_LED_init(void)
>>> +{
>>> +	/* Clock is enabled in board_early_init_f() */
>>
>> But coloured_LED_init() is called way before!
>>
>> Beware, this coloured LED stuff is sometimes used for very early debug
>> purposes. To get this working you will need to switch the clocks here.
>>
>> If you not insist on this colour LED framework I would appreciate to not
>> add this coloured_LED_init for the stamp9g20 but use the status LED
>> framework -> README.LED
> 
> Are you shure about this?

No, I've not worked with that status LED thing. Contrastingly I thought
that LED stuff is at91 specific. But there are some other ARM SoC using
this colored LED and status LED thing. So this appears to be a wrong
decision.

> Is I just remove this and put the 
> 
>>> +	at91_set_gpio_output(CONFIG_RED_LED, 1);
>>> +	at91_set_gpio_output(CONFIG_GREEN_LED, 1);
>>> +	at91_set_gpio_output(CONFIG_YELLOW_LED, 1);
> 
> in __led_init() I have no LED's at all and the commandlie tool 'led'
> stopps working... At all the Status LED stuff is a bit confusing ...
> 
> - It's not clear to me if the STATUS_LED_BIT should be e.g. 1 or
>   e.g. AT91_PIN_PC5.
> 
> - It's not clear what the benefit of using this is.
> 
> - It's not clear if the coloured_LED stuff is part of it or something
>   extra.

Sorry, I can not help you here.

> Maybe it's better is I just switch on the green LED in board_init?

but you will loose the led cmd which may be useful.

> For now I just switched the clock on in coloured_LED_init. At least I
> have some LED now.

Thats ok with me.

Best regards

Andreas Bießmann