| Message ID | 1343963182-28297-2-git-send-email-akong@redhat.com |
|---|---|
| State | New |
| Headers | show |
On Fri, 3 Aug 2012 11:06:21 +0800 Amos Kong <akong@redhat.com> wrote: > Signed-off-by: Amos Kong <akong@redhat.com> > --- > qemu_socket.h | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/qemu_socket.h b/qemu_socket.h > index 4689ff3..1a2f517 100644 > --- a/qemu_socket.h > +++ b/qemu_socket.h > @@ -27,7 +27,6 @@ int inet_aton(const char *cp, struct in_addr *ia); > #endif /* !_WIN32 */ > > #include "qemu-option.h" > -#include "error.h" > #include "qerror.h" This is wrong. There are functions in this header that takes an Error argument (which is declared in error.h). qerror.h should be dropped though, as it's deprecated and as such shouldn't be in a public header like this. If you get build failures, then you can include it in the .c files where it's missing. > > /* misc helpers */
On Fri, Aug 3, 2012 at 4:06 AM, Amos Kong <akong@redhat.com> wrote: > Signed-off-by: Amos Kong <akong@redhat.com> > --- > qemu_socket.h | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) I have dropped this, see Luiz' comment. Stefan
diff --git a/qemu_socket.h b/qemu_socket.h index 4689ff3..1a2f517 100644 --- a/qemu_socket.h +++ b/qemu_socket.h @@ -27,7 +27,6 @@ int inet_aton(const char *cp, struct in_addr *ia); #endif /* !_WIN32 */ #include "qemu-option.h" -#include "error.h" #include "qerror.h" /* misc helpers */
Signed-off-by: Amos Kong <akong@redhat.com> --- qemu_socket.h | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)