| Message ID | 49e29dcae7ac91b99d0bbee92c0ab828057d797a.1343845033.git.blauwirbel@gmail.com |
|---|---|
| State | New |
| Headers | show |
[cc: SCSI maintainer] Blue Swirl <blauwirbel@gmail.com> writes: > LOAD_UNLOAD and START_STOP have same value, so the table > entry is initialized twice. Spotted by Clang compiler. > > Remove LOAD_UNLOAD entry since START_STOP entry already > represents both. > > Signed-off-by: Blue Swirl <blauwirbel@gmail.com> > --- > hw/scsi-bus.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c > index e4ec19e..a8759bc 100644 > --- a/hw/scsi-bus.c > +++ b/hw/scsi-bus.c > @@ -1355,7 +1355,6 @@ static const char *scsi_command_name(uint8_t cmd) > [ BLANK ] = "BLANK", > [ MOVE_MEDIUM ] = "MOVE_MEDIUM", > [ EXCHANGE_MEDIUM ] = "EXCHANGE MEDIUM", > - [ LOAD_UNLOAD ] = "LOAD_UNLOAD", > [ READ_12 ] = "READ_12", > [ WRITE_12 ] = "WRITE_12", > [ ERASE_12 ] = "ERASE_12/GET_PERFORMANCE", Missed in commit 15e58a21. Reviewed-by: Markus Armbruster <armbru@redhat.com>
diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c index e4ec19e..a8759bc 100644 --- a/hw/scsi-bus.c +++ b/hw/scsi-bus.c @@ -1355,7 +1355,6 @@ static const char *scsi_command_name(uint8_t cmd) [ BLANK ] = "BLANK", [ MOVE_MEDIUM ] = "MOVE_MEDIUM", [ EXCHANGE_MEDIUM ] = "EXCHANGE MEDIUM", - [ LOAD_UNLOAD ] = "LOAD_UNLOAD", [ READ_12 ] = "READ_12", [ WRITE_12 ] = "WRITE_12", [ ERASE_12 ] = "ERASE_12/GET_PERFORMANCE",
LOAD_UNLOAD and START_STOP have same value, so the table entry is initialized twice. Spotted by Clang compiler. Remove LOAD_UNLOAD entry since START_STOP entry already represents both. Signed-off-by: Blue Swirl <blauwirbel@gmail.com> --- hw/scsi-bus.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)