| Message ID | 20120718172227.GC18479@otherpad.lan.raisama.net |
|---|---|
| State | New |
| Headers | show |
----- Messaggio originale ----- > Da: "Eduardo Habkost" <ehabkost@redhat.com> > A: qemu-devel@nongnu.org > Cc: "Paolo Bonzini" <pbonzini@redhat.com>, "Anthony Liguori" <anthony@codemonkey.ws> > Inviato: Mercoledì, 18 luglio 2012 19:22:27 > Oggetto: [PATCH resend] tests: Makefile: include dependency files > > Otherwise 'make check' won't recompile files that need to be > recompiled > because of header changes. > > To reproduce the bug, run: > > $ make check # succeeds > $ echo B0RKED > hw/mc146818rtc_regs.h > $ make check # is supposed to try to rebuild tests/rtc-test.o and > fail > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> > --- > tests/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/Makefile b/tests/Makefile > index d66ab19..b3f7494 100644 > --- a/tests/Makefile > +++ b/tests/Makefile > @@ -143,3 +143,5 @@ check-qtest: $(patsubst %,check-qtest-%, > $(QTEST_TARGETS)) > check-unit: $(patsubst %,check-%, $(check-unit-y)) > check-block: $(patsubst %,check-%, $(check-block-y)) > check: check-unit check-qtest > + > +-include $(wildcard tests/*.d) > -- > 1.7.10.4 Acked-by: Paolo Bonzini <pbonzini@redhat.com>
On Wed, Jul 18, 2012 at 5:22 PM, Eduardo Habkost <ehabkost@redhat.com> wrote: > Otherwise 'make check' won't recompile files that need to be recompiled > because of header changes. > > To reproduce the bug, run: > > $ make check # succeeds > $ echo B0RKED > hw/mc146818rtc_regs.h > $ make check # is supposed to try to rebuild tests/rtc-test.o and fail > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> Thanks, applied. > --- > tests/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/Makefile b/tests/Makefile > index d66ab19..b3f7494 100644 > --- a/tests/Makefile > +++ b/tests/Makefile > @@ -143,3 +143,5 @@ check-qtest: $(patsubst %,check-qtest-%, $(QTEST_TARGETS)) > check-unit: $(patsubst %,check-%, $(check-unit-y)) > check-block: $(patsubst %,check-%, $(check-block-y)) > check: check-unit check-qtest > + > +-include $(wildcard tests/*.d) > -- > 1.7.10.4 > >
diff --git a/tests/Makefile b/tests/Makefile index d66ab19..b3f7494 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -143,3 +143,5 @@ check-qtest: $(patsubst %,check-qtest-%, $(QTEST_TARGETS)) check-unit: $(patsubst %,check-%, $(check-unit-y)) check-block: $(patsubst %,check-%, $(check-block-y)) check: check-unit check-qtest + +-include $(wildcard tests/*.d)
Otherwise 'make check' won't recompile files that need to be recompiled because of header changes. To reproduce the bug, run: $ make check # succeeds $ echo B0RKED > hw/mc146818rtc_regs.h $ make check # is supposed to try to rebuild tests/rtc-test.o and fail Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> --- tests/Makefile | 2 ++ 1 file changed, 2 insertions(+)