diff mbox

[v2,3/3] ARM: imx_v6_v7_defconfig: Select MXS_DMA

Message ID 20120726022930.GB3396@shlinux2.ap.freescale.net
State Not Applicable
Headers show

Commit Message

Dong Aisheng July 26, 2012, 2:29 a.m. UTC 
On Thu, Jul 26, 2012 at 10:24:41AM +0800, Huang Shijie wrote:
> On Wed, Jul 25, 2012 at 11:23 PM, Fabio Estevam <festevam@gmail.com> wrote:
> > On Wed, Jul 25, 2012 at 12:05 PM, Huang Shijie <shijie8@gmail.com> wrote:
> >
> >> Is this patch needed? The mxs-dma only has one user, the gpmi-nand in mx6q.
> >> this patch makes the kernel built-in the mxs-dma, even the gpmi-nand
> >> is not enabled.
> >
> > Well, as the driver currently stands: yes, it is needed.
> >
> > Without CONFIG_MXS_DMA, the GPMI driver cannot even be built.
> But you have added "depend on MXS_DMA". So If you do not select the
> mxs-dma, you can not see the
> gpmi-nand.
> that's why i think this patch is not needed.
> 
How about using 'select MXS_DMA'?
still compiled even GPMI_NAND is not selected.

Regards
Dong Aisheng

Comments

Fabio Estevam July 26, 2012, 10:38 a.m. UTC | #1 
On Wed, Jul 25, 2012 at 11:29 PM, Dong Aisheng <b29396@freescale.com> wrote:

> How about using 'select MXS_DMA'?

Ok, I prefer this way too. Will resubmit it soon. Hopefully it is OK with Shawn.
Shawn Guo July 28, 2012, 1:02 p.m. UTC | #2 
On Thu, Jul 26, 2012 at 07:38:57AM -0300, Fabio Estevam wrote:
> On Wed, Jul 25, 2012 at 11:29 PM, Dong Aisheng <b29396@freescale.com> wrote:
> 
> > How about using 'select MXS_DMA'?
> 
> Ok, I prefer this way too. Will resubmit it soon. Hopefully it is OK with Shawn.

No.  For your information, the following is what
Documentation/kbuild/kconfig-language.txt tell.

  Note:
        select should be used with care. select will force
        a symbol to a value without visiting the dependencies.
        By abusing select you are able to select a symbol FOO even
        if FOO depends on BAR that is not set.
        In general use select only for non-visible symbols
        (no prompts anywhere) and for symbols with no dependencies.
        That will limit the usefulness but on the other hand avoid
        the illegal configurations all over.
diff mbox

Patch

diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
index 31bb7e5..e7c3dcf 100644
--- a/drivers/mtd/nand/Kconfig
+++ b/drivers/mtd/nand/Kconfig
@@ -481,6 +481,7 @@  config MTD_NAND_NANDSIM
 config MTD_NAND_GPMI_NAND
         bool "GPMI NAND Flash Controller driver"
         depends on MTD_NAND && (SOC_IMX23 || SOC_IMX28 || SOC_IMX6Q)
+       select MXS_DMA
         help

Then we do not need this patch and does not have the issue that MXS_DMA is