| Message ID | 1343203902-10524-4-git-send-email-benoit@irqsave.net |
|---|---|
| State | New |
| Headers | show |
Am 25.07.2012 10:11, schrieb benoit.canet@gmail.com: > From: Benoît Canet <benoit@irqsave.net> > > Signed-off-by: Benoit Canet <benoit@irqsave.net> > --- > hmp.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hmp.c b/hmp.c > index 6b72a64..19dcb65 100644 > --- a/hmp.c > +++ b/hmp.c > @@ -227,6 +227,8 @@ void hmp_info_block(Monitor *mon) > if (info->value->inserted->has_backing_file) { > monitor_printf(mon, " backing_file="); > monitor_print_filename(mon, info->value->inserted->backing_file); > + monitor_printf(mon, " backing_file_ancestors_count=%" PRId64, > + info->value->inserted->backing_file_ancestors_count); This is not what a user interface looks like. Maybe something like "%d backing files", and omit the message if there aren't any backing files. Kevin
Am 25.07.2012 13:17, schrieb Benoît Canet: > Le Wednesday 25 Jul 2012 à 12:59:00 (+0200), Kevin Wolf a écrit : >> Am 25.07.2012 10:11, schrieb benoit.canet@gmail.com: >>> From: Benoît Canet <benoit@irqsave.net> >>> >>> Signed-off-by: Benoit Canet <benoit@irqsave.net> >>> --- >>> hmp.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/hmp.c b/hmp.c >>> index 6b72a64..19dcb65 100644 >>> --- a/hmp.c >>> +++ b/hmp.c >>> @@ -227,6 +227,8 @@ void hmp_info_block(Monitor *mon) >>> if (info->value->inserted->has_backing_file) { >>> monitor_printf(mon, " backing_file="); >>> monitor_print_filename(mon, info->value->inserted->backing_file); >>> + monitor_printf(mon, " backing_file_ancestors_count=%" PRId64, >>> + info->value->inserted->backing_file_ancestors_count); >> >> This is not what a user interface looks like. Maybe something like "%d >> backing files", and omit the message if there aren't any backing files. > > The whole line of info block look like this: > virtio0: removable=0 io-status=ok file=/home/benoit/images/gruik.qed backing_file=/home/benoit/images/snap.qed backing_file_ancestors_count=1 ro=0 drv=qed encrypted=0 bps=0 bps_rd=0 bps_wr=0 iops=0 iops_rd=0 iops_wr=0 > Again I tried to make something coherent. I see. I wasn't really aware that it's already that bad today. The whole output of this command should be changed, but it's not in the scope of your series. > It's already ommited when there is no backing file (the field is optional). Yeah, sorry, I missed the context. Kevin
diff --git a/hmp.c b/hmp.c index 6b72a64..19dcb65 100644 --- a/hmp.c +++ b/hmp.c @@ -227,6 +227,8 @@ void hmp_info_block(Monitor *mon) if (info->value->inserted->has_backing_file) { monitor_printf(mon, " backing_file="); monitor_print_filename(mon, info->value->inserted->backing_file); + monitor_printf(mon, " backing_file_ancestors_count=%" PRId64, + info->value->inserted->backing_file_ancestors_count); } monitor_printf(mon, " ro=%d drv=%s encrypted=%d", info->value->inserted->ro,