| Message ID | 1342882947-9174-8-git-send-email-marex@denx.de |
|---|---|
| State | Accepted |
| Delegated to: | Marek Vasut |
| Headers | show |
On Sat, Jul 21, 2012 at 4:02 PM, Marek Vasut <marex@denx.de> wrote: > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Simon Glass <sjg@chromium.org> > Cc: Tom Warren <twarren@nvidia.com> > Cc: Wolfgang Denk <wd@denx.de> > Cc: Albert Aribaud <albert.u.boot@aribaud.net> > Cc: U-Boot DM <u-boot-dm@lists.denx.de> Acked-by: Simon Glass <sjg@chromium.org> > --- > arch/arm/cpu/armv7/tegra2/usb.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/cpu/armv7/tegra2/usb.c b/arch/arm/cpu/armv7/tegra2/usb.c > index 5f2b243..ea7f701 100644 > --- a/arch/arm/cpu/armv7/tegra2/usb.c > +++ b/arch/arm/cpu/armv7/tegra2/usb.c > @@ -158,7 +158,8 @@ static void set_host_mode(struct fdt_usb *config) > } > } > > -void usbf_reset_controller(struct fdt_usb *config, struct usb_ctlr *usbctlr) > +static void usbf_reset_controller(struct fdt_usb *config, > + struct usb_ctlr *usbctlr) > { > /* Reset the USB controller with 2us delay */ > reset_periph(config->periph_id, 2); > @@ -382,8 +383,8 @@ int tegrausb_stop_port(void) > return 0; > } > > -int fdt_decode_usb(const void *blob, int node, unsigned osc_frequency_mhz, > - struct fdt_usb *config) > +static int fdt_decode_usb(const void *blob, int node, > + unsigned osc_frequency_mhz, struct fdt_usb *config) > { > const char *phy, *mode; > > -- > 1.7.10.4 >
On Sat, Jul 21, 2012 at 4:02 PM, Marek Vasut <marex@denx.de> wrote: > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Simon Glass <sjg@chromium.org> > Cc: Tom Warren <twarren@nvidia.com> > Cc: Wolfgang Denk <wd@denx.de> > Cc: Albert Aribaud <albert.u.boot@aribaud.net> > Cc: U-Boot DM <u-boot-dm@lists.denx.de> Ooops. Acked-by: Simon Glass <sjg@chromium.org> > --- > arch/arm/cpu/armv7/tegra2/usb.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/cpu/armv7/tegra2/usb.c b/arch/arm/cpu/armv7/tegra2/usb.c > index 5f2b243..ea7f701 100644 > --- a/arch/arm/cpu/armv7/tegra2/usb.c > +++ b/arch/arm/cpu/armv7/tegra2/usb.c > @@ -158,7 +158,8 @@ static void set_host_mode(struct fdt_usb *config) > } > } > > -void usbf_reset_controller(struct fdt_usb *config, struct usb_ctlr *usbctlr) > +static void usbf_reset_controller(struct fdt_usb *config, > + struct usb_ctlr *usbctlr) > { > /* Reset the USB controller with 2us delay */ > reset_periph(config->periph_id, 2); > @@ -382,8 +383,8 @@ int tegrausb_stop_port(void) > return 0; > } > > -int fdt_decode_usb(const void *blob, int node, unsigned osc_frequency_mhz, > - struct fdt_usb *config) > +static int fdt_decode_usb(const void *blob, int node, > + unsigned osc_frequency_mhz, struct fdt_usb *config) > { > const char *phy, *mode; > > -- > 1.7.10.4 >
Dear Simon Glass, > On Sat, Jul 21, 2012 at 4:02 PM, Marek Vasut <marex@denx.de> wrote: > > Signed-off-by: Marek Vasut <marex@denx.de> > > Cc: Simon Glass <sjg@chromium.org> > > Cc: Tom Warren <twarren@nvidia.com> > > Cc: Wolfgang Denk <wd@denx.de> > > Cc: Albert Aribaud <albert.u.boot@aribaud.net> > > Cc: U-Boot DM <u-boot-dm@lists.denx.de> > > Acked-by: Simon Glass <sjg@chromium.org> Simon, can you please pick up this one separatelly through your tree? I already agreed with Tom to rip this apart as it's not really a series, but rather a dump of random patches and cleanups. This is basically the first chapter of my crusade towards making you crazy from breakage ... I mean ... cleaning up drivers scattered across arch/ directory and moving them to drivers/ directory ... Best regards, Marek Vasut
Dear Tom Warren, > Marek, > > > -----Original Message----- > > From: Marek Vasut [mailto:marex@denx.de] > > Sent: Monday, July 23, 2012 11:24 PM > > To: Simon Glass > > Cc: u-boot@lists.denx.de; u-boot-dm@lists.denx.de; Tom Warren; Wolfgang > > Denk; Albert Aribaud > > Subject: Re: [PATCH 08/10] dm: tegra: Staticize local functions in usb.c > > > > Dear Simon Glass, > > > > > On Sat, Jul 21, 2012 at 4:02 PM, Marek Vasut <marex@denx.de> wrote: > > > > Signed-off-by: Marek Vasut <marex@denx.de> > > > > Cc: Simon Glass <sjg@chromium.org> > > > > Cc: Tom Warren <twarren@nvidia.com> > > > > Cc: Wolfgang Denk <wd@denx.de> > > > > Cc: Albert Aribaud <albert.u.boot@aribaud.net> > > > > Cc: U-Boot DM <u-boot-dm@lists.denx.de> > > > > > > Acked-by: Simon Glass <sjg@chromium.org> > > > > Simon, can you please pick up this one separatelly through your tree? I > > already agreed with Tom to rip this apart as it's not really a series, > > but rather a dump of random patches and cleanups. This is basically the > > first chapter of my crusade towards making you crazy from breakage ... I > > mean ... cleaning up drivers scattered across arch/ directory and moving > > them to drivers/ directory ... > > Simon doesn't manage the Tegra repo, I do. Simon is the most prodigious > Tegra submitter by far, but he's a Google employee, not an Nvidian. Hehe ... and I always kept torturing Simon about since I had trouble remembering this, sorry Simon ;-) > I don't recall any conversation with you WRT this patch series ('rip this > apart'?) Well, let patches in this series be picked up by various people. > , and see nothing in my archived U-Boot emails about it - is there > another Tom (Rini? or Rix?) that you had this convo with? About what? > Regardless, I'll apply this to u-boot-tegra/master & /next since the > changes are trivial. Ok, thanks > Note that any future Tegra changes will need to be > rebased against master, as Allen's SPL rewrite/rework caused a lot of > files to move around. I don't expect more right now. > Tom > > > Best regards, > > Marek Vasut Best regards, Marek Vasut
diff --git a/arch/arm/cpu/armv7/tegra2/usb.c b/arch/arm/cpu/armv7/tegra2/usb.c index 5f2b243..ea7f701 100644 --- a/arch/arm/cpu/armv7/tegra2/usb.c +++ b/arch/arm/cpu/armv7/tegra2/usb.c @@ -158,7 +158,8 @@ static void set_host_mode(struct fdt_usb *config) } } -void usbf_reset_controller(struct fdt_usb *config, struct usb_ctlr *usbctlr) +static void usbf_reset_controller(struct fdt_usb *config, + struct usb_ctlr *usbctlr) { /* Reset the USB controller with 2us delay */ reset_periph(config->periph_id, 2); @@ -382,8 +383,8 @@ int tegrausb_stop_port(void) return 0; } -int fdt_decode_usb(const void *blob, int node, unsigned osc_frequency_mhz, - struct fdt_usb *config) +static int fdt_decode_usb(const void *blob, int node, + unsigned osc_frequency_mhz, struct fdt_usb *config) { const char *phy, *mode;
Signed-off-by: Marek Vasut <marex@denx.de> Cc: Simon Glass <sjg@chromium.org> Cc: Tom Warren <twarren@nvidia.com> Cc: Wolfgang Denk <wd@denx.de> Cc: Albert Aribaud <albert.u.boot@aribaud.net> Cc: U-Boot DM <u-boot-dm@lists.denx.de> --- arch/arm/cpu/armv7/tegra2/usb.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)