Message ID | 1342818289-31860-1-git-send-email-sw@weilnetz.de |
---|---|
State | Accepted |
Headers | show |
On Fri, Jul 20, 2012 at 11:04:49PM +0200, Stefan Weil wrote: > Commit 0d936928ef87ca1bb7b41b5b89c400c699a7691c removed code, > but left the related comment at a location where it no longer > belongs to. > > The patch moves the comment to the correct callback and improves the text. > > Signed-off-by: Stefan Weil <sw@weilnetz.de> > --- > hw/qdev.h | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) Thanks, applied to the trivial patches tree: https://github.com/stefanha/qemu/commits/trivial-patches Stefan
On Fri, Jul 20, 2012 at 9:04 PM, Stefan Weil <sw@weilnetz.de> wrote: > Commit 0d936928ef87ca1bb7b41b5b89c400c699a7691c removed code, > but left the related comment at a location where it no longer > belongs to. > > The patch moves the comment to the correct callback and improves the text. > > Signed-off-by: Stefan Weil <sw@weilnetz.de> > --- > hw/qdev.h | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/hw/qdev.h b/hw/qdev.h > index 247dd1e..a2cbd9d 100644 > --- a/hw/qdev.h > +++ b/hw/qdev.h > @@ -78,12 +78,6 @@ struct DeviceState { > int alias_required_for_version; > }; > > -/* > - * This callback is used to create Open Firmware device path in accordance with > - * OF spec http://forthworks.com/standards/of1275.pdf. Indicidual bus bindings > - * can be found here http://playground.sun.com/1275/bindings/. > - */ > - > #define TYPE_BUS "bus" > #define BUS(obj) OBJECT_CHECK(BusState, (obj), TYPE_BUS) > #define BUS_CLASS(klass) OBJECT_CLASS_CHECK(BusClass, (klass), TYPE_BUS) > @@ -95,6 +89,11 @@ struct BusClass { > /* FIXME first arg should be BusState */ > void (*print_dev)(Monitor *mon, DeviceState *dev, int indent); > char *(*get_dev_path)(DeviceState *dev); > + /* > + * This callback is used to create Open Firmware device path in accordance > + * with OF spec http://forthworks.com/standards/of1275.pdf. Individual bus > + * bindings can be found at http://playground.sun.com/1275/bindings/. > + */ The links are dead. Since you are improving the text, maybe you could find archived versions. > char *(*get_fw_dev_path)(DeviceState *dev); > int (*reset)(BusState *bus); > }; > -- > 1.7.10 > >
On 23 July 2012 19:49, Blue Swirl <blauwirbel@gmail.com> wrote: > On Fri, Jul 20, 2012 at 9:04 PM, Stefan Weil <sw@weilnetz.de> wrote: >> + /* >> + * This callback is used to create Open Firmware device path in accordance >> + * with OF spec http://forthworks.com/standards/of1275.pdf. Individual bus >> + * bindings can be found at http://playground.sun.com/1275/bindings/. >> + */ > > The links are dead. Since you are improving the text, maybe you could > find archived versions. Hard to tell not knowing what the original links were, but maybe for bus bindings: http://www.openfirmware.org/ofwg/home.html#OFDbussupps I suspect that finding a publicly downloadable copy of IEEE1275 is going to be tricky given it's a commercially published standards doc. -- PMM
Am 23.07.2012 23:46, schrieb Peter Maydell: > On 23 July 2012 19:49, Blue Swirl<blauwirbel@gmail.com> wrote: >> On Fri, Jul 20, 2012 at 9:04 PM, Stefan Weil<sw@weilnetz.de> wrote: >>> + /* >>> + * This callback is used to create Open Firmware device path in accordance >>> + * with OF spec http://forthworks.com/standards/of1275.pdf. Individual bus >>> + * bindings can be found at http://playground.sun.com/1275/bindings/. >>> + */ >> >> The links are dead. Since you are improving the text, maybe you could >> find archived versions. > > Hard to tell not knowing what the original links were, but maybe > for bus bindings: > http://www.openfirmware.org/ofwg/home.html#OFDbussupps > > I suspect that finding a publicly downloadable copy of IEEE1275 is > going to be tricky given it's a commercially published standards doc. > > -- PMM http://www.openfirmware.com/1275/bindings/ seems to be the new location of the 2nd link. http://www.openfirmware.info/IEEE_1275-1994 has a link to http://www.openbios.org/data/docs/of1275.pdf, but it looks like there is a server configuration problem (error 403). I'll send a mail to the webmaster of openbios.org. Regards, Stefan W.
diff --git a/hw/qdev.h b/hw/qdev.h index 247dd1e..a2cbd9d 100644 --- a/hw/qdev.h +++ b/hw/qdev.h @@ -78,12 +78,6 @@ struct DeviceState { int alias_required_for_version; }; -/* - * This callback is used to create Open Firmware device path in accordance with - * OF spec http://forthworks.com/standards/of1275.pdf. Indicidual bus bindings - * can be found here http://playground.sun.com/1275/bindings/. - */ - #define TYPE_BUS "bus" #define BUS(obj) OBJECT_CHECK(BusState, (obj), TYPE_BUS) #define BUS_CLASS(klass) OBJECT_CLASS_CHECK(BusClass, (klass), TYPE_BUS) @@ -95,6 +89,11 @@ struct BusClass { /* FIXME first arg should be BusState */ void (*print_dev)(Monitor *mon, DeviceState *dev, int indent); char *(*get_dev_path)(DeviceState *dev); + /* + * This callback is used to create Open Firmware device path in accordance + * with OF spec http://forthworks.com/standards/of1275.pdf. Individual bus + * bindings can be found at http://playground.sun.com/1275/bindings/. + */ char *(*get_fw_dev_path)(DeviceState *dev); int (*reset)(BusState *bus); };
Commit 0d936928ef87ca1bb7b41b5b89c400c699a7691c removed code, but left the related comment at a location where it no longer belongs to. The patch moves the comment to the correct callback and improves the text. Signed-off-by: Stefan Weil <sw@weilnetz.de> --- hw/qdev.h | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)