Message ID | 1342963719-1810-3-git-send-email-s.martin49@gmail.com |
---|---|
State | Rejected |
Headers | show |
Le Sun, 22 Jul 2012 15:28:30 +0200,
Samuel Martin <s.martin49@gmail.com> a écrit :
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
Do you have a justification for this? Please include it in the commit
message.
Thanks!
Thomas
>>>>> "Samuel" == Samuel Martin <s.martin49@gmail.com> writes:
Samuel> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
Why? As far as I can see we don't have anything depending on e2fsprogs,
and the libuuid stuff moved to util-linux, didn't it?
Samuel> diff --git a/package/e2fsprogs/e2fsprogs.mk b/package/e2fsprogs/e2fsprogs.mk
Samuel> index 16725ac..036e54e 100644
Samuel> --- a/package/e2fsprogs/e2fsprogs.mk
Samuel> +++ b/package/e2fsprogs/e2fsprogs.mk
Samuel> @@ -26,6 +26,9 @@ E2FSPROGS_DEPENDENCIES = host-pkg-config util-linux
Samuel> E2FSPROGS_MAKE_OPT = \
Samuel> LDCONFIG=true
Samuel> +E2FSPROGS_INSTALL_STAGING = YES
Samuel> +E2FSPROGS_INSTALL_STAGING_OPT += install install-libs DESTDIR=$(STAGING_DIR)
Samuel> +
Samuel> define HOST_E2FSPROGS_INSTALL_CMDS
Samuel> $(HOST_MAKE_ENV) $(MAKE) -C $(@D) install install-libs
Samuel> endef
Samuel> --
Samuel> 1.7.11.2
Samuel> _______________________________________________
Samuel> buildroot mailing list
Samuel> buildroot@busybox.net
Samuel> http://lists.busybox.net/mailman/listinfo/buildroot
2012/10/10 Peter Korsgaard <jacmet@uclibc.org>: >>>>>> "Samuel" == Samuel Martin <s.martin49@gmail.com> writes: > > Samuel> Signed-off-by: Samuel Martin <s.martin49@gmail.com> > > Why? As far as I can see we don't have anything depending on e2fsprogs, > and the libuuid stuff moved to util-linux, didn't it? Well... so far, none that I'm aware of need e2fsprogs, though some people tried to add some packages that need it some months ago. So, maybe we could just skip this patch until someone/some package need it.
diff --git a/package/e2fsprogs/e2fsprogs.mk b/package/e2fsprogs/e2fsprogs.mk index 16725ac..036e54e 100644 --- a/package/e2fsprogs/e2fsprogs.mk +++ b/package/e2fsprogs/e2fsprogs.mk @@ -26,6 +26,9 @@ E2FSPROGS_DEPENDENCIES = host-pkg-config util-linux E2FSPROGS_MAKE_OPT = \ LDCONFIG=true +E2FSPROGS_INSTALL_STAGING = YES +E2FSPROGS_INSTALL_STAGING_OPT += install install-libs DESTDIR=$(STAGING_DIR) + define HOST_E2FSPROGS_INSTALL_CMDS $(HOST_MAKE_ENV) $(MAKE) -C $(@D) install install-libs endef
Signed-off-by: Samuel Martin <s.martin49@gmail.com>