| Message ID | 142c01cd639c$2f081800$8d184800$%kim@samsung.com |
|---|---|
| State | New |
| Headers | show |
On Monday 16 July 2012, Kukjin Kim wrote: > Here is second Samsung cleanup pull request for v3.6. > Please pull from: > git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git > next/cleanup-samsung-2 > > It is related in using common GPIO API and removing unused GPIOs. > > If any problems, please let me know. > Very nice series, I've merged it into next/cleanup now. Two general comments on your submissions: 1. Please put the branch name into the same line as the git url, that makes it slightly faster for me to copy-and-paste the pull location. 2. If you can, please use signed tags for your pull requests rather than branch names. A signed tag means that you can write the text for the merge changeset yourself so I don't have to do the description. Ideally the signing key should have signatures from other people in the keyring so everybody can check the authenticity of the request, but just having the changelog there also helps. Arnd
Arnd Bergmann wrote: > > On Monday 16 July 2012, Kukjin Kim wrote: > > Here is second Samsung cleanup pull request for v3.6. > > Please pull from: > > git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git > > next/cleanup-samsung-2 > > > > It is related in using common GPIO API and removing unused GPIOs. > > > > If any problems, please let me know. > > > > Very nice series, I've merged it into next/cleanup now. > Thanks. > Two general comments on your submissions: > > 1. Please put the branch name into the same line as the git url, that > makes it slightly faster for me to copy-and-paste the pull location. > Yeah, I know. If the line exceeds 80 columns (actually, 76 columns), automatically, my e-mail client adds new line when I send git-pull or anything else to mailing-list. And the git address which is including branch name is included in the case :-( So I will change the options of e-mail client when I send pull-request. > 2. If you can, please use signed tags for your pull requests rather > than branch names. A signed tag means that you can write the text > for the merge changeset yourself so I don't have to do the description. > Ideally the signing key should have signatures from other people in the > keyring so everybody can check the authenticity of the request, but > just having the changelog there also helps. > OK, I see. I will try to use it as per your suggestion. But I'm not familiar with that now. So if you don't mind I'd like to send signed tag from next merge window :-) Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.
On Thursday 19 July 2012, Kukjin Kim wrote: > > 2. If you can, please use signed tags for your pull requests rather > > than branch names. A signed tag means that you can write the text > > for the merge changeset yourself so I don't have to do the description. > > Ideally the signing key should have signatures from other people in the > > keyring so everybody can check the authenticity of the request, but > > just having the changelog there also helps. > > > OK, I see. I will try to use it as per your suggestion. But I'm not familiar > with that now. So if you don't mind I'd like to send signed tag from next > merge window :-) No problem. It's not a big difference to me anyway. I suppose by then we will also have had the chance for keysigning at the ARM mini summit. Arnd
Arnd Bergmann wrote: > > On Thursday 19 July 2012, Kukjin Kim wrote: > > > 2. If you can, please use signed tags for your pull requests rather > > > than branch names. A signed tag means that you can write the text > > > for the merge changeset yourself so I don't have to do the description. > > > Ideally the signing key should have signatures from other people in > the > > > keyring so everybody can check the authenticity of the request, but > > > just having the changelog there also helps. > > > > > OK, I see. I will try to use it as per your suggestion. But I'm not > familiar > > with that now. So if you don't mind I'd like to send signed tag from > next > > merge window :-) > > No problem. It's not a big difference to me anyway. I suppose by then we > will > also have had the chance for keysigning at the ARM mini summit. > Great, thanks. BTW, maybe you missed following pull-request from me? Samsung devel-2: http://lists.infradead.org/pipermail/linux-arm-kernel/2012-July/110336.html Samsung devel-spi: http://lists.infradead.org/pipermail/linux-arm-kernel/2012-July/110337.html Samsung board-3: http://lists.infradead.org/pipermail/linux-arm-kernel/2012-July/110338.html If any problems, please kindly let me know. Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.
Hi Arnd, Olof, Here is second Samsung cleanup pull request for v3.6. Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git next/cleanup-samsung-2 It is related in using common GPIO API and removing unused GPIOs. If any problems, please let me know. Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. The following changes since commit bd0a521e88aa7a06ae7aabaed7ae196ed4ad867a: Linux 3.5-rc6 (2012-07-07 17:23:56 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git next/cleanup-samsung-2 Sylwester Nawrocki (8): ARM: S3C24XX: Free the backlight gpio requested in Mini2440 board code ARM: S3C24XX: Convert SMDK board file to the gpiolib API ARM: S3C24XX: Convert QT2410 board file to the gpiolib API ARM: S3C24XX: Convert the PM code to gpiolib API ARM: S3C24XX: Convert the touchscreen setup code to common GPIO API ARM: S3C24XX: Remove unused GPA, GPE, GPH bank GPIO aliases ARM: S3C24XX: Remove unused GPIO definitions for port J ARM: S3C24XX: Remove unused GPIO definitions for Openmoko GTA02 board arch/arm/mach-s3c24xx/common-smdk.c | 20 ++++--- arch/arm/mach-s3c24xx/include/mach/gpio-nrs.h | 21 ------- arch/arm/mach-s3c24xx/include/mach/gta02.h | 69 ---------------------- arch/arm/mach-s3c24xx/include/mach/regs-gpio.h | 17 +++++- arch/arm/mach-s3c24xx/include/mach/regs-gpioj.h | 70 ----------------------- arch/arm/mach-s3c24xx/mach-gta02.c | 1 - arch/arm/mach-s3c24xx/mach-mini2440.c | 4 +- arch/arm/mach-s3c24xx/mach-qt2410.c | 6 +- arch/arm/mach-s3c24xx/mach-rx1950.c | 1 - arch/arm/mach-s3c24xx/pm-s3c2410.c | 12 +++- arch/arm/mach-s3c24xx/pm-s3c2412.c | 1 - arch/arm/mach-s3c24xx/s3c2412.c | 1 - arch/arm/mach-s3c24xx/s3c244x.c | 1 - arch/arm/mach-s3c24xx/setup-ts.c | 6 +-- 14 files changed, 40 insertions(+), 190 deletions(-) delete mode 100644 arch/arm/mach-s3c24xx/include/mach/regs-gpioj.h