| Message ID | 1341555027-17462-1-git-send-email-marex@denx.de |
|---|---|
| State | Accepted |
| Commit | f728598f8d8edd6df2b53665ddadaf18401e5b11 |
| Headers | show |
On Fri, 2012-07-06 at 08:10 +0200, Marek Vasut wrote: > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> > Cc: David Woodhouse <david.woodhouse@intel.com> Pushed 1/3 and 2/3 to l2-mtd.git, thanks!
On Wed, 2012-07-18 at 18:08 +0200, Marek Vasut wrote: > Dear Artem Bityutskiy, > > > On Fri, 2012-07-06 at 08:10 +0200, Marek Vasut wrote: > > > Signed-off-by: Marek Vasut <marex@denx.de> > > > Cc: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> > > > Cc: David Woodhouse <david.woodhouse@intel.com> > > > > Pushed 1/3 and 2/3 to l2-mtd.git, thanks! > > Thanks, Artem. Could you please suggest where to document the property added in > 3/3 please? I do not know. Surely there is a DT mailing list and DT experts - I'd ask there/them.
Dear Artem Bityutskiy, > On Fri, 2012-07-06 at 08:10 +0200, Marek Vasut wrote: > > Signed-off-by: Marek Vasut <marex@denx.de> > > Cc: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> > > Cc: David Woodhouse <david.woodhouse@intel.com> > > Pushed 1/3 and 2/3 to l2-mtd.git, thanks! Thanks, Artem. Could you please suggest where to document the property added in 3/3 please? Best regards, Marek Vasut
On Wed, 2012-07-18 at 18:08 +0200, Marek Vasut wrote: > Dear Artem Bityutskiy, > > > On Fri, 2012-07-06 at 08:10 +0200, Marek Vasut wrote: > > > Signed-off-by: Marek Vasut <marex@denx.de> > > > Cc: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> > > > Cc: David Woodhouse <david.woodhouse@intel.com> > > > > Pushed 1/3 and 2/3 to l2-mtd.git, thanks! > > Thanks, Artem. Could you please suggest where to document the property added in > 3/3 please? Rob Herring responded to me last time, let's try to ask him. Rob, the question is here: http://lists.infradead.org/pipermail/linux-mtd/2012-July/042752.html "NOTE: I'm not sure where to document this property, as m25p80 is a simple DT device. Any hints please?"
On 07/18/2012 11:13 AM, Artem Bityutskiy wrote: > On Wed, 2012-07-18 at 18:08 +0200, Marek Vasut wrote: >> Dear Artem Bityutskiy, >> >>> On Fri, 2012-07-06 at 08:10 +0200, Marek Vasut wrote: >>>> Signed-off-by: Marek Vasut <marex@denx.de> >>>> Cc: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> >>>> Cc: David Woodhouse <david.woodhouse@intel.com> >>> >>> Pushed 1/3 and 2/3 to l2-mtd.git, thanks! >> >> Thanks, Artem. Could you please suggest where to document the property added in >> 3/3 please? > > Rob Herring responded to me last time, let's try to ask him. Rob, the > question is here: > > http://lists.infradead.org/pipermail/linux-mtd/2012-July/042752.html > > "NOTE: I'm not sure where to document this property, as m25p80 is > a simple DT device. Any hints please?" Looks like "spansion,m25p80" needs to be documented under Documentation/devicetree/bindings/mtd, and then this new property documented with it. The only in tree user right now is here: arch/powerpc/boot/dts/p2020rdb-pc.dtsi Rob
Dear Rob Herring, > On 07/18/2012 11:13 AM, Artem Bityutskiy wrote: > > On Wed, 2012-07-18 at 18:08 +0200, Marek Vasut wrote: > >> Dear Artem Bityutskiy, > >> > >>> On Fri, 2012-07-06 at 08:10 +0200, Marek Vasut wrote: > >>>> Signed-off-by: Marek Vasut <marex@denx.de> > >>>> Cc: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> > >>>> Cc: David Woodhouse <david.woodhouse@intel.com> > >>> > >>> Pushed 1/3 and 2/3 to l2-mtd.git, thanks! > >> > >> Thanks, Artem. Could you please suggest where to document the property > >> added in 3/3 please? > > > > Rob Herring responded to me last time, let's try to ask him. Rob, the > > question is here: > > > > http://lists.infradead.org/pipermail/linux-mtd/2012-July/042752.html > > > > "NOTE: I'm not sure where to document this property, as m25p80 is > > > > a simple DT device. Any hints please?" > > Looks like "spansion,m25p80" needs to be documented under > Documentation/devicetree/bindings/mtd, and then this new property > documented with it. The only in tree user right now is here: > > arch/powerpc/boot/dts/p2020rdb-pc.dtsi Roger that, Rob! Will submit a new version of the patch ASAP. Thanks! Best regards, Marek Vasut
diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c index b4dbcef..d8d4672 100644 --- a/drivers/mtd/devices/m25p80.c +++ b/drivers/mtd/devices/m25p80.c @@ -671,6 +671,7 @@ static const struct spi_device_id m25p_ids[] = { { "s25sl032a", INFO(0x010215, 0, 64 * 1024, 64, 0) }, { "s25sl032p", INFO(0x010215, 0x4d00, 64 * 1024, 64, SECT_4K) }, { "s25sl064a", INFO(0x010216, 0, 64 * 1024, 128, 0) }, + { "s25sl064p", INFO(0x010216, 0x4d00, 64 * 1024, 128, SECT_4K) }, { "s25fl256s0", INFO(0x010219, 0x4d00, 256 * 1024, 128, 0) }, { "s25fl256s1", INFO(0x010219, 0x4d01, 64 * 1024, 512, 0) }, { "s25fl512s", INFO(0x010220, 0x4d00, 256 * 1024, 256, 0) },
Signed-off-by: Marek Vasut <marex@denx.de> Cc: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Cc: David Woodhouse <david.woodhouse@intel.com> --- drivers/mtd/devices/m25p80.c | 1 + 1 file changed, 1 insertion(+)