| Message ID | 1341266419-21321-1-git-send-email-festevam@gmail.com |
|---|---|
| State | New, archived |
| Headers | show |
Hello Fabio, On Mon, Jul 02, 2012 at 07:00:19PM -0300, Fabio Estevam wrote: > From: Fabio Estevam <fabio.estevam@freescale.com> > > With device tree support in place, we should not use IMX_HAVE_PLATFORM_MXC_NAND > as a dependency for selecting the mxc_nand driver. > > Use ARCH_MXC symbol instead, so that the driver can be even selected when a single device-tree > machine is selected. the obvious alternative is to select IMX_HAVE_PLATFORM_MXC_NAND for the dt-based machines, too. Or make it: depends on IMX_HAVE_PLATFORM_MXC_NAND || DT || COMPILE_COVERAGE (COMPILE_COVERAGE doesn't exist AFAIK, but IMHO it's sensible to introduce it.) Best regards Uwe
Hi Uwe, On Tue, Jul 3, 2012 at 4:03 AM, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > the obvious alternative is to select IMX_HAVE_PLATFORM_MXC_NAND for the > dt-based machines, too. That would cause platform-mxc_nand.c to be build, which is something that a dt machine does not need. > > Or make it: > > depends on IMX_HAVE_PLATFORM_MXC_NAND || DT || COMPILE_COVERAGE What about "depends on IMX_HAVE_PLATFORM_MXC_NAND || CONFIG_OF" ? > (COMPILE_COVERAGE doesn't exist AFAIK, but IMHO it's sensible to > introduce it.) Ok, then maybe this could be introduced via another patchset. Regards, Fabio Estevam
On Mon, Jul 02, 2012 at 07:00:19PM -0300, Fabio Estevam wrote: > From: Fabio Estevam <fabio.estevam@freescale.com> > > With device tree support in place, we should not use IMX_HAVE_PLATFORM_MXC_NAND > as a dependency for selecting the mxc_nand driver. > > Use ARCH_MXC symbol instead, so that the driver can be even selected when a single device-tree > machine is selected. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> Simple solution for a problem. I don't want to add even more dependencies. Also I think being able to compile in a driver even if it has no possible users in the tree does not hurt, so: Acked-by: Sascha Hauer <s.hauer@pengutronix.de> > --- > drivers/mtd/nand/Kconfig | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig > index de69978..d2a0db1 100644 > --- a/drivers/mtd/nand/Kconfig > +++ b/drivers/mtd/nand/Kconfig > @@ -521,7 +521,7 @@ config MTD_NAND_MPC5121_NFC > > config MTD_NAND_MXC > tristate "MXC NAND support" > - depends on IMX_HAVE_PLATFORM_MXC_NAND > + depends on ARCH_MXC > help > This enables the driver for the NAND flash controller on the > MXC processors. > -- > 1.7.1 > >
On Mon, Jul 02, 2012 at 07:00:19PM -0300, Fabio Estevam wrote: > From: Fabio Estevam <fabio.estevam@freescale.com> > > With device tree support in place, we should not use IMX_HAVE_PLATFORM_MXC_NAND > as a dependency for selecting the mxc_nand driver. > > Use ARCH_MXC symbol instead, so that the driver can be even selected when a single device-tree > machine is selected. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Thanks Uwe
On Mon, 2012-07-02 at 19:00 -0300, Fabio Estevam wrote: > From: Fabio Estevam <fabio.estevam@freescale.com> > > With device tree support in place, we should not use IMX_HAVE_PLATFORM_MXC_NAND > as a dependency for selecting the mxc_nand driver. > > Use ARCH_MXC symbol instead, so that the driver can be even selected when a single device-tree > machine is selected. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> Pushed to l2-mtd.git, thanks!
diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig index de69978..d2a0db1 100644 --- a/drivers/mtd/nand/Kconfig +++ b/drivers/mtd/nand/Kconfig @@ -521,7 +521,7 @@ config MTD_NAND_MPC5121_NFC config MTD_NAND_MXC tristate "MXC NAND support" - depends on IMX_HAVE_PLATFORM_MXC_NAND + depends on ARCH_MXC help This enables the driver for the NAND flash controller on the MXC processors.