| Message ID | CABu31nOq29OtY0Kubp+foA_jJKPkgWaKnqHdMM7r7Q4vEAj0vg@mail.gmail.com |
|---|---|
| State | New |
| Headers | show |
Il 07/07/2012 17:34, Steven Bosscher ha scritto: > On Sat, Jul 7, 2012 at 5:06 PM, H.J. Lu <hjl.tools@gmail.com> wrote: >> Are you sure this the right patch? -fno-tree-dominator-opts is still here. > > I am sure it is not the right patch :-) > Thanks! > > Index: libgcc/config/t-darwin > =================================================================== > --- libgcc/config/t-darwin (revision 189348) > +++ libgcc/config/t-darwin (working copy) > @@ -1,7 +1,5 @@ > -# Pass -fno-tree-dominator-opts to work around bug 26840. > crt3.o: $(srcdir)/config/darwin-crt3.c > - $(crt_compile) \ > - -fno-tree-dominator-opts $(DARWIN_EXTRA_CRT_BUILD_CFLAGS) -c $< > + $(crt_compile) $(DARWIN_EXTRA_CRT_BUILD_CFLAGS) -c $< > > crttms.o: $(srcdir)/config/darwin-crt-tm.c > $(crt_compile) $(DARWIN_EXTRA_CRT_BUILD_CFLAGS) -DSTART -c $< > Ok if testing passes. Paolo
Hi Steven, On 7 Jul 2012, at 16:34, Steven Bosscher wrote: > On Sat, Jul 7, 2012 at 5:06 PM, H.J. Lu <hjl.tools@gmail.com> wrote: >> Are you sure this the right patch? -fno-tree-dominator-opts is still here. > > I am sure it is not the right patch :-) > Thanks! > > Index: libgcc/config/t-darwin > =================================================================== > --- libgcc/config/t-darwin (revision 189348) > +++ libgcc/config/t-darwin (working copy) > @@ -1,7 +1,5 @@ > -# Pass -fno-tree-dominator-opts to work around bug 26840. > crt3.o: $(srcdir)/config/darwin-crt3.c > - $(crt_compile) \ > - -fno-tree-dominator-opts $(DARWIN_EXTRA_CRT_BUILD_CFLAGS) -c $< > + $(crt_compile) $(DARWIN_EXTRA_CRT_BUILD_CFLAGS) -c $< > > crttms.o: $(srcdir)/config/darwin-crt-tm.c > $(crt_compile) $(DARWIN_EXTRA_CRT_BUILD_CFLAGS) -DSTART -c $< regstrapped (all+ada+objc++) on i686-darwin9 with no regressions. Iain
On 9 Jul 2012, at 09:11, Iain Sandoe wrote: >> crt3.o: $(srcdir)/config/darwin-crt3.c > regstrapped (all+ada+objc++) on i686-darwin9 with no regressions. .. but, now I re-check, crt3 is only used on Darwin 8 and earlier; That will take somewhat longer to check, machine availability is an issue - I'll see if I can run up a i686 or ppc darwin8 box. Iain
Hi Steven, On 9 Jul 2012, at 09:21, Iain Sandoe wrote: > On 9 Jul 2012, at 09:11, Iain Sandoe wrote: >>> crt3.o: $(srcdir)/config/darwin-crt3.c > >> regstrapped (all+ada+objc++) on i686-darwin9 with no regressions. > > .. but, now I re-check, crt3 is only used on Darwin 8 and earlier; > That will take somewhat longer to check, machine availability is an issue - I'll see if I can run up a i686 or ppc darwin8 box. Looking at the original PR it seems that the problem was fixed on the same day that the work-around (which your patch removes) was checked in. I've only done c/c++, should be enough for this. Anyway, although i686-Darwin 8 is sadly in need of some TLC, the proposed patch causes no regressions. ppc-darwin 8 tests are still running, but it bootstrapped (500M G4, > 24hrs for c/c++ build & test). Iain.
On 11 Jul 2012, at 00:01, Iain Sandoe wrote: > Anyway, although i686-Darwin 8 is sadly in need of some TLC, the proposed patch causes no regressions. > ppc-darwin 8 tests are still running, but it bootstrapped (500M G4, > 24hrs for c/c++ build & test). FAOD, from a testing perspective this is fine - but it needs Mike's OK, cheers Iain
On Jul 13, 2012, at 12:28 AM, Iain Sandoe wrote: > On 11 Jul 2012, at 00:01, Iain Sandoe wrote: >> Anyway, although i686-Darwin 8 is sadly in need of some TLC, the proposed patch causes no regressions. >> ppc-darwin 8 tests are still running, but it bootstrapped (500M G4, > 24hrs for c/c++ build & test). > > FAOD, from a testing perspective this is fine - but it needs Mike's OK, Hum, no, it doesn't, it has already been approved by Paolo, and I don't disagree with that approval.... :-)
On 14 Jul 2012, at 00:21, Mike Stump wrote: > On Jul 13, 2012, at 12:28 AM, Iain Sandoe wrote: >> On 11 Jul 2012, at 00:01, Iain Sandoe wrote: >>> Anyway, although i686-Darwin 8 is sadly in need of some TLC, the proposed patch causes no regressions. >>> ppc-darwin 8 tests are still running, but it bootstrapped (500M G4, > 24hrs for c/c++ build & test). >> >> FAOD, from a testing perspective this is fine - but it needs Mike's OK, > > Hum, no, it doesn't, it has already been approved by Paolo, and I don't disagree with that approval.... :-) apologies, I missed a post.
Index: libgcc/config/t-darwin =================================================================== --- libgcc/config/t-darwin (revision 189348) +++ libgcc/config/t-darwin (working copy) @@ -1,7 +1,5 @@ -# Pass -fno-tree-dominator-opts to work around bug 26840. crt3.o: $(srcdir)/config/darwin-crt3.c - $(crt_compile) \ - -fno-tree-dominator-opts $(DARWIN_EXTRA_CRT_BUILD_CFLAGS) -c $< + $(crt_compile) $(DARWIN_EXTRA_CRT_BUILD_CFLAGS) -c $< crttms.o: $(srcdir)/config/darwin-crt-tm.c $(crt_compile) $(DARWIN_EXTRA_CRT_BUILD_CFLAGS) -DSTART -c $<
On Sat, Jul 7, 2012 at 5:06 PM, H.J. Lu <hjl.tools@gmail.com> wrote: > Are you sure this the right patch? -fno-tree-dominator-opts is still here. I am sure it is not the right patch :-) Thanks!