Message ID | 1339772759-31004-27-git-send-email-pbonzini@redhat.com |
---|---|
State | New |
Headers | show |
On 06/15/2012 09:05 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > --- > qapi-schema.json | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/qapi-schema.json b/qapi-schema.json > index 2ee988b..250edf2 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -1289,6 +1289,7 @@ > # > # Returns: nothing on success > # If @device is not a valid block device, DeviceNotFound > +# If the block device has no medium inserted, DeviceHasNoMedium > # If @device is busy, DeviceInUse will be returned > # If @snapshot-file can't be created, OpenFileFailed > # If @snapshot-file can't be opened, OpenFileFailed Can we combine these? If @snapshot-file can't be opened or created, OpenFileFailed > @@ -1321,6 +1322,9 @@ > # > # Returns: nothing on success > # If @device is not a valid block device, DeviceNotFound > +# If the block device has no medium inserted, DeviceHasNoMedium > +# If @device is busy, DeviceInUse will be returned > +# If @snapshot-file can't be created, OpenFileFailed > # If @snapshot-file can't be opened, OpenFileFailed and again.
Il 15/06/2012 23:14, Eric Blake ha scritto: > On 06/15/2012 09:05 AM, Paolo Bonzini wrote: >> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> >> --- >> qapi-schema.json | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/qapi-schema.json b/qapi-schema.json >> index 2ee988b..250edf2 100644 >> --- a/qapi-schema.json >> +++ b/qapi-schema.json >> @@ -1289,6 +1289,7 @@ >> # >> # Returns: nothing on success >> # If @device is not a valid block device, DeviceNotFound >> +# If the block device has no medium inserted, DeviceHasNoMedium >> # If @device is busy, DeviceInUse will be returned >> # If @snapshot-file can't be created, OpenFileFailed >> # If @snapshot-file can't be opened, OpenFileFailed > > Can we combine these? > > If @snapshot-file can't be opened or created, OpenFileFailed > >> @@ -1321,6 +1322,9 @@ >> # >> # Returns: nothing on success >> # If @device is not a valid block device, DeviceNotFound >> +# If the block device has no medium inserted, DeviceHasNoMedium >> +# If @device is busy, DeviceInUse will be returned >> +# If @snapshot-file can't be created, OpenFileFailed >> # If @snapshot-file can't be opened, OpenFileFailed > > and again. > Yes, done. Paolo
diff --git a/qapi-schema.json b/qapi-schema.json index 2ee988b..250edf2 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -1289,6 +1289,7 @@ # # Returns: nothing on success # If @device is not a valid block device, DeviceNotFound +# If the block device has no medium inserted, DeviceHasNoMedium # If @device is busy, DeviceInUse will be returned # If @snapshot-file can't be created, OpenFileFailed # If @snapshot-file can't be opened, OpenFileFailed @@ -1321,6 +1322,9 @@ # # Returns: nothing on success # If @device is not a valid block device, DeviceNotFound +# If the block device has no medium inserted, DeviceHasNoMedium +# If @device is busy, DeviceInUse will be returned +# If @snapshot-file can't be created, OpenFileFailed # If @snapshot-file can't be opened, OpenFileFailed # If @format is invalid, InvalidBlockFormat #
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> --- qapi-schema.json | 4 ++++ 1 file changed, 4 insertions(+)