diff mbox

[U-Boot] arm: rmobile: kzm9g: Adjust hardware setting in lowlevel_init.S

Message ID 4FE91EB8.6090407@kmckk.co.jp
State Superseded
Headers show

Commit Message

Tetsuyuki Kobayashi June 26, 2012, 2:30 a.m. UTC 
This patch depends on
 Nobuhiro Iwamatsu's arm: rmobile: Add supoprt for KMC KZM-A9-GT board
 Tetsuyuki Kobayashi's arm: rmobile: kzm9g: Modify sdram area


Adjust hardware setting in lowlevel_init.S.
After this patch U-boot can boot Linux kernel (without DTB) on KZM-A9-GT board successfully.

Signed-off-by: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
---
 arch/arm/include/asm/arch-rmobile/sh73a0.h |    1 +
 board/kmc/kzm/lowlevel_init.S              |    3 +++
 2 files changed, 4 insertions(+)

Comments

Albert ARIBAUD June 26, 2012, 9:22 p.m. UTC | #1 
Hi Tetsuyuki,

On Tue, 26 Jun 2012 11:30:16 +0900, Tetsuyuki Kobayashi
<koba@kmckk.co.jp> wrote:

> This patch depends on
>  Nobuhiro Iwamatsu's arm: rmobile: Add supoprt for KMC KZM-A9-GT board
>  Tetsuyuki Kobayashi's arm: rmobile: kzm9g: Modify sdram area

Seems like a series to me -- you should post it as such, with patches
numbered 1/N, 2/N etc. Should be easy as you probably already have them
as a series of commits above master; git format-patch should generate
the mails alright.

Amicalement,
Tetsuyuki Kobayashi June 27, 2012, 7:56 a.m. UTC | #2 
Hi Albert

(2012/06/27 6:22), Albert ARIBAUD wrote:

> On Tue, 26 Jun 2012 11:30:16 +0900, Tetsuyuki Kobayashi
> <koba@kmckk.co.jp>  wrote:
>
>> This patch depends on
>>   Nobuhiro Iwamatsu's arm: rmobile: Add supoprt for KMC KZM-A9-GT board
>>   Tetsuyuki Kobayashi's arm: rmobile: kzm9g: Modify sdram area
>
> Seems like a series to me -- you should post it as such, with patches
> numbered 1/N, 2/N etc. Should be easy as you probably already have them
> as a series of commits above master; git format-patch should generate
> the mails alright.

OK. I am studying git format-patch and git send-email.
Nobuhiro Iwamatsu July 5, 2012, 7:02 a.m. UTC | #3 
Hi,

I modified my rmobile git tree. Please rebase your local repository
and resend this patch.
Best regards,
  Nobuhiro

2012/6/26 Tetsuyuki Kobayashi <koba@kmckk.co.jp>:
> This patch depends on
>  Nobuhiro Iwamatsu's arm: rmobile: Add supoprt for KMC KZM-A9-GT board
>  Tetsuyuki Kobayashi's arm: rmobile: kzm9g: Modify sdram area
>
>
> Adjust hardware setting in lowlevel_init.S.
> After this patch U-boot can boot Linux kernel (without DTB) on KZM-A9-GT board successfully.
>
> Signed-off-by: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
> ---
>  arch/arm/include/asm/arch-rmobile/sh73a0.h |    1 +
>  board/kmc/kzm/lowlevel_init.S              |    3 +++
>  2 files changed, 4 insertions(+)
>
> diff --git a/arch/arm/include/asm/arch-rmobile/sh73a0.h b/arch/arm/include/asm/arch-rmobile/sh73a0.h
> index 07824ab..bb66d20 100644
> --- a/arch/arm/include/asm/arch-rmobile/sh73a0.h
> +++ b/arch/arm/include/asm/arch-rmobile/sh73a0.h
> @@ -191,6 +191,7 @@
>  #define        SMSTPCR3        (CPG_BASE + 0x013C)
>  #define        SMSTPCR4        (CPG_BASE + 0x0140)
>  #define        SMSTPCR5        (CPG_BASE + 0x0144)
> +#define        CPGXXCR4        (CPG_BASE + 0x0150)
>  #define        SRCR0   (CPG_BASE + 0x80A0)
>  #define        SRCR1   (CPG_BASE + 0x80A8)
>  #define        SRCR2   (CPG_BASE + 0x80B0)
> diff --git a/board/kmc/kzm/lowlevel_init.S b/board/kmc/kzm/lowlevel_init.S
> index 5221611..be3d203 100644
> --- a/board/kmc/kzm/lowlevel_init.S
> +++ b/board/kmc/kzm/lowlevel_init.S
> @@ -111,6 +111,7 @@ loop0:
>
>         and_write32     LIFEC_SEC_SRC, 0xFFFFFFE7
>
> +       and_write32     SMSTPCR3,0xFFFF7FFF
>         and_write32     SRCR3, 0xFFFF7FFF
>         and_write32     SMSTPCR2,0xFFFBFFFF
>         and_write32     SRCR2, 0xFFFBFFFF
> @@ -302,6 +303,8 @@ loop0:
>         write32         FRQCRD, 0x00000B0B
>         cmp_loop        FRQCRD, 0x80000000, 0x00000000
>
> +       write32         CPGXXCR4, 0xfffffffc
> +
>         bx      lr
>
>         .pool
> --
> 1.7.9.5
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
Tetsuyuki Kobayashi July 5, 2012, 11:37 a.m. UTC | #4 
Hello, Iwamatu-san

I rebased u-boot-sh.git arm/rmobile branch and reworked my patches.
After this patch set, LTSI kernel can boot on KZM-A9-GT board.

But I found it is not stable. It needs more work.


Tetsuyuki Kobayashi (3):
  arm: rmobile: kzm9g: Modify sdram area
  arm: rmobile: kzm9g: Adjust low level hardware setting
  arm: rmobile: kzm9g: change prompt to board specific

 arch/arm/include/asm/arch-rmobile/sh73a0.h |    4 +++-
 board/kmc/kzm9g/kzm9g.c                    |    2 ++
 include/configs/kzm9g.h                    |    7 ++++---
 3 files changed, 9 insertions(+), 4 deletions(-)

-- 1.7.9.5
Nobuhiro Iwamatsu July 6, 2012, 12:12 a.m. UTC | #5 
HI,

2012/7/5 Tetsuyuki Kobayashi <koba@kmckk.co.jp>:
> Hello, Iwamatu-san
>
> I rebased u-boot-sh.git arm/rmobile branch and reworked my patches.
> After this patch set, LTSI kernel can boot on KZM-A9-GT board.
>
> But I found it is not stable. It needs more work.
>
>
> Tetsuyuki Kobayashi (3):
>   arm: rmobile: kzm9g: Modify sdram area
>   arm: rmobile: kzm9g: Adjust low level hardware setting
>   arm: rmobile: kzm9g: change prompt to board specific
>
>  arch/arm/include/asm/arch-rmobile/sh73a0.h |    4 +++-
>  board/kmc/kzm9g/kzm9g.c                    |    2 ++
>  include/configs/kzm9g.h                    |    7 ++++---
>  3 files changed, 9 insertions(+), 4 deletions(-)
>

Applied to my rmobile repository. Thanks.
BTW, do you become a maintainer of kzm9g board?
If it becomes a maintainer, please send the patch to MAINTAINERS file.

Best regards,
  Nobuhiro
Tetsuyuki Kobayashi July 6, 2012, 7:48 a.m. UTC | #6 
Hi, Iwamatsu-san

(2012/07/06 9:12), Nobuhiro Iwamatsu wrote:

> BTW, do you become a maintainer of kzm9g board?
> If it becomes a maintainer, please send the patch to MAINTAINERS file.

Thank you. I will send it later.
Albert ARIBAUD July 6, 2012, 1:46 p.m. UTC | #7 
Hi Tetsuyuki,

On Fri, 06 Jul 2012 16:48:05 +0900, Tetsuyuki Kobayashi
<koba@kmckk.co.jp> wrote:
> Hi, Iwamatsu-san
> 
> (2012/07/06 9:12), Nobuhiro Iwamatsu wrote:
> 
> > BTW, do you become a maintainer of kzm9g board?
> > If it becomes a maintainer, please send the patch to MAINTAINERS
> > file.
> 
> Thank you. I will send it later.

Just in case: I prefer the patch to MAINTAINERS to be in the same
series as the rest of the new board support.
 
Amicalement,
Tetsuyuki Kobayashi July 7, 2012, 10:58 a.m. UTC | #8 
Hi Albert,

(2012/07/06 22:46), Albert ARIBAUD wrote:
> Hi Tetsuyuki,
>
> On Fri, 06 Jul 2012 16:48:05 +0900, Tetsuyuki Kobayashi
> <koba@kmckk.co.jp> wrote:
>> Hi, Iwamatsu-san
>>
>> (2012/07/06 9:12), Nobuhiro Iwamatsu wrote:
>>
>>> BTW, do you become a maintainer of kzm9g board?
>>> If it becomes a maintainer, please send the patch to MAINTAINERS
>>> file.
>>
>> Thank you. I will send it later.
>
> Just in case: I prefer the patch to MAINTAINERS to be in the same
> series as the rest of the new board support.

OK.

Iwamatsu-san,
Now I have another patch for kzm9g.
So I will make updated patch series including 5 patches.
(previous 3 patches + MAINTAINERS + new patch)
Tetsuyuki Kobayashi July 7, 2012, 11:23 a.m. UTC | #9 
Hi, Iwamatsu-san

I made v2 patch set for kzm9g.
Please revert my previous 3 patches and apply this patch set.

After this patch set, LTSI kernel can boot on KZM-A9-GT board.
It seems stable as before.

Tetsuyuki Kobayashi (5):
  arm: rmobile: kzm9g: Modify sdram area
  arm: rmobile: kzm9g: Adjust low level hardware setting
  arm: rmobile: kzm9g: change prompt to board specific
  arm: rmobile: kzm9g: Add dummy member to struct sh73a0_rwdt
  MAINTAINERS: Add Tetsuyuki Kobayshi for kzm9g

 MAINTAINERS                                |    1 +
 arch/arm/include/asm/arch-rmobile/sh73a0.h |    6 +++++-
 board/kmc/kzm9g/kzm9g.c                    |    2 ++
 include/configs/kzm9g.h                    |    7 ++++---
 4 files changed, 12 insertions(+), 4 deletions(-)
Tetsuyuki Kobayashi July 9, 2012, 6:30 a.m. UTC | #10 
Hi, Iwamatsu-san

I found another bug and fixed it right now.
I will add another patch in this patch series.
I will post v3 soon. Please wait to apply v2.


(2012/07/07 20:23), Tetsuyuki Kobayashi wrote:
> Hi, Iwamatsu-san
>
> I made v2 patch set for kzm9g.
> Please revert my previous 3 patches and apply this patch set.
>
> After this patch set, LTSI kernel can boot on KZM-A9-GT board.
> It seems stable as before.
>
> Tetsuyuki Kobayashi (5):
>    arm: rmobile: kzm9g: Modify sdram area
>    arm: rmobile: kzm9g: Adjust low level hardware setting
>    arm: rmobile: kzm9g: change prompt to board specific
>    arm: rmobile: kzm9g: Add dummy member to struct sh73a0_rwdt
>    MAINTAINERS: Add Tetsuyuki Kobayshi for kzm9g
>
>   MAINTAINERS                                |    1 +
>   arch/arm/include/asm/arch-rmobile/sh73a0.h |    6 +++++-
>   board/kmc/kzm9g/kzm9g.c                    |    2 ++
>   include/configs/kzm9g.h                    |    7 ++++---
>   4 files changed, 12 insertions(+), 4 deletions(-)
>
Tetsuyuki Kobayashi July 9, 2012, 11:06 a.m. UTC | #11 
From: Tetsuyuki Kobayashi <koba@kmckk.co.jp>

Hi, Iwamatsu-san

This is v3 patch set for kzm9g.
I add a patch for modifying bus controller setting for CS4.

After this patch set, LTSI kernel can boot on KZM-A9-GT board.
It seems stable as before.

Tetsuyuki Kobayashi (6):
  arm: rmobile: kzm9g: Modify sdram area
  arm: rmobile: kzm9g: Adjust low level hardware setting
  arm: rmobile: kzm9g: change prompt to board specific
  arm: rmobile: kzm9g: Add dummy member to struct sh73a0_rwdt
  MAINTAINERS: Add Tetsuyuki Kobayshi for kzm9g
  arm: rmobile: kzm9g: Modify bus controller setting for CS4

 MAINTAINERS                                |    1 +
 arch/arm/include/asm/arch-rmobile/sh73a0.h |    6 +++++-
 board/kmc/kzm9g/kzm9g.c                    |    6 ++++--
 include/configs/kzm9g.h                    |    7 ++++---
 4 files changed, 14 insertions(+), 6 deletions(-)
Tetsuyuki Kobayashi July 17, 2012, 5:13 a.m. UTC | #12 
From: Tetsuyuki Kobayashi <koba@kmckk.co.jp>

Hi, Iwamatsu-san

This is v4 patch set for kzm9g.
I modified bus controller setting for CS4. 
And enabled reset command.


Tetsuyuki Kobayashi (7):
  arm: rmobile: kzm9g: Modify sdram area
  arm: rmobile: kzm9g: Adjust low level hardware setting
  arm: rmobile: kzm9g: change prompt to board specific
  arm: rmobile: kzm9g: Add dummy member to struct sh73a0_rwdt
  MAINTAINERS: Add Tetsuyuki Kobayshi for kzm9g
  arm: rmobile: kzm9g: Modify bus controller setting for CS4
  arm: rmobile: kzm9g: enable reset command

 MAINTAINERS                                |    1 +
 arch/arm/include/asm/arch-rmobile/sh73a0.h |   10 +++++++++-
 board/kmc/kzm9g/kzm9g.c                    |    9 +++++++--
 include/configs/kzm9g.h                    |    7 ++++---
 4 files changed, 21 insertions(+), 6 deletions(-)
diff mbox

Patch

diff --git a/arch/arm/include/asm/arch-rmobile/sh73a0.h b/arch/arm/include/asm/arch-rmobile/sh73a0.h
index 07824ab..bb66d20 100644
--- a/arch/arm/include/asm/arch-rmobile/sh73a0.h
+++ b/arch/arm/include/asm/arch-rmobile/sh73a0.h
@@ -191,6 +191,7 @@ 
 #define	SMSTPCR3	(CPG_BASE + 0x013C)
 #define	SMSTPCR4	(CPG_BASE + 0x0140)
 #define	SMSTPCR5	(CPG_BASE + 0x0144)
+#define	CPGXXCR4	(CPG_BASE + 0x0150)
 #define	SRCR0	(CPG_BASE + 0x80A0)
 #define	SRCR1	(CPG_BASE + 0x80A8)
 #define	SRCR2	(CPG_BASE + 0x80B0)
diff --git a/board/kmc/kzm/lowlevel_init.S b/board/kmc/kzm/lowlevel_init.S
index 5221611..be3d203 100644
--- a/board/kmc/kzm/lowlevel_init.S
+++ b/board/kmc/kzm/lowlevel_init.S
@@ -111,6 +111,7 @@  loop0:
 
 	and_write32	LIFEC_SEC_SRC, 0xFFFFFFE7
 
+	and_write32	SMSTPCR3,0xFFFF7FFF
 	and_write32	SRCR3, 0xFFFF7FFF
 	and_write32	SMSTPCR2,0xFFFBFFFF
 	and_write32	SRCR2, 0xFFFBFFFF
@@ -302,6 +303,8 @@  loop0:
 	write32		FRQCRD, 0x00000B0B
 	cmp_loop	FRQCRD, 0x80000000, 0x00000000
 
+	write32 	CPGXXCR4, 0xfffffffc
+
 	bx      lr
 
 	.pool