Message ID | 1341559085-16745-1-git-send-email-u.kleine-koenig@pengutronix.de |
---|---|
State | New |
Headers | show |
On Fri, Jul 06, 2012 at 09:18:05AM +0200, Uwe Kleine-König wrote: > Commit > > 544496a (ARM: imx: move irq_domain_add_legacy call into avic driver) > > introduced unconditional calls to irq_find_mapping and > irq_domain_add_legacy, but it's still possible to have a .config without > CONFIG_IRQ_DOMAIN=y resulting in > > CC arch/arm/plat-mxc/avic.o > arch/arm/plat-mxc/avic.c: In function 'avic_handle_irq': > arch/arm/plat-mxc/avic.c:172: error: implicit declaration of function 'irq_find_mapping' > arch/arm/plat-mxc/avic.c: In function 'mxc_init_irq': > arch/arm/plat-mxc/avic.c:207: error: implicit declaration of function 'irq_domain_add_legacy' > arch/arm/plat-mxc/avic.c:208: error: 'irq_domain_simple_ops' undeclared (first use in this function) > arch/arm/plat-mxc/avic.c:208: error: (Each undeclared identifier is reported only once > arch/arm/plat-mxc/avic.c:208: error: for each function it appears in.) > arch/arm/plat-mxc/avic.c:208: warning: assignment makes pointer from integer without a cast > make[3]: *** [arch/arm/plat-mxc/avic.o] Error 1 > make[2]: *** [arch/arm/plat-mxc/avic.o] Error 2 > make[1]: *** [sub-make] Error 2 > make: *** [all] Error 2 > > While selecting CONFIG_IRQ_DOMAIN would be enough, USE_OF is the future > and implies CONFIG_IRQ_DOMAIN. So select USE_OF for ARCH_MXC. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > arch/arm/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 84449dd..97a33c5 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -446,6 +446,7 @@ config ARCH_MXC > select CLKSRC_MMIO > select GENERIC_IRQ_CHIP > select MULTI_IRQ_HANDLER > + select USE_OF Thanks for the quick turn-around, Uwe. With the change here, these "select USE_OF" in arch/arm/mach-imx/Kconfig can be removed altogether, I think. Regards, Shawn > help > Support for Freescale MXC/iMX-based family of processors > > -- > 1.7.10 >
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 84449dd..97a33c5 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -446,6 +446,7 @@ config ARCH_MXC select CLKSRC_MMIO select GENERIC_IRQ_CHIP select MULTI_IRQ_HANDLER + select USE_OF help Support for Freescale MXC/iMX-based family of processors
Commit 544496a (ARM: imx: move irq_domain_add_legacy call into avic driver) introduced unconditional calls to irq_find_mapping and irq_domain_add_legacy, but it's still possible to have a .config without CONFIG_IRQ_DOMAIN=y resulting in CC arch/arm/plat-mxc/avic.o arch/arm/plat-mxc/avic.c: In function 'avic_handle_irq': arch/arm/plat-mxc/avic.c:172: error: implicit declaration of function 'irq_find_mapping' arch/arm/plat-mxc/avic.c: In function 'mxc_init_irq': arch/arm/plat-mxc/avic.c:207: error: implicit declaration of function 'irq_domain_add_legacy' arch/arm/plat-mxc/avic.c:208: error: 'irq_domain_simple_ops' undeclared (first use in this function) arch/arm/plat-mxc/avic.c:208: error: (Each undeclared identifier is reported only once arch/arm/plat-mxc/avic.c:208: error: for each function it appears in.) arch/arm/plat-mxc/avic.c:208: warning: assignment makes pointer from integer without a cast make[3]: *** [arch/arm/plat-mxc/avic.o] Error 1 make[2]: *** [arch/arm/plat-mxc/avic.o] Error 2 make[1]: *** [sub-make] Error 2 make: *** [all] Error 2 While selecting CONFIG_IRQ_DOMAIN would be enough, USE_OF is the future and implies CONFIG_IRQ_DOMAIN. So select USE_OF for ARCH_MXC. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- arch/arm/Kconfig | 1 + 1 file changed, 1 insertion(+)