Message ID | 20090102150254.617580000@de.ibm.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
From: frank.blaschka@de.ibm.com Date: Fri, 02 Jan 2009 16:01:42 +0100 > For z/VM GuestLAN or VSWITCH devices the transport layer is > configured in z/VM. The layer2 attribute of a participating Linux > device has to match the z/VM definition. In case of a mismatch > Linux currently crashes in qeth recovery due to a reference to the > not yet existing net_device. > Solution: add a check for existence of net_device and add a message > pointing to the mismatch of layer definitions in Linux and z/VM. > > Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com> > Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff -urpN linux-2.6/drivers/s390/net/qeth_core_main.c linux-2.6-patched/drivers/s390/net/qeth_core_main.c --- linux-2.6/drivers/s390/net/qeth_core_main.c 2009-01-02 10:22:07.000000000 +0100 +++ linux-2.6-patched/drivers/s390/net/qeth_core_main.c 2009-01-02 10:22:07.000000000 +0100 @@ -572,6 +572,10 @@ static void qeth_send_control_data_cb(st card = CARD_FROM_CDEV(channel->ccwdev); if (qeth_check_idx_response(iob->data)) { qeth_clear_ipacmd_list(card); + if (((iob->data[2] & 0xc0) == 0xc0) && iob->data[4] == 0xf6) + dev_err(&card->gdev->dev, + "The qeth device is not configured " + "for the OSI layer required by z/VM\n"); qeth_schedule_recovery(card); goto out; } diff -urpN linux-2.6/drivers/s390/net/qeth_l2_main.c linux-2.6-patched/drivers/s390/net/qeth_l2_main.c --- linux-2.6/drivers/s390/net/qeth_l2_main.c 2009-01-02 10:21:51.000000000 +0100 +++ linux-2.6-patched/drivers/s390/net/qeth_l2_main.c 2009-01-02 10:22:07.000000000 +0100 @@ -1126,9 +1126,11 @@ static int qeth_l2_recover(void *ptr) dev_info(&card->gdev->dev, "Device successfully recovered!\n"); else { - rtnl_lock(); - dev_close(card->dev); - rtnl_unlock(); + if (card->dev) { + rtnl_lock(); + dev_close(card->dev); + rtnl_unlock(); + } dev_warn(&card->gdev->dev, "The qeth device driver " "failed to recover an error on the device\n"); } diff -urpN linux-2.6/drivers/s390/net/qeth_l3_main.c linux-2.6-patched/drivers/s390/net/qeth_l3_main.c --- linux-2.6/drivers/s390/net/qeth_l3_main.c 2009-01-02 10:22:07.000000000 +0100 +++ linux-2.6-patched/drivers/s390/net/qeth_l3_main.c 2009-01-02 10:22:07.000000000 +0100 @@ -2082,9 +2082,11 @@ static int qeth_l3_stop_card(struct qeth if (recovery_mode) qeth_l3_stop(card->dev); else { - rtnl_lock(); - dev_close(card->dev); - rtnl_unlock(); + if (card->dev) { + rtnl_lock(); + dev_close(card->dev); + rtnl_unlock(); + } } if (!card->use_hard_stop) { rc = qeth_send_stoplan(card);