| Message ID | 1338190380-5144-1-git-send-email-jiang.liu@huawei.com |
|---|---|
| State | Accepted |
| Headers | show |
On Mon, May 28, 2012 at 12:33 AM, Jiang Liu <jiang.liu@huawei.com> wrote: > Changeset "9080648 PCI: acpiphp: remove all functions in slot, > even without ACPI _EJx" introduces pci_bus_sem into the acpiphp > driver, but pci_bus_sem hasn't been exported to modules yet. > So export symbol pci_bus_sem to modules, otherwise the acpiphp > driver can't be built as module any more. > > Signed-off-by: Yijing Wang <wangyijing@huawei.com> > Signed-off-by: Jiang Liu <liuj97@gmail.com> > --- > drivers/pci/search.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/pci/search.c b/drivers/pci/search.c > index 9d75dc8..e0c7a22 100644 > --- a/drivers/pci/search.c > +++ b/drivers/pci/search.c > @@ -15,6 +15,8 @@ > #include "pci.h" > > DECLARE_RWSEM(pci_bus_sem); > +EXPORT_SYMBOL(pci_bus_sem); > + > /* > * find the upstream PCIe-to-PCI bridge of a PCI device > * if the device is PCIE, return NULL Bjorn, can you please fold this one into 9080648: PCI: acpiphp: remove all functions in slot, even without ACPI _EJx that commit now is in pci/for-3.6 Fengguang's auto compiling test robot reported same error on my for-pci-root-bus-hotplug branch that is based on pci/for-3.6. Thanks Yinghai
On Fri, Jun 8, 2012 at 12:01 AM, Yinghai Lu <yinghai@kernel.org> wrote: > On Mon, May 28, 2012 at 12:33 AM, Jiang Liu <jiang.liu@huawei.com> wrote: >> Changeset "9080648 PCI: acpiphp: remove all functions in slot, >> even without ACPI _EJx" introduces pci_bus_sem into the acpiphp >> driver, but pci_bus_sem hasn't been exported to modules yet. >> So export symbol pci_bus_sem to modules, otherwise the acpiphp >> driver can't be built as module any more. >> >> Signed-off-by: Yijing Wang <wangyijing@huawei.com> >> Signed-off-by: Jiang Liu <liuj97@gmail.com> >> --- >> drivers/pci/search.c | 2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/pci/search.c b/drivers/pci/search.c >> index 9d75dc8..e0c7a22 100644 >> --- a/drivers/pci/search.c >> +++ b/drivers/pci/search.c >> @@ -15,6 +15,8 @@ >> #include "pci.h" >> >> DECLARE_RWSEM(pci_bus_sem); >> +EXPORT_SYMBOL(pci_bus_sem); >> + >> /* >> * find the upstream PCIe-to-PCI bridge of a PCI device >> * if the device is PCIE, return NULL > > Bjorn, > > can you please fold this one into > > 9080648: > PCI: acpiphp: remove all functions in slot, even without ACPI _EJx > > that commit now is in pci/for-3.6 Yes, I'll fix this. If you don't object, I'll make it EXPORT_SYMBOL_GPL(). I think we'll have more changes in the bus scan/remove paths, and it's possible we'll be able to un-export this in the future. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Jun 11, 2012 at 10:43 AM, Bjorn Helgaas <bhelgaas@google.com> wrote: > On Fri, Jun 8, 2012 at 12:01 AM, Yinghai Lu <yinghai@kernel.org> wrote: >> On Mon, May 28, 2012 at 12:33 AM, Jiang Liu <jiang.liu@huawei.com> wrote: >>> Changeset "9080648 PCI: acpiphp: remove all functions in slot, >>> even without ACPI _EJx" introduces pci_bus_sem into the acpiphp >>> driver, but pci_bus_sem hasn't been exported to modules yet. >>> So export symbol pci_bus_sem to modules, otherwise the acpiphp >>> driver can't be built as module any more. >>> >>> Signed-off-by: Yijing Wang <wangyijing@huawei.com> >>> Signed-off-by: Jiang Liu <liuj97@gmail.com> >>> --- >>> drivers/pci/search.c | 2 ++ >>> 1 files changed, 2 insertions(+), 0 deletions(-) >>> >>> diff --git a/drivers/pci/search.c b/drivers/pci/search.c >>> index 9d75dc8..e0c7a22 100644 >>> --- a/drivers/pci/search.c >>> +++ b/drivers/pci/search.c >>> @@ -15,6 +15,8 @@ >>> #include "pci.h" >>> >>> DECLARE_RWSEM(pci_bus_sem); >>> +EXPORT_SYMBOL(pci_bus_sem); >>> + >>> /* >>> * find the upstream PCIe-to-PCI bridge of a PCI device >>> * if the device is PCIE, return NULL >> >> Bjorn, >> >> can you please fold this one into >> >> 9080648: >> PCI: acpiphp: remove all functions in slot, even without ACPI _EJx >> >> that commit now is in pci/for-3.6 > > Yes, I'll fix this. If you don't object, I'll make it > EXPORT_SYMBOL_GPL(). I think we'll have more changes in the bus > scan/remove paths, and it's possible we'll be able to un-export this > in the future. yes, it should be EXPORT_SYMBOL_GPL. I updated that in attachment. Thanks Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Jun 11, 2012 at 2:01 PM, Yinghai Lu <yinghai@kernel.org> wrote: > On Mon, Jun 11, 2012 at 10:43 AM, Bjorn Helgaas <bhelgaas@google.com> wrote: >> On Fri, Jun 8, 2012 at 12:01 AM, Yinghai Lu <yinghai@kernel.org> wrote: >>> On Mon, May 28, 2012 at 12:33 AM, Jiang Liu <jiang.liu@huawei.com> wrote: >>>> Changeset "9080648 PCI: acpiphp: remove all functions in slot, >>>> even without ACPI _EJx" introduces pci_bus_sem into the acpiphp >>>> driver, but pci_bus_sem hasn't been exported to modules yet. >>>> So export symbol pci_bus_sem to modules, otherwise the acpiphp >>>> driver can't be built as module any more. >>>> >>>> Signed-off-by: Yijing Wang <wangyijing@huawei.com> >>>> Signed-off-by: Jiang Liu <liuj97@gmail.com> >>>> --- >>>> drivers/pci/search.c | 2 ++ >>>> 1 files changed, 2 insertions(+), 0 deletions(-) >>>> >>>> diff --git a/drivers/pci/search.c b/drivers/pci/search.c >>>> index 9d75dc8..e0c7a22 100644 >>>> --- a/drivers/pci/search.c >>>> +++ b/drivers/pci/search.c >>>> @@ -15,6 +15,8 @@ >>>> #include "pci.h" >>>> >>>> DECLARE_RWSEM(pci_bus_sem); >>>> +EXPORT_SYMBOL(pci_bus_sem); >>>> + >>>> /* >>>> * find the upstream PCIe-to-PCI bridge of a PCI device >>>> * if the device is PCIE, return NULL >>> >>> Bjorn, >>> >>> can you please fold this one into >>> >>> 9080648: >>> PCI: acpiphp: remove all functions in slot, even without ACPI _EJx >>> >>> that commit now is in pci/for-3.6 >> >> Yes, I'll fix this. If you don't object, I'll make it >> EXPORT_SYMBOL_GPL(). I think we'll have more changes in the bus >> scan/remove paths, and it's possible we'll be able to un-export this >> in the future. > > yes, it should be EXPORT_SYMBOL_GPL. I applied this to my "next" branch, with EXPORT_SYMBOL_GPL. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pci/search.c b/drivers/pci/search.c index 9d75dc8..e0c7a22 100644 --- a/drivers/pci/search.c +++ b/drivers/pci/search.c @@ -15,6 +15,8 @@ #include "pci.h" DECLARE_RWSEM(pci_bus_sem); +EXPORT_SYMBOL(pci_bus_sem); + /* * find the upstream PCIe-to-PCI bridge of a PCI device * if the device is PCIE, return NULL