| Message ID | 1337942453-30224-4-git-send-email-colin.king@canonical.com |
|---|---|
| State | Accepted |
| Headers | show |
On 05/25/2012 06:40 PM, Colin King wrote: > From: Colin Ian King<colin.king@canonical.com> > > Signed-off-by: Colin Ian King<colin.king@canonical.com> > --- > src/lib/src/fwts_guid.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/src/lib/src/fwts_guid.c b/src/lib/src/fwts_guid.c > index 34dfd60..749591b 100644 > --- a/src/lib/src/fwts_guid.c > +++ b/src/lib/src/fwts_guid.c > @@ -21,6 +21,11 @@ > > #include "fwts.h" > > +/* > + * fwts_guid_buf_to_str() > + * format given GUID 'guid' into a string guid_str. > + * guid_str needs to be at least 37 chars long > + */ > void fwts_guid_buf_to_str(uint8_t *guid, char *guid_str, size_t guid_str_len) > { > if (guid_str&& guid_str_len> 36) Hi Colin, When I applied the patch, it occurred: Applying: lib: fwts_guid.c: add more comments /home/ivanhu/fwts/.git/rebase-apply/patch:15: trailing whitespace. * format given GUID 'guid' into a string guid_str. warning: 1 line adds whitespace errors. It seems that there are a trailing whitespace in the comments. Should we remove this warning? Best regards, Ivan
On Fri, May 25, 2012 at 6:40 PM, Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > src/lib/src/fwts_guid.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/src/lib/src/fwts_guid.c b/src/lib/src/fwts_guid.c > index 34dfd60..749591b 100644 > --- a/src/lib/src/fwts_guid.c > +++ b/src/lib/src/fwts_guid.c > @@ -21,6 +21,11 @@ > > #include "fwts.h" > > +/* > + * fwts_guid_buf_to_str() > + * format given GUID 'guid' into a string guid_str. > + * guid_str needs to be at least 37 chars long > + */ > void fwts_guid_buf_to_str(uint8_t *guid, char *guid_str, size_t guid_str_len) > { > if (guid_str && guid_str_len > 36) > -- > 1.7.10 > Acked-by: Keng-Yu Lin <kengyu@canonical.com>
On 31/05/12 05:38, IvanHu wrote: > On 05/25/2012 06:40 PM, Colin King wrote: >> From: Colin Ian King<colin.king@canonical.com> >> >> Signed-off-by: Colin Ian King<colin.king@canonical.com> >> --- >> src/lib/src/fwts_guid.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/src/lib/src/fwts_guid.c b/src/lib/src/fwts_guid.c >> index 34dfd60..749591b 100644 >> --- a/src/lib/src/fwts_guid.c >> +++ b/src/lib/src/fwts_guid.c >> @@ -21,6 +21,11 @@ >> >> #include "fwts.h" >> >> +/* >> + * fwts_guid_buf_to_str() >> + * format given GUID 'guid' into a string guid_str. >> + * guid_str needs to be at least 37 chars long >> + */ >> void fwts_guid_buf_to_str(uint8_t *guid, char *guid_str, size_t >> guid_str_len) >> { >> if (guid_str&& guid_str_len> 36) > > Hi Colin, > > When I applied the patch, it occurred: > > Applying: lib: fwts_guid.c: add more comments > /home/ivanhu/fwts/.git/rebase-apply/patch:15: trailing whitespace. > * format given GUID 'guid' into a string guid_str. > warning: 1 line adds whitespace errors. > It seems that there are a trailing whitespace in the comments. Should we > remove this warning? > > > Best regards, > Ivan Good catch. So generally such patches should be rejected if we conform to the rigid kernel source patching policy. For something like this one can either: 1. NACK my patch and I re-work it. 2. Or you just remove the trailing white space on my patch and re-apply it 3. Or just apply it and I will someday go through all the source and find stupid trailing white spaces and fix them all up in one go. Colin
On 05/25/2012 06:40 PM, Colin King wrote: > From: Colin Ian King<colin.king@canonical.com> > > Signed-off-by: Colin Ian King<colin.king@canonical.com> > --- > src/lib/src/fwts_guid.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/src/lib/src/fwts_guid.c b/src/lib/src/fwts_guid.c > index 34dfd60..749591b 100644 > --- a/src/lib/src/fwts_guid.c > +++ b/src/lib/src/fwts_guid.c > @@ -21,6 +21,11 @@ > > #include "fwts.h" > > +/* > + * fwts_guid_buf_to_str() > + * format given GUID 'guid' into a string guid_str. > + * guid_str needs to be at least 37 chars long > + */ > void fwts_guid_buf_to_str(uint8_t *guid, char *guid_str, size_t guid_str_len) > { > if (guid_str&& guid_str_len> 36) Acked-by: Ivan Hu<ivan.hu@canonical.com>
diff --git a/src/lib/src/fwts_guid.c b/src/lib/src/fwts_guid.c index 34dfd60..749591b 100644 --- a/src/lib/src/fwts_guid.c +++ b/src/lib/src/fwts_guid.c @@ -21,6 +21,11 @@ #include "fwts.h" +/* + * fwts_guid_buf_to_str() + * format given GUID 'guid' into a string guid_str. + * guid_str needs to be at least 37 chars long + */ void fwts_guid_buf_to_str(uint8_t *guid, char *guid_str, size_t guid_str_len) { if (guid_str && guid_str_len > 36)