Message ID | 1338298685-24429-1-git-send-email-colin.king@canonical.com |
---|---|
State | Accepted |
Headers | show |
On 05/29/2012 09:38 PM, Colin King wrote: > From: Colin Ian King<colin.king@canonical.com> > > Signed-off-by: Colin Ian King<colin.king@canonical.com> > --- > method-0001/method-0001.log | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/method-0001/method-0001.log b/method-0001/method-0001.log > index 57a9384..98d41a2 100644 > --- a/method-0001/method-0001.log > +++ b/method-0001/method-0001.log > @@ -59,10 +59,10 @@ method 05: INTEGER: 0x000001a4 > method 06: INTEGER: 0x0000009c > method 07: INTEGER: 0x00000108 > method 08: INTEGER: 0x00000ec4 > -method 09: STRING: 0xPA3465U > -method 10: STRING: 0x3658Q > -method 11: STRING: 0xLi-Ion > -method 12: STRING: 0xCOMPAL > +method 09: STRING: PA3465U > +method 10: STRING: 3658Q > +method 11: STRING: Li-Ion > +method 12: STRING: COMPAL > method PASSED: Test 12, Battery _BIF package looks sane. > method PASSED: Test 12, \_SB_.PCI0.LPCB.BAT1._BIF correctly > method acquired and released locks 6 times. Hi Colin, When I applied the patch, it said ================================= /home/alexhung/src/fwts-test/.git/rebase-apply/patch:17: trailing whitespace. method 09: STRING: PA3465U /home/alexhung/src/fwts-test/.git/rebase-apply/patch:20: trailing whitespace. method 12: STRING: COMPAL warning: 2 lines add whitespace errors. ================================= I noticed the whitespace was there before applying this patch. Is the trailing whitespace intentional? Cheers, Alex Hung
On 29/05/12 15:23, Alex Hung wrote: > On 05/29/2012 09:38 PM, Colin King wrote: >> From: Colin Ian King<colin.king@canonical.com> >> >> Signed-off-by: Colin Ian King<colin.king@canonical.com> >> --- >> method-0001/method-0001.log | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/method-0001/method-0001.log b/method-0001/method-0001.log >> index 57a9384..98d41a2 100644 >> --- a/method-0001/method-0001.log >> +++ b/method-0001/method-0001.log >> @@ -59,10 +59,10 @@ method 05: INTEGER: 0x000001a4 >> method 06: INTEGER: 0x0000009c >> method 07: INTEGER: 0x00000108 >> method 08: INTEGER: 0x00000ec4 >> -method 09: STRING: 0xPA3465U >> -method 10: STRING: 0x3658Q >> -method 11: STRING: 0xLi-Ion >> -method 12: STRING: 0xCOMPAL >> +method 09: STRING: PA3465U >> +method 10: STRING: 3658Q >> +method 11: STRING: Li-Ion >> +method 12: STRING: COMPAL >> method PASSED: Test 12, Battery _BIF package looks sane. >> method PASSED: Test 12, \_SB_.PCI0.LPCB.BAT1._BIF correctly >> method acquired and released locks 6 times. > > Hi Colin, > > When I applied the patch, it said > ================================= > /home/alexhung/src/fwts-test/.git/rebase-apply/patch:17: trailing > whitespace. > method 09: STRING: PA3465U > /home/alexhung/src/fwts-test/.git/rebase-apply/patch:20: trailing > whitespace. > method 12: STRING: COMPAL > warning: 2 lines add whitespace errors. > ================================= > I noticed the whitespace was there before applying this patch. Is the > trailing whitespace intentional? The white spaces are most probably because I'm outputting exactly what the _BIF package is reporting, hence the log captures this. Since we want to compare the log with the output of fwts, I think we should keep them in for now. Colin > > Cheers, > Alex Hung >
On 05/29/2012 09:38 PM, Colin King wrote: > From: Colin Ian King<colin.king@canonical.com> > > Signed-off-by: Colin Ian King<colin.king@canonical.com> > --- > method-0001/method-0001.log | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/method-0001/method-0001.log b/method-0001/method-0001.log > index 57a9384..98d41a2 100644 > --- a/method-0001/method-0001.log > +++ b/method-0001/method-0001.log > @@ -59,10 +59,10 @@ method 05: INTEGER: 0x000001a4 > method 06: INTEGER: 0x0000009c > method 07: INTEGER: 0x00000108 > method 08: INTEGER: 0x00000ec4 > -method 09: STRING: 0xPA3465U > -method 10: STRING: 0x3658Q > -method 11: STRING: 0xLi-Ion > -method 12: STRING: 0xCOMPAL > +method 09: STRING: PA3465U > +method 10: STRING: 3658Q > +method 11: STRING: Li-Ion > +method 12: STRING: COMPAL > method PASSED: Test 12, Battery _BIF package looks sane. > method PASSED: Test 12, \_SB_.PCI0.LPCB.BAT1._BIF correctly > method acquired and released locks 6 times. Acked-by: Alex Hung <alex.hung@canonical.com>
On Tue, May 29, 2012 at 9:38 PM, Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > method-0001/method-0001.log | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/method-0001/method-0001.log b/method-0001/method-0001.log > index 57a9384..98d41a2 100644 > --- a/method-0001/method-0001.log > +++ b/method-0001/method-0001.log > @@ -59,10 +59,10 @@ method 05: INTEGER: 0x000001a4 > method 06: INTEGER: 0x0000009c > method 07: INTEGER: 0x00000108 > method 08: INTEGER: 0x00000ec4 > -method 09: STRING: 0xPA3465U > -method 10: STRING: 0x3658Q > -method 11: STRING: 0xLi-Ion > -method 12: STRING: 0xCOMPAL > +method 09: STRING: PA3465U > +method 10: STRING: 3658Q > +method 11: STRING: Li-Ion > +method 12: STRING: COMPAL > method PASSED: Test 12, Battery _BIF package looks sane. > method PASSED: Test 12, \_SB_.PCI0.LPCB.BAT1._BIF correctly > method acquired and released locks 6 times. > -- > 1.7.10 > Acked-by: Keng-Yu Lin <kengyu@canonical.com>
On 05/29/2012 09:38 PM, Colin King wrote: > From: Colin Ian King<colin.king@canonical.com> > > Signed-off-by: Colin Ian King<colin.king@canonical.com> > --- > method-0001/method-0001.log | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/method-0001/method-0001.log b/method-0001/method-0001.log > index 57a9384..98d41a2 100644 > --- a/method-0001/method-0001.log > +++ b/method-0001/method-0001.log > @@ -59,10 +59,10 @@ method 05: INTEGER: 0x000001a4 > method 06: INTEGER: 0x0000009c > method 07: INTEGER: 0x00000108 > method 08: INTEGER: 0x00000ec4 > -method 09: STRING: 0xPA3465U > -method 10: STRING: 0x3658Q > -method 11: STRING: 0xLi-Ion > -method 12: STRING: 0xCOMPAL > +method 09: STRING: PA3465U > +method 10: STRING: 3658Q > +method 11: STRING: Li-Ion > +method 12: STRING: COMPAL > method PASSED: Test 12, Battery _BIF package looks sane. > method PASSED: Test 12, \_SB_.PCI0.LPCB.BAT1._BIF correctly > method acquired and released locks 6 times. Acked-by: Ivan Hu<ivan.hu@canonical.com>
diff --git a/method-0001/method-0001.log b/method-0001/method-0001.log index 57a9384..98d41a2 100644 --- a/method-0001/method-0001.log +++ b/method-0001/method-0001.log @@ -59,10 +59,10 @@ method 05: INTEGER: 0x000001a4 method 06: INTEGER: 0x0000009c method 07: INTEGER: 0x00000108 method 08: INTEGER: 0x00000ec4 -method 09: STRING: 0xPA3465U -method 10: STRING: 0x3658Q -method 11: STRING: 0xLi-Ion -method 12: STRING: 0xCOMPAL +method 09: STRING: PA3465U +method 10: STRING: 3658Q +method 11: STRING: Li-Ion +method 12: STRING: COMPAL method PASSED: Test 12, Battery _BIF package looks sane. method PASSED: Test 12, \_SB_.PCI0.LPCB.BAT1._BIF correctly method acquired and released locks 6 times.