[U-Boot,v5,5/5] Kirkwood: add lschlv2 and lsxhl board support

This patch adds support for both the Linkstation Live (LS-CHLv2) and
Linkstation Pro (LS-XHL) by Buffalo.

Signed-off-by: Michael Walle <michael@walle.cc>
Cc: Prafulla Wadaskar <prafulla@marvell.com>
---
 MAINTAINERS                           |    5 +
 board/buffalo/lsxl/Makefile           |   50 ++++++
 board/buffalo/lsxl/kwbimage-lschl.cfg |  229 +++++++++++++++++++++++++
 board/buffalo/lsxl/kwbimage-lsxhl.cfg |  229 +++++++++++++++++++++++++
 board/buffalo/lsxl/lsxl.c             |  302 +++++++++++++++++++++++++++++++++
 board/buffalo/lsxl/lsxl.h             |   75 ++++++++
 boards.cfg                            |    2 +
 include/configs/lsxl.h                |  182 ++++++++++++++++++++
 8 files changed, 1074 insertions(+), 0 deletions(-)
 create mode 100644 board/buffalo/lsxl/Makefile
 create mode 100644 board/buffalo/lsxl/kwbimage-lschl.cfg
 create mode 100644 board/buffalo/lsxl/kwbimage-lsxhl.cfg
 create mode 100644 board/buffalo/lsxl/lsxl.c
 create mode 100644 board/buffalo/lsxl/lsxl.h
 create mode 100644 include/configs/lsxl.h

[sorry my first mail didn't have 'Kirkwood' in the subject]

> This patch adds support for both the Linkstation Live (LS-CHLv2) and
> Linkstation Pro (LS-XHL) by Buffalo.

Am Freitag 11 Mai 2012, 18:51:09 schrieb Prafulla Wadaskar:
> I will check on this patch in this week end since I am travelling.

Hi Prafulla,

did you find the time to review the arm/board specific patches in this series 
(http://patchwork.ozlabs.org/patch/158627/)?

> -----Original Message-----
> From: Michael Walle [mailto:michael@walle.cc]
> Sent: 23 May 2012 02:28
> To: u-boot@lists.denx.de
> Cc: Prafulla Wadaskar
> Subject: Re: [PATCH v5 5/5] Kirkwood: add lschlv2 and lsxhl board
> support
> 
> 
> [sorry my first mail didn't have 'Kirkwood' in the subject]
> 
> > This patch adds support for both the Linkstation Live (LS-CHLv2) and
> > Linkstation Pro (LS-XHL) by Buffalo.
> 
> Am Freitag 11 Mai 2012, 18:51:09 schrieb Prafulla Wadaskar:
> > I will check on this patch in this week end since I am travelling.
> 
> Hi Prafulla,
> 
> did you find the time to review the arm/board specific patches in this
> series
> (http://patchwork.ozlabs.org/patch/158627/)?

I will do it on this weekend

Regards..
Prafulla . . .

> -----Original Message-----
> From: Michael Walle [mailto:michael@walle.cc]
> Sent: 12 May 2012 04:21
> To: u-boot@lists.denx.de
> Cc: Prafulla Wadaskar; Wolfgang Denk; Mike Frysinger; Joe Hershberger;
> Michael Walle
> Subject: [PATCH v5 5/5] Kirkwood: add lschlv2 and lsxhl board support
>
> This patch adds support for both the Linkstation Live (LS-CHLv2) and
> Linkstation Pro (LS-XHL) by Buffalo.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
> Cc: Prafulla Wadaskar <prafulla@marvell.com>
> ---
>  MAINTAINERS                           |    5 +
>  board/buffalo/lsxl/Makefile           |   50 ++++++
>  board/buffalo/lsxl/kwbimage-lschl.cfg |  229
> +++++++++++++++++++++++++
>  board/buffalo/lsxl/kwbimage-lsxhl.cfg |  229
> +++++++++++++++++++++++++

BTW: These two file looks similar, what is the difference?

>  board/buffalo/lsxl/lsxl.c             |  302
> +++++++++++++++++++++++++++++++++
>  board/buffalo/lsxl/lsxl.h             |   75 ++++++++
>  boards.cfg                            |    2 +
>  include/configs/lsxl.h                |  182 ++++++++++++++++++++
>  8 files changed, 1074 insertions(+), 0 deletions(-)
>  create mode 100644 board/buffalo/lsxl/Makefile
>  create mode 100644 board/buffalo/lsxl/kwbimage-lschl.cfg
>  create mode 100644 board/buffalo/lsxl/kwbimage-lsxhl.cfg
>  create mode 100644 board/buffalo/lsxl/lsxl.c
>  create mode 100644 board/buffalo/lsxl/lsxl.h
>  create mode 100644 include/configs/lsxl.h
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e2441d8..929ba6f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -894,6 +894,11 @@ Prafulla Wadaskar <prafulla@marvell.com>
>       rd6281a         ARM926EJS (Kirkwood SoC)
>       sheevaplug      ARM926EJS (Kirkwood SoC)
>
> +Michael Walle <michael@walle.cc>
> +
> +     lschlv2         ARM926EJS (Kirkwood SoC)
> +     lsxhl           ARM926EJS (Kirkwood SoC)
> +
>  Tom Warren <twarren@nvidia.com>
>
>       harmony         Tegra2 (ARM7 & A9 Dual Core)
> diff --git a/board/buffalo/lsxl/Makefile b/board/buffalo/lsxl/Makefile
> new file mode 100644
> index 0000000..d06c882
> --- /dev/null
> +++ b/board/buffalo/lsxl/Makefile
> @@ -0,0 +1,50 @@
> +#
> +# Copyright (c) 2012 Michael Walle
> +# Michael Walle <michael@walle.cc>
> +#
> +# See file CREDITS for list of people who contributed to this
> +# project.
> +#
> +# This program is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU General Public License as
> +# published by the Free Software Foundation; either version 2 of
> +# the License, or (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.        See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write to the Free Software
> +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
> +# MA 02110-1301 USA
> +#
> +
> +include $(TOPDIR)/config.mk
> +
> +LIB  = $(obj)lib$(BOARD).o
> +
> +COBJS        := lsxl.o
> +
> +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c)
> +OBJS := $(addprefix $(obj),$(COBJS))
> +SOBJS        := $(addprefix $(obj),$(SOBJS))
> +
> +$(LIB):      $(obj).depend $(OBJS) $(SOBJS)
> +     $(call cmd_link_o_target, $(OBJS) $(SOBJS))
> +
> +clean:
> +     rm -f $(SOBJS) $(OBJS)
> +
> +distclean:   clean
> +     rm -f $(LIB) core *.bak .depend
> +
> +#####################################################################
> ####
> +
> +# defines $(obj).depend target
> +include $(SRCTREE)/rules.mk
> +
> +sinclude $(obj).depend
> +
> +#####################################################################
> ####
> diff --git a/board/buffalo/lsxl/kwbimage-lschl.cfg
> b/board/buffalo/lsxl/kwbimage-lschl.cfg
> new file mode 100644
> index 0000000..2b9b3cd
> --- /dev/null
> +++ b/board/buffalo/lsxl/kwbimage-lschl.cfg
> @@ -0,0 +1,229 @@
> +#
> +# Copyright (c) 2012 Michael Walle
> +# Michael Walle <michael@walle.cc>
> +#
> +# See file CREDITS for list of people who contributed to this
> +# project.
> +#
> +# This program is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU General Public License as
> +# published by the Free Software Foundation; either version 2 of
> +# the License, or (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write to the Free Software
> +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
> +# MA 02110-1301 USA
> +#
> +# Refer docs/README.kwimage for more details about how-to configure
> +# and create kirkwood boot image
> +#
> +
> +# Boot Media configurations
> +BOOT_FROM spi
> +
> +# SOC registers configuration using bootrom header extension
> +# Maximum KWBIMAGE_MAX_CONFIG configurations allowed
> +
> +# Configure RGMII-0/1 interface pad voltage to 1.8V
> +DATA 0xFFD100E0 0x1B1B1B9B
> +
> +# L2 RAM Timing 0
> +DATA 0xFFD20134 0xBBBBBBBB
> +# not further specified in HW manual, timing taken from original
> vendor port
> +
> +# L2 RAM Timing 1
> +DATA 0xFFD20138 0x00BBBBBB
> +# not further specified in HW manual, timing taken from original
> vendor port
> +
> +# DDR Configuration register
> +DATA 0xFFD01400 0x43000618
> +# bit13-0:  0x618, 1560 DDR2 clks refresh rate
> +# bit23-14: 0 required
> +# bit24:    1, enable exit self refresh mode on DDR access
> +# bit25:    1 required
> +# bit29-26: 0 required
> +# bit31-30: 0b01 required
> +
> +# DDR Controller Control Low
> +DATA 0xFFD01404 0x39543000
> +# bit3-0:   0 required
> +# bit4:     0, addr/cmd in same cycle
> +# bit5:     0, clk is driven during self refresh, we don't care for
> APX
> +# bit6:     0, use recommended falling edge of clk for addr/cmd
> +# bit11-7:  0 required
> +# bit12:    1 required
> +# bit13:    1 required
> +# bit14:    0, input buffer always powered up
> +# bit17-15: 0 required
> +# bit18:    1, cpu lock transaction enabled
> +# bit19:    0 required
> +# bit23-20: 5, recommended value for CL=5 and STARTBURST_DEL disabled
> bit31=0
> +# bit27-24: 9, CL+4, STARTBURST sample stages, for freqs 400MHz,
> unbuffered DIMM
> +# bit30-28: 3 required
> +# bit31:    0, no additional STARTBURST delay
> +
> +# DDR Timing (Low)
> +DATA 0xFFD01408 0x3302444F
> +# bit3-0:   0xf, 16 cycle tRAS (tRAS[3-0])
> +# bit7-4:   4, 5 cycle tRCD
> +# bit11-8:  4, 5 cyle tRP
> +# bit15-12: 4, 5 cyle tWR
> +# bit19-16: 2, 3 cyle tWTR
> +# bit20:    0, 16 cycle tRAS (tRAS[4])
> +# bit23-21: 0 required
> +# bit27-24: 3, 4 cycle tRRD
> +# bit31-28: 3, 4 cyle tRTP
> +
> +# DDR Timing (High)
> +DATA 0xFFD0140C 0x00000823
> +# bit6-0:   0x23, 35 cycle tRFC
> +# bit8-7:   0, 1 cycle tR2R
> +# bit10-9:  0, 1 cyle tR2W
> +# bit12-11: 1, 2 cylce tW2W
> +# bit31-13: 0 required
> +
> +# DDR Address Control
> +DATA 0xFFD01410 0x00000009
> +# bit1-0:   1, Cs0width=x16
> +# bit3-2:   2, Cs0size=512Mbit
> +# bit5-4:   0, Cs1width=nonexistent
> +# bit7-6:   0, Cs1size=nonexistent
> +# bit9-8:   0, Cs2width=nonexistent
> +# bit11-10: 0, Cs2size=nonexistent
> +# bit13-12: 0, Cs3width=nonexistent
> +# bit15-14: 0, Cs3size=nonexistent
> +# bit16:    0, Cs0AddrSel
> +# bit17:    0, Cs1AddrSel
> +# bit18:    0, Cs2AddrSel
> +# bit19:    0, Cs3AddrSel
> +# bit31-20: 0 required
> +
> +# DDR Open Pages Control
> +DATA 0xFFD01414 0x00000000
> +# bit0:    0, OPEn=OpenPage enabled
> +# bit31-1: 0 required
> +
> +# DDR Operation
> +DATA 0xFFD01418 0x00000000
> +# bit3-0:   0, Cmd=Normal SDRAM Mode
> +# bit31-4:  0 required
> +
> +# DDR Mode
> +DATA 0xFFD0141C 0x00000652
> +# bit2-0:   2, Burst Length (2 required)
> +# bit3:     0, Burst Type (0 required)
> +# bit6-4:   5, CAS Latency (CL) 5
> +# bit7:     0, (Test Mode) Normal operation
> +# bit8:     0, (Reset DLL) Normal operation
> +# bit11-9:  3, Write recovery for auto-precharge (3 required)
> +# bit12:    0, Fast Active power down exit time (0 required)
> +# bit31-13: 0 required
> +
> +# DDR Extended Mode
> +DATA 0xFFD01420 0x00000042
> +# bit0:     0, DRAM DLL enabled
> +# bit1:     1, DRAM drive strength reduced
> +# bit2:     0, ODT control Rtt[0] (Rtt=2, 150 ohm termination)
> +# bit5-3:   0 required
> +# bit6:     1, ODT control Rtt[1] (Rtt=2, 150 ohm termination)
> +# bit9-7:   0 required
> +# bit10:    0, differential DQS enabled
> +# bit11:    0 required
> +# bit12:    0, DRAM output buffer enabled
> +# bit31-13: 0 required
> +
> +# DDR Controller Control High
> +DATA 0xFFD01424 0x0000F17F
> +# bit2-0:   0x7 required
> +# bit3:     1, MBUS Burst Chop disabled
> +# bit6-4:   0x7 required
> +# bit7:     0 required (???)
> +# bit8:     1, add writepath sample stage, must be 1 for DDR freq >=
> 300MHz
> +# bit9:     0, no half clock cycle addition to dataout
> +# bit10:    0, 1/4 clock cycle skew enabled for addr/ctl signals
> +# bit11:    0, 1/4 clock cycle skew disabled for write mesh
> +# bit15-12: 0xf required
> +# bit31-16: 0 required
> +
> +# DDR2 ODT Read Timing (default values)
> +DATA 0xFFD01428 0x00085520
> +# bit3-0:   0 required
> +# bit7-4:   2, 2 cycles from read command to assertion of M_ODT
> signal
> +# bit11-8:  5, 5 cycles from read command to de-assertion of M_ODT
> signal
> +# bit15-12: 5, 5 cycles from read command to assertion of internal
> ODT signal
> +# bit19-16: 8, 8 cycles from read command to de-assertion of internal
> ODT signal
> +# bit31-20: 0 required
> +
> +# DDR2 ODT Write Timing (default values)
> +DATA 0xFFD0147C 0x00008552
> +# bit3-0:   2, 2 cycles from write comand to assertion of M_ODT
> signal
> +# bit7-4:   5, 5 cycles from write command to de-assertion of M_ODT
> signal
> +# bit15-12: 5, 5 cycles from write command to assertion of internal
> ODT signal
> +# bit19-16: 8, 8 cycles from write command to de-assertion of
> internal ODT signal
> +# bit31-16: 0 required
> +
> +# CS[0]n Base address
> +DATA 0xFFD01500 0x00000000
> +# at 0x0
> +
> +# CS[0]n Size
> +DATA 0xFFD01504 0x03FFFFF1
> +# bit0:     1, Window enabled
> +# bit1:     0, Write Protect disabled
> +# bit3-2:   0x0, CS0 hit selected
> +# bit23-4:  0xfffff required
> +# bit31-24: 0x03, Size (i.e. 64MB)
> +
> +# CS[1]n Size
> +DATA 0xFFD0150C 0x00000000
> +# window disabled
> +
> +# CS[2]n Size
> +DATA 0xFFD01514 0x00000000
> +# window disabled
> +
> +# CS[3]n Size
> +DATA 0xFFD0151C 0x00000000
> +# window disabled
> +
> +# DDR ODT Control (Low)
> +DATA 0xFFD01494 0x003C0000
> +# bit3-0:   0b0000, (read) M_ODT[0] is not asserted during read from
> DRAM
> +# bit7-4:   0b0000, (read) M_ODT[1] is not asserted during read from
> DRAM
> +# bit15-8:  0 required
> +# bit19-16: 0b1100, (write) M_ODT[0] is asserted during write to DRAM
> CS2, CS3
> +# bit23-20: 0b0011, (write) M_ODT[1] is asserted during write to DRAM
> CS0, CS1
> +# bit31-24: 0 required
> +
> +# DDR ODT Control (High)
> +DATA 0xFFD01498 0x00000000
> +# bit1-0:   0, M_ODT[0] assertion is controlled by ODT Control Low
> register
> +# bit3-2:   0, M_ODT[1] assertion is controlled by ODT Control Low
> register
> +# bit31-4   0 required
> +
> +# CPU ODT Control
> +DATA 0xFFD0149C 0x0000E80F
> +# bit3-0:   0b1111, internal ODT is asserted during read from DRAM
> bank 0-3
> +# bit7-4:   0b0000, internal ODT is not asserted during write to DRAM
> bank 0-3
> +# bit9-8:   0, Internal ODT assertion is controlled by fiels
> +# bit11-10: 2, M_DQ, M_DM, and M_DQS I/O buffer ODT 75 ohm
> +# bit13-12: 2, M_STARTBURST_IN I/O buffer ODT 75 ohm
> +# bit14:    1, M_STARTBURST_IN ODT enabled
> +# bit15:    1, DDR IO ODT Unit: Drive ODT calibration values
> +# bit20-16: 0, Pad N channel driving strength for ODT
> +# bit25-21: 0, Pad P channel driving strength for ODT
> +# bit31-26: 0 required
> +
> +# DDR Initialization Control
> +DATA 0xFFD01480 0x00000001
> +# bit0:     1, enable DDR init upon this register write
> +# bit31-1:  0, required
> +
> +# End of Header extension
> +DATA 0x0 0x0
> diff --git a/board/buffalo/lsxl/kwbimage-lsxhl.cfg
> b/board/buffalo/lsxl/kwbimage-lsxhl.cfg
> new file mode 100644
> index 0000000..8a94b6c
> --- /dev/null
> +++ b/board/buffalo/lsxl/kwbimage-lsxhl.cfg
> @@ -0,0 +1,229 @@
> +#
> +# Copyright (c) 2012 Michael Walle
> +# Michael Walle <michael@walle.cc>
> +#
> +# See file CREDITS for list of people who contributed to this
> +# project.
> +#
> +# This program is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU General Public License as
> +# published by the Free Software Foundation; either version 2 of
> +# the License, or (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write to the Free Software
> +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
> +# MA 02110-1301 USA
> +#
> +# Refer docs/README.kwimage for more details about how-to configure
> +# and create kirkwood boot image
> +#
> +
> +# Boot Media configurations
> +BOOT_FROM spi
> +
> +# SOC registers configuration using bootrom header extension
> +# Maximum KWBIMAGE_MAX_CONFIG configurations allowed
> +
> +# Configure RGMII-0/1 interface pad voltage to 1.8V
> +DATA 0xFFD100E0 0x1B1B9B9B
> +
> +# L2 RAM Timing 0
> +DATA 0xFFD20134 0xBBBBBBBB
> +# not further specified in HW manual, timing taken from original
> vendor port
> +
> +# L2 RAM Timing 1
> +DATA 0xFFD20138 0x00BBBBBB
> +# not further specified in HW manual, timing taken from original
> vendor port
> +
> +# DDR Configuration register
> +DATA 0xFFD01400 0x43000618
> +# bit13-0:  0x618, 1560 DDR2 clks refresh rate
> +# bit23-14: 0 required
> +# bit24:    1, enable exit self refresh mode on DDR access
> +# bit25:    1 required
> +# bit29-26: 0 required
> +# bit31-30: 0b01 required
> +
> +# DDR Controller Control Low
> +DATA 0xFFD01404 0x39543010
> +# bit3-0:   0 required
> +# bit4:     1, T2 mode, addr/cmd are driven for two cycles
> +# bit5:     0, clk is driven during self refresh, we don't care for
> APX
> +# bit6:     0, use recommended falling edge of clk for addr/cmd
> +# bit11-7:  0 required
> +# bit12:    1 required
> +# bit13:    1 required
> +# bit14:    0, input buffer always powered up
> +# bit17-15: 0 required
> +# bit18:    1, cpu lock transaction enabled
> +# bit19:    0 required
> +# bit23-20: 5, recommended value for CL=5 and STARTBURST_DEL disabled
> bit31=0
> +# bit27-24: 9, CL+4, STARTBURST sample stages, for freqs 400MHz,
> unbuffered DIMM
> +# bit30-28: 3 required
> +# bit31:    0, no additional STARTBURST delay
> +
> +# DDR Timing (Low)
> +DATA 0xFFD01408 0x22125441
> +# bit3-0:   0x1, 18 cycle tRAS (tRAS[3-0])
> +# bit7-4:   4, 5 cycle tRCD
> +# bit11-8:  4, 5 cyle tRP
> +# bit15-12: 5, 6 cyle tWR
> +# bit19-16: 2, 3 cyle tWTR
> +# bit20:    1, 18 cycle tRAS (tRAS[4])
> +# bit23-21: 0 required
> +# bit27-24: 2, 3 cycle tRRD
> +# bit31-28: 2, 3 cyle tRTP
> +
> +# DDR Timing (High)
> +DATA 0xFFD0140C 0x00000832
> +# bit6-0:   0x32, 50 cycle tRFC
> +# bit8-7:   0, 1 cycle tR2R
> +# bit10-9:  0, 1 cyle tR2W
> +# bit12-11: 1, 2 cylce tW2W
> +# bit31-13: 0 required
> +
> +# DDR Address Control
> +DATA 0xFFD01410 0x0000000C
> +# bit1-0:   0, Cs0width=x8
> +# bit3-2:   3, Cs0size=1Gbit
> +# bit5-4:   0, Cs1width=nonexistent
> +# bit7-6:   0, Cs1size=nonexistent
> +# bit9-8:   0, Cs2width=nonexistent
> +# bit11-10: 0, Cs2size=nonexistent
> +# bit13-12: 0, Cs3width=nonexistent
> +# bit15-14: 0, Cs3size=nonexistent
> +# bit16:    0, Cs0AddrSel
> +# bit17:    0, Cs1AddrSel
> +# bit18:    0, Cs2AddrSel
> +# bit19:    0, Cs3AddrSel
> +# bit31-20: 0 required
> +
> +# DDR Open Pages Control
> +DATA 0xFFD01414 0x00000000
> +# bit0:    0, OPEn=OpenPage enabled
> +# bit31-1: 0 required
> +
> +# DDR Operation
> +DATA 0xFFD01418 0x00000000
> +# bit3-0:   0, Cmd=Normal SDRAM Mode
> +# bit31-4:  0 required
> +
> +# DDR Mode
> +DATA 0xFFD0141C 0x00000652
> +# bit2-0:   2, Burst Length (2 required)
> +# bit3:     0, Burst Type (0 required)
> +# bit6-4:   5, CAS Latency (CL) 5
> +# bit7:     0, (Test Mode) Normal operation
> +# bit8:     0, (Reset DLL) Normal operation
> +# bit11-9:  3, Write recovery for auto-precharge (3 required)
> +# bit12:    0, Fast Active power down exit time (0 required)
> +# bit31-13: 0 required
> +
> +# DDR Extended Mode
> +DATA 0xFFD01420 0x00000006
> +# bit0:     0, DRAM DLL enabled
> +# bit1:     1, DRAM drive strength reduced
> +# bit2:     1, ODT control Rtt[0] (Rtt=1, 75 ohm termination)
> +# bit5-3:   0 required
> +# bit6:     0, ODT control Rtt[1] (Rtt=1, 75 ohm termination)
> +# bit9-7:   0 required
> +# bit10:    0, differential DQS enabled
> +# bit11:    0 required
> +# bit12:    0, DRAM output buffer enabled
> +# bit31-13: 0 required
> +
> +# DDR Controller Control High
> +DATA 0xFFD01424 0x0000F17F
> +# bit2-0:   0x7 required
> +# bit3:     1, MBUS Burst Chop disabled
> +# bit6-4:   0x7 required
> +# bit7:     0 required (???)
> +# bit8:     1, add writepath sample stage, must be 1 for DDR freq >=
> 300MHz
> +# bit9:     0, no half clock cycle addition to dataout
> +# bit10:    0, 1/4 clock cycle skew enabled for addr/ctl signals
> +# bit11:    0, 1/4 clock cycle skew disabled for write mesh
> +# bit15-12: 0xf required
> +# bit31-16: 0 required
> +
> +# DDR2 ODT Read Timing (default values)
> +DATA 0xFFD01428 0x00085520
> +# bit3-0:   0 required
> +# bit7-4:   2, 2 cycles from read command to assertion of M_ODT
> signal
> +# bit11-8:  5, 5 cycles from read command to de-assertion of M_ODT
> signal
> +# bit15-12: 5, 5 cycles from read command to assertion of internal
> ODT signal
> +# bit19-16: 8, 8 cycles from read command to de-assertion of internal
> ODT signal
> +# bit31-20: 0 required
> +
> +# DDR2 ODT Write Timing (default values)
> +DATA 0xFFD0147C 0x00008552
> +# bit3-0:   2, 2 cycles from write comand to assertion of M_ODT
> signal
> +# bit7-4:   5, 5 cycles from write command to de-assertion of M_ODT
> signal
> +# bit15-12: 5, 5 cycles from write command to assertion of internal
> ODT signal
> +# bit19-16: 8, 8 cycles from write command to de-assertion of
> internal ODT signal
> +# bit31-16: 0 required
> +
> +# CS[0]n Base address
> +DATA 0xFFD01500 0x00000000
> +# at 0x0
> +
> +# CS[0]n Size
> +DATA 0xFFD01504 0x0FFFFFF1
> +# bit0:     1, Window enabled
> +# bit1:     0, Write Protect disabled
> +# bit3-2:   0x0, CS0 hit selected
> +# bit23-4:  0xfffff required
> +# bit31-24: 0x0f, Size (i.e. 256MB)
> +
> +# CS[1]n Size
> +DATA 0xFFD0150C 0x00000000
> +# window disabled
> +
> +# CS[2]n Size
> +DATA 0xFFD01514 0x00000000
> +# window disabled
> +
> +# CS[3]n Size
> +DATA 0xFFD0151C 0x00000000
> +# window disabled
> +
> +# DDR ODT Control (Low)
> +DATA 0xFFD01494 0x00010000
> +# bit3-0:   0b0000, (read) M_ODT[0] is not asserted during read from
> DRAM
> +# bit7-4:   0b0000, (read) M_ODT[1] is not asserted during read from
> DRAM
> +# bit15-8:  0 required
> +# bit19-16: 0b0001, (write) M_ODT[0] is asserted during write to DRAM
> CS0
> +# bit23-20: 0b0000, (write) M_ODT[1] is not asserted during write to
> DRAM
> +# bit31-24: 0 required
> +
> +# DDR ODT Control (High)
> +DATA 0xFFD01498 0x00000000
> +# bit1-0:   0, M_ODT[0] assertion is controlled by ODT Control Low
> register
> +# bit3-2:   0, M_ODT[1] assertion is controlled by ODT Control Low
> register
> +# bit31-4   0 required
> +
> +# CPU ODT Control
> +DATA 0xFFD0149C 0x0000E80F
> +# bit3-0:   0b1111, internal ODT is asserted during read from DRAM
> bank 0-3
> +# bit7-4:   0b0000, internal ODT is not asserted during write to DRAM
> bank 0-3
> +# bit9-8:   0, Internal ODT assertion is controlled by fiels
> +# bit11-10: 2, M_DQ, M_DM, and M_DQS I/O buffer ODT 75 ohm
> +# bit13-12: 2, M_STARTBURST_IN I/O buffer ODT 75 ohm
> +# bit14:    1, M_STARTBURST_IN ODT enabled
> +# bit15:    1, DDR IO ODT Unit: Drive ODT calibration values
> +# bit20-16: 0, Pad N channel driving strength for ODT
> +# bit25-21: 0, Pad P channel driving strength for ODT
> +# bit31-26: 0 required
> +
> +# DDR Initialization Control
> +DATA 0xFFD01480 0x00000001
> +# bit0:     1, enable DDR init upon this register write
> +# bit31-1:  0, required
> +
> +# End of Header extension
> +DATA 0x0 0x0
> diff --git a/board/buffalo/lsxl/lsxl.c b/board/buffalo/lsxl/lsxl.c
> new file mode 100644
> index 0000000..603d11a
> --- /dev/null
> +++ b/board/buffalo/lsxl/lsxl.c
> @@ -0,0 +1,302 @@
> +/*
> + * Copyright (c) 2012 Michael Walle
> + * Michael Walle <michael@walle.cc>
> + *
> + * Based on sheevaplug/sheevaplug.c by
> + *   Marvell Semiconductor <www.marvell.com>
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
> + * MA 02110-1301 USA
> + */
> +
> +#include <common.h>
> +#include <net.h>
> +#include <malloc.h>
> +#include <netdev.h>
> +#include <miiphy.h>
> +#include <asm/arch/kirkwood.h>
> +#include <asm/arch/cpu.h>
> +#include <asm/arch/mpp.h>
> +#include <asm/arch/gpio.h>
> +#include <spi_flash.h>
> +
> +#include "lsxl.h"
> +
> +/*
> + * Rescue mode
> + *
> + * Selected by holding the push button for 3 seconds, while powering
> on
> + * the device.
> + *
> + * These linkstations don't have a (populated) serial port. There is
> no
> + * way to access an (unmodified) board other than using the
> netconsole. If
> + * you want to recover from a bad environment setting or an empty
> environment,
> + * you can do this only with a working network connection. Therefore,
> a random
> + * ethernet address is generated if none is set and a DHCP request is
> sent.
> + * After a successful DHCP response is received, the network settings
> are
> + * configured and the ncip parameter is set to the serverip. Eg. for
> a working
> + * resuce mode, you should set 'next-server' to the host where the
> netconsole
> + * client is started.
> + * Additionally, the bootsource is set to 'cli'.
> + */
> +
> +#ifndef CONFIG_ENV_OVERWRITE
> +# error "You need to set CONFIG_ENV_OVERWRITE"
> +#endif
> +
> +DECLARE_GLOBAL_DATA_PTR;
> +
> +int board_early_init_f(void)
> +{
> +     /*
> +      * default gpio configuration
> +      * There are maximum 64 gpios controlled through 2 sets of
> registers
> +      * the below configuration configures mainly initial LED status
> +      */
> +     kw_config_gpio(LSXL_OE_VAL_LOW,
> +                     LSXL_OE_VAL_HIGH,
> +                     LSXL_OE_LOW, LSXL_OE_HIGH);
> +
> +     /*
> +      * Multi-Purpose Pins Functionality configuration
> +      * These strappings are taken from the original vendor uboot port.
> +      */
> +     u32 kwmpp_config[] = {
> +             MPP0_SPI_SCn,
> +             MPP1_SPI_MOSI,
> +             MPP2_SPI_SCK,
> +             MPP3_SPI_MISO,
> +             MPP4_UART0_RXD,
> +             MPP5_UART0_TXD,
> +             MPP6_SYSRST_OUTn,
> +             MPP7_GPO,
> +             MPP8_GPIO,
> +             MPP9_GPIO,
> +             MPP10_GPO,              /* HDD power */
> +             MPP11_GPIO,             /* USB Vbus enable */
> +             MPP12_SD_CLK,
> +             MPP13_SD_CMD,
> +             MPP14_SD_D0,
> +             MPP15_SD_D1,
> +             MPP16_SD_D2,
> +             MPP17_SD_D3,
> +             MPP18_GPO,              /* fan speed high */
> +             MPP19_GPO,              /* fan speed low */
> +             MPP20_GE1_0,
> +             MPP21_GE1_1,
> +             MPP22_GE1_2,
> +             MPP23_GE1_3,
> +             MPP24_GE1_4,
> +             MPP25_GE1_5,
> +             MPP26_GE1_6,
> +             MPP27_GE1_7,
> +             MPP28_GPIO,
> +             MPP29_GPIO,
> +             MPP30_GE1_10,
> +             MPP31_GE1_11,
> +             MPP32_GE1_12,
> +             MPP33_GE1_13,
> +             MPP34_GPIO,
> +             MPP35_GPIO,
> +             MPP36_GPIO,             /* function LED */
> +             MPP37_GPIO,             /* alarm LED */
> +             MPP38_GPIO,             /* info LED */
> +             MPP39_GPIO,             /* power LED */
> +             MPP40_GPIO,             /* fan alarm */
> +             MPP41_GPIO,             /* funtion button */
> +             MPP42_GPIO,             /* power switch */
> +             MPP43_GPIO,             /* power auto switch */
> +             MPP44_GPIO,
> +             MPP45_GPIO,
> +             MPP46_GPIO,
> +             MPP47_GPIO,
> +             MPP48_GPIO,             /* function red LED */
> +             MPP49_GPIO,
> +             0
> +     };
> +
> +     kirkwood_mpp_conf(kwmpp_config);
> +
> +     return 0;
> +}
> +
> +#define LED_OFF             0
> +#define LED_ALARM_ON        1
> +#define LED_ALARM_BLINKING  2
> +#define LED_POWER_ON        3
> +#define LED_POWER_BLINKING  4
> +#define LED_INFO_ON         5
> +#define LED_INFO_BLINKING   6
> +
> +static void __set_led(int blink_alarm, int blink_info, int
> blink_power,
> +             int value_alarm, int value_info, int value_power)
> +{
> +     kw_gpio_set_blink(GPIO_ALARM_LED, blink_alarm);
> +     kw_gpio_set_blink(GPIO_INFO_LED, blink_info);
> +     kw_gpio_set_blink(GPIO_POWER_LED, blink_power);
> +     kw_gpio_set_value(GPIO_ALARM_LED, value_alarm);
> +     kw_gpio_set_value(GPIO_INFO_LED, value_info);
> +     kw_gpio_set_value(GPIO_POWER_LED, value_power);
> +}
> +
> +static void set_led(int state)
> +{
> +     switch (state) {
> +     case LED_OFF:
> +             __set_led(0, 0, 0, 0, 0, 0);
> +             break;
> +     case LED_ALARM_ON:
> +             __set_led(0, 0, 0, 0, 1, 1);
> +             break;
> +     case LED_ALARM_BLINKING:
> +             __set_led(1, 0, 0, 1, 1, 1);
> +             break;
> +     case LED_INFO_ON:
> +             __set_led(0, 0, 0, 1, 0, 1);
> +             break;
> +     case LED_INFO_BLINKING:
> +             __set_led(0, 1, 0, 1, 1, 1);
> +             break;
> +     case LED_POWER_ON:
> +             __set_led(0, 0, 0, 1, 1, 0);
> +             break;
> +     case LED_POWER_BLINKING:
> +             __set_led(0, 0, 1, 1, 1, 1);
> +             break;
> +     }
> +}
> +
> +int board_init(void)
> +{
> +     /* address of boot parameters */
> +     gd->bd->bi_boot_params = kw_sdram_bar(0) + 0x100;
> +
> +     set_led(LED_POWER_BLINKING);
> +
> +     return 0;
> +}
> +
> +#ifdef CONFIG_MISC_INIT_R
> +void check_enetaddr(void)
> +{
> +     uchar enetaddr[6];
> +
> +     if (!eth_getenv_enetaddr_by_index("eth", 0, enetaddr)) {
> +             /* signal unset/invalid ethaddr to user */
> +             set_led(LED_INFO_BLINKING);
> +     }
> +}
> +
> +static void erase_environment(void)

Why do you need this function?

> +{
> +     struct spi_flash *flash;
> +
> +     printf("Erasing environment..\n");
> +     flash = spi_flash_probe(0, 0, 1000000, SPI_MODE_3);
> +     if (!flash) {
> +             printf("Erasing flash failed\n");
> +             return;
> +     }
> +
> +     spi_flash_erase(flash, CONFIG_ENV_OFFSET, CONFIG_ENV_SIZE);
> +     spi_flash_free(flash);
> +     do_reset(NULL, 0, 0, NULL);
> +}
> +
> +static void rescue_mode(void)
> +{
> +     uchar enetaddr[6];
> +
> +     printf("Entering rescue mode..\n");
> +     if (!eth_getenv_enetaddr_by_index("eth", 0, enetaddr)) {
> +             eth_random_enetaddr(enetaddr);
> +             if (eth_setenv_enetaddr_by_index("eth", 0, enetaddr)) {
> +                     printf("Failed to set ethernet address\n");
> +                             set_led(LED_ALARM_BLINKING);
> +                     return;
> +             }
> +     }
> +     setenv("bootsource", "rescue");
> +}
> +
> +static void check_push_button(void)
> +{
> +     int i = 0;
> +
> +     while (!kw_gpio_get_value(GPIO_FUNC_BUTTON)) {
> +             udelay(100000);
> +             i++;
> +
> +             if (i == 10)
> +                     set_led(LED_INFO_ON);
> +
> +             if (i >= 100) {
> +                     set_led(LED_INFO_BLINKING);
> +                     break;
> +             }
> +     }
> +
> +     if (i >= 100)
> +             erase_environment();
> +     else if (i >= 10)
> +             rescue_mode();
> +}

You can overload this functionality to Reset key, you don't need any supporting code for the same, you can handle it through additional environment variables.
For more info check for "SYSTSTn Duration counter support" in Kirkwood/cpu.c

> +
> +int misc_init_r(void)
> +{
> +     check_enetaddr();
This need to be ifdefed with CONFIG_MISC_INIT_R

> +     check_push_button();
> +
> +     return 0;
> +}
> +#endif
> +
> +#ifdef CONFIG_SHOW_BOOT_PROGRESS
> +void show_boot_progress(int progress)
> +{
> +     if (progress > 0)
> +             return;
> +
> +     /* this is not an error, eg. bootp with autoload=no will trigger
> this */
> +     if (progress == -BOOTSTAGE_ID_NET_LOADED)
> +             return;
> +
> +     set_led(LED_ALARM_BLINKING);
> +}
> +#endif
> +
> +#ifdef CONFIG_RESET_PHY_R
> +/* Configure and enable MV88E1118 PHY */
> +void reset_phy(void)
> +{
> +     u16 devadr;
> +     char *name = "egiga1";
> +
> +     if (miiphy_set_current_dev(name))
> +             return;
> +
> +     /* command to read PHY dev address */
> +     if (miiphy_read(name, 0xEE, 0xEE, (u16 *) &devadr)) {
> +             printf("Err..%s could not read PHY dev address\n", __func__);
> +             return;
> +     }
> +
> +     /* reset the phy */
> +     miiphy_reset(name, devadr);
> +}
> +#endif /* CONFIG_RESET_PHY_R */
> diff --git a/board/buffalo/lsxl/lsxl.h b/board/buffalo/lsxl/lsxl.h
> new file mode 100644
> index 0000000..2a2642e
> --- /dev/null
> +++ b/board/buffalo/lsxl/lsxl.h
> @@ -0,0 +1,75 @@
> +/*
> + * Copyright (c) 2012 Michael Walle
> + * Michael Walle <michael@walle.cc>
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
> + * MA 02110-1301 USA
> + */
> +
> +#ifndef __LSXL_H
> +#define __LSXL_H
> +
> +#define GPIO_HDD_POWER               10
> +#define GPIO_USB_VBUS                11
> +#define GPIO_FAN_HIGH                18
> +#define GPIO_FAN_LOW         19
> +#define GPIO_FUNC_LED                36
> +#define GPIO_ALARM_LED               37
> +#define GPIO_INFO_LED                38
> +#define GPIO_POWER_LED               39
> +#define GPIO_FAN_LOCK                40
> +#define GPIO_FUNC_BUTTON     41
> +#define GPIO_POWER_SWITCH    42
> +#define GPIO_POWER_AUTO_SWITCH       43
> +#define GPIO_FUNC_RED_LED    48
> +
> +#define _BIT(x) (1<<(x))
> +
> +#define LSXL_OE_LOW (~(_BIT(GPIO_HDD_POWER)              \
> +                     | _BIT(GPIO_USB_VBUS)               \
> +                     | _BIT(GPIO_FAN_HIGH)               \
> +                     | _BIT(GPIO_FAN_LOW)))
> +
> +#define LSXL_OE_HIGH (~(_BIT(GPIO_FUNC_LED - 32)         \
> +                     | _BIT(GPIO_ALARM_LED - 32)         \
> +                     | _BIT(GPIO_INFO_LED - 32)          \
> +                     | _BIT(GPIO_POWER_LED - 32)         \
> +                     | _BIT(GPIO_FUNC_RED_LED - 32)))
> +
> +#define LSXL_OE_VAL_LOW (_BIT(GPIO_HDD_POWER)                    \
> +                     | _BIT(GPIO_USB_VBUS))
> +
> +#define LSXL_OE_VAL_HIGH (_BIT(GPIO_FUNC_LED - 32)       \
> +                     | _BIT(GPIO_ALARM_LED - 32)         \
> +                     | _BIT(GPIO_INFO_LED - 32)          \
> +                     | _BIT(GPIO_POWER_LED - 32)         \
> +                     | _BIT(GPIO_FUNC_RED_LED - 32))
> +
> +#define LSXL_POL_VAL_LOW (_BIT(GPIO_FAN_HIGH)                    \
> +                     | _BIT(GPIO_FAN_LOW))
> +
> +#define LSXL_POL_VAL_HIGH (_BIT(GPIO_FUNC_LED - 32)      \
> +                     | _BIT(GPIO_ALARM_LED - 32)         \
> +                     | _BIT(GPIO_INFO_LED - 32)          \
> +                     | _BIT(GPIO_POWER_LED - 32)         \
> +                     | _BIT(GPIO_FUNC_BUTTON - 32)       \
> +                     | _BIT(GPIO_POWER_SWITCH - 32)      \
> +                     | _BIT(GPIO_POWER_AUTO_SWITCH - 32) \
> +                     | _BIT(GPIO_FUNC_RED_LED - 32))
> +
> +#endif /* __LSXL_H */
> diff --git a/boards.cfg b/boards.cfg
> index 5f328b5..cd4e982 100644
> --- a/boards.cfg
> +++ b/boards.cfg
> @@ -137,6 +137,8 @@ hawkboard_uart               arm         arm926ejs
> da8xxevm            davinci
>  enbw_cmc                     arm         arm926ejs   enbw_cmc
> enbw           davinci
>  calimain                     arm         arm926ejs   calimain
> omicron        davinci
>  dns325                       arm         arm926ejs   -
> d-link         kirkwood
> +lschlv2                      arm         arm926ejs   lsxl
> buffalo        kirkwood    lsxl:LSCHLV2
> +lsxhl                        arm         arm926ejs   lsxl
> buffalo        kirkwood    lsxl:LSXHL
>  km_kirkwood                  arm         arm926ejs   km_arm
> keymile        kirkwood       km_kirkwood:KM_DISABLE_PCI
>  km_kirkwood_pci              arm         arm926ejs   km_arm
> keymile        kirkwood       km_kirkwood:KM_RECONFIG_XLX
>  mgcoge3un                    arm         arm926ejs   km_arm
> keymile        kirkwood
> diff --git a/include/configs/lsxl.h b/include/configs/lsxl.h
> new file mode 100644
> index 0000000..b45c72b
> --- /dev/null
> +++ b/include/configs/lsxl.h
> @@ -0,0 +1,182 @@
> +/*
> + * Copyright (c) 2012 Michael Walle
> + * Michael Walle <michael@walle.cc>
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
> + * MA 02110-1301 USA
> + */
> +
> +#ifndef _CONFIG_LSXL_H
> +#define _CONFIG_LSXL_H
> +
> +/*
> + * Version number information
> + */
> +#if defined(CONFIG_LSCHLV2)
> +#define CONFIG_IDENT_STRING " LS-CHLv2"
> +#define CONFIG_SYS_KWD_CONFIG $(SRCTREE)/$(CONFIG_BOARDDIR)/kwbimage-
> lschl.cfg
> +#define CONFIG_MACH_TYPE 3006
> +#define CONFIG_SYS_TCLK 166666667 /* 166 MHz */
> +#elif defined(CONFIG_LSXHL)
> +#define CONFIG_IDENT_STRING " LS-XHL"
> +#define CONFIG_SYS_KWD_CONFIG $(SRCTREE)/$(CONFIG_BOARDDIR)/kwbimage-
> lsxhl.cfg
> +#define CONFIG_MACH_TYPE 2663

From where these number are coming for MACH_TYPE?

> +/* CONFIG_SYS_TCLK is 200000000 by default */
> +#else
> +#error "unknown board"
> +#endif
> +
> +/*
> + * General configuration options
> + */
> +#define CONFIG_FEROCEON_88FR131              /* CPU Core subversion */
> +#define CONFIG_KIRKWOOD                      /* SOC Family Name */
> +#define CONFIG_KW88F6281             /* SOC Name */
> +
> +#define CONFIG_SKIP_LOWLEVEL_INIT    /* disable board lowlevel_init */
> +#define CONFIG_MISC_INIT_R
> +#define CONFIG_SHOW_BOOT_PROGRESS
> +
> +#define CONFIG_RANDOM_MACADDR
> +#define CONFIG_SETENV_ENETADDR_BY_INDEX
> +#define CONFIG_KIRKWOOD_GPIO
> +#define CONFIG_OF_LIBFDT
> +
> +#define CONFIG_SYS_NO_FLASH
> +#define CONFIG_SYS_HUSH_PARSER
> +#define CONFIG_SYS_CONSOLE_IS_IN_ENV
> +#define CONFIG_SYS_CONSOLE_INFO_QUIET
> +
> +/*
> + * Enable u-boot API for standalone programs.
> + */
> +#define CONFIG_API
> +
> +/*
> + * Commands configuration
> + */
> +#include <config_cmd_default.h>
> +#define CONFIG_CMD_DHCP
> +#define CONFIG_CMD_ELF
> +#define CONFIG_CMD_ENV
> +#define CONFIG_CMD_EXT2
> +#define CONFIG_CMD_FAT
> +#define CONFIG_CMD_IDE
> +#define CONFIG_CMD_PING
> +#define CONFIG_CMD_PING
> +#define CONFIG_CMD_SF
> +#define CONFIG_CMD_SPI
> +#define CONFIG_CMD_USB
> +
> +#define CONFIG_DOS_PARTITION
> +#define CONFIG_EFI_PARTITION
> +
> +/*
> + * mv-common.h should be defined after CMD configs since it used them
> + * to enable certain macros
> + */
> +#include "mv-common.h"
> +
> +/* ST M25P40 */
> +#undef CONFIG_SPI_FLASH_MACRONIX
> +#define CONFIG_SPI_FLASH_STMICRO
> +#undef CONFIG_ENV_SPI_MAX_HZ
> +#define CONFIG_ENV_SPI_MAX_HZ                25000000
> +#undef CONFIG_SF_DEFAULT_SPEED
> +#define CONFIG_SF_DEFAULT_SPEED              25000000
> +
> +
> +#undef CONFIG_SYS_PROMPT
> +#define CONFIG_SYS_PROMPT            "=> "
> +#define CONFIG_SYS_PROMPT_HUSH_PS2   "> "
> +
> +/*
> + *  Environment variables configurations
> + */
> +#ifdef CONFIG_SPI_FLASH
> +#define CONFIG_SYS_MAX_FLASH_BANKS   1
> +#define CONFIG_SYS_MAX_FLASH_SECT    8
> +#define CONFIG_ENV_IS_IN_SPI_FLASH   1
> +#define CONFIG_ENV_SECT_SIZE         0x10000 /* 64K */
> +#else
> +#define CONFIG_ENV_IS_NOWHERE
> +#endif
> +
> +#define CONFIG_ENV_SIZE                      0x10000 /* 64k */
> +#define CONFIG_ENV_OFFSET            0x70000 /* env starts here */

Why this is too far, what it u-boot.bin size?

Regards.
Prafulla . . .

Hi Prafulla,

thanks for the review.

On Thu, May 24, 2012 09:24, Prafulla Wadaskar wrote:
>> -----Original Message-----
>> From: Michael Walle [mailto:michael@walle.cc]
>> Sent: 12 May 2012 04:21
>> To: u-boot@lists.denx.de
>> Cc: Prafulla Wadaskar; Wolfgang Denk; Mike Frysinger; Joe Hershberger;
>> Michael Walle
>> Subject: [PATCH v5 5/5] Kirkwood: add lschlv2 and lsxhl board support
>>
>> This patch adds support for both the Linkstation Live (LS-CHLv2) and
>> Linkstation Pro (LS-XHL) by Buffalo.
>>
>> Signed-off-by: Michael Walle <michael@walle.cc>
>> Cc: Prafulla Wadaskar <prafulla@marvell.com>
>> ---
>>  MAINTAINERS                           |    5 +
>>  board/buffalo/lsxl/Makefile           |   50 ++++++
>>  board/buffalo/lsxl/kwbimage-lschl.cfg |  229
>> +++++++++++++++++++++++++
>>  board/buffalo/lsxl/kwbimage-lsxhl.cfg |  229
>> +++++++++++++++++++++++++
>
> BTW: These two file looks similar, what is the difference?

Mainly the memory configuration, eg LSCHLv2 has one 16x 512MBit, whereas
the LSXHL has two 8x 1GBit dram chips. And of course some memory
parameters are different.

[..snip..]


>> +     return 0;
>> +}
>> +
>> +#ifdef CONFIG_MISC_INIT_R
>> +void check_enetaddr(void)
>> +{
>> +     uchar enetaddr[6];
>> +
>> +     if (!eth_getenv_enetaddr_by_index("eth", 0, enetaddr)) {
>> +             /* signal unset/invalid ethaddr to user */
>> +             set_led(LED_INFO_BLINKING);
>> +     }
>> +}
>> +
>> +static void erase_environment(void)
>
> Why do you need this function?

Mh? To erase the environment; I don't think that is the answer you wanted
to know ;) Remember the only recovery method for a totally messed up
environment is:
 - push button longer than 10s -> erases the environment, resets the board
 - push button longer than 3s -> boots into rescue mode, eg. set temporary
enetaddr and enable netconsole.

So i can't rely on a functional environment, that is i can't run stored
commands. Another way would be to run a command directly, eg.
  run("sf probe 0 && sf erase 70000 +10000 && reset")

dunno if that is better, back then i felt like hardcoding is better. Esp.
since there may be some side effects if some special environment variables
are set. Eg. there may be the spi speed set in the environment. I don't
know if this is true now, but i guess one may come up with such a feature.
Then this might break my recovery procedure.

>> +{
>> +     struct spi_flash *flash;
>> +
>> +     printf("Erasing environment..\n");
>> +     flash = spi_flash_probe(0, 0, 1000000, SPI_MODE_3);
>> +     if (!flash) {
>> +             printf("Erasing flash failed\n");
>> +             return;
>> +     }
>> +
>> +     spi_flash_erase(flash, CONFIG_ENV_OFFSET, CONFIG_ENV_SIZE);
>> +     spi_flash_free(flash);
>> +     do_reset(NULL, 0, 0, NULL);
>> +}
>> +
>> +static void rescue_mode(void)
>> +{
>> +     uchar enetaddr[6];
>> +
>> +     printf("Entering rescue mode..\n");
>> +     if (!eth_getenv_enetaddr_by_index("eth", 0, enetaddr)) {
>> +             eth_random_enetaddr(enetaddr);
>> +             if (eth_setenv_enetaddr_by_index("eth", 0, enetaddr)) {
>> +                     printf("Failed to set ethernet address\n");
>> +                             set_led(LED_ALARM_BLINKING);
>> +                     return;
>> +             }
>> +     }
>> +     setenv("bootsource", "rescue");
>> +}
>> +
>> +static void check_push_button(void)
>> +{
>> +     int i = 0;
>> +
>> +     while (!kw_gpio_get_value(GPIO_FUNC_BUTTON)) {
>> +             udelay(100000);
>> +             i++;
>> +
>> +             if (i == 10)
>> +                     set_led(LED_INFO_ON);
>> +
>> +             if (i >= 100) {
>> +                     set_led(LED_INFO_BLINKING);
>> +                     break;
>> +             }
>> +     }
>> +
>> +     if (i >= 100)
>> +             erase_environment();
>> +     else if (i >= 10)
>> +             rescue_mode();
>> +}
>
> You can overload this functionality to Reset key, you don't need any
> supporting code for the same, you can handle it through additional
> environment variables.
> For more info check for "SYSTSTn Duration counter support" in
> Kirkwood/cpu.c

I saw that code, but unfortunately this is not the reset button.


>> +
>> +int misc_init_r(void)
>> +{
>> +     check_enetaddr();
> This need to be ifdefed with CONFIG_MISC_INIT_R

it is, see above. check_enetaddr() and check_push_button() are guarded, too.

>> +     check_push_button();
>> +
>> +     return 0;
>> +}
>> +#endif
>> +

[..snip..]

>> +/*
>> + *  Environment variables configurations
>> + */
>> +#ifdef CONFIG_SPI_FLASH
>> +#define CONFIG_SYS_MAX_FLASH_BANKS   1
>> +#define CONFIG_SYS_MAX_FLASH_SECT    8
>> +#define CONFIG_ENV_IS_IN_SPI_FLASH   1
>> +#define CONFIG_ENV_SECT_SIZE         0x10000 /* 64K */
>> +#else
>> +#define CONFIG_ENV_IS_NOWHERE
>> +#endif
>> +
>> +#define CONFIG_ENV_SIZE                      0x10000 /* 64k */
>> +#define CONFIG_ENV_OFFSET            0x70000 /* env starts here */
>
> Why this is too far, what it u-boot.bin size?

Thats the original flash layout, 0x0-0x6ffff is uboot and 0x70000-0x7ffff
is  environment. ATM uboot size is around 40000 (hex) bytes.

Am Donnerstag 24 Mai 2012, 09:24:40 schrieb Prafulla Wadaskar:
> > +/*
> > + * Version number information
> > + */
> > +#if defined(CONFIG_LSCHLV2)
> > +#define CONFIG_IDENT_STRING " LS-CHLv2"
> > +#define CONFIG_SYS_KWD_CONFIG $(SRCTREE)/$(CONFIG_BOARDDIR)/kwbimage-
> > lschl.cfg
> > +#define CONFIG_MACH_TYPE 3006
> > +#define CONFIG_SYS_TCLK 166666667 /* 166 MHz */
> > +#elif defined(CONFIG_LSXHL)
> > +#define CONFIG_IDENT_STRING " LS-XHL"
> > +#define CONFIG_SYS_KWD_CONFIG $(SRCTREE)/$(CONFIG_BOARDDIR)/kwbimage-
> > lsxhl.cfg
> > +#define CONFIG_MACH_TYPE 2663
> 
> From where these number are coming for MACH_TYPE?

Sorry forgot to answer that. They come from here:
  http://www.arm.linux.org.uk/developer/machines/download.php