Message ID | 1337115571-14115-2-git-send-email-otavio@ossystems.com.br |
---|---|
State | Accepted |
Commit | a2277e84036fb22aac44e83a391431539086f110 |
Delegated to: | Stefano Babic |
Headers | show |
Dear Otavio Salvador, > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> > Cc: Marek Vasut <marex@denx.de> > Cc: Stefano Babic <sbabic@denx.de> > Cc: Wolfgang Denk <wd@denx.de> Please drop the other one, so this is the same as mx28evk.h and we can easily unify it. btw how did you find this? > --- > include/configs/m28evk.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/configs/m28evk.h b/include/configs/m28evk.h > index a076aa5..29ea8eb 100644 > --- a/include/configs/m28evk.h > +++ b/include/configs/m28evk.h > @@ -43,8 +43,6 @@ > #define CONFIG_ARCH_CPU_INIT > #define CONFIG_ARCH_MISC_INIT > > -#define CONFIG_OF_LIBFDT > - > /* > * SPL > */ Best regards, Marek Vasut
On Tue, May 15, 2012 at 6:14 PM, Marek Vasut <marex@denx.de> wrote: > Please drop the other one, so this is the same as mx28evk.h and we can easily > unify it. btw how did you find this? Good; will check it. I found it when looking about common stuff in boad configs; I am still willing to try to have a common header file for both but I am first interested in move i.MX23 further.
Dear Otavio Salvador, > On Tue, May 15, 2012 at 6:14 PM, Marek Vasut <marex@denx.de> wrote: > > Please drop the other one, so this is the same as mx28evk.h and we can > > easily unify it. btw how did you find this? > > Good; will check it. > > I found it when looking about common stuff in boad configs; I am still > willing to try to have a common header file for both but I am first > interested in move i.MX23 further. Ok, so let's do it this way: You submit your MX23 stuff, let's get that in. Then we can start with this consolidation. Is it OK? Best regards, Marek Vasut
On Tue, May 15, 2012 at 7:05 PM, Marek Vasut <marex@denx.de> wrote: > You submit your MX23 stuff, let's get that in. Then we can start with this > consolidation. Is it OK? This works but wouldn't be better to avoid a duplication before it? It doesn't matter for me but I'd prefer it fixed.
Dear Otavio Salvador, > On Tue, May 15, 2012 at 7:05 PM, Marek Vasut <marex@denx.de> wrote: > > You submit your MX23 stuff, let's get that in. Then we can start with > > this consolidation. Is it OK? > > This works but wouldn't be better to avoid a duplication before it? It > doesn't matter for me but I'd prefer it fixed. I'm all for applying this 2/3, the rest should be discussed more thoroughly. Best regards, Marek Vasut
On Tue, May 15, 2012 at 8:18 PM, Marek Vasut <marex@denx.de> wrote: >> This works but wouldn't be better to avoid a duplication before it? It >> doesn't matter for me but I'd prefer it fixed. > > I'm all for applying this 2/3, the rest should be discussed more thoroughly. I checked mx28evk and m28evk config and both are setting CONFIG_OF_LIBFDT at same place now. It seems this patch is the way to go. Please take a look and confirm it.
Dear Otavio Salvador, > On Tue, May 15, 2012 at 8:18 PM, Marek Vasut <marex@denx.de> wrote: > >> This works but wouldn't be better to avoid a duplication before it? It > >> doesn't matter for me but I'd prefer it fixed. > > > > I'm all for applying this 2/3, the rest should be discussed more > > thoroughly. > > I checked mx28evk and m28evk config and both are setting > CONFIG_OF_LIBFDT at same place now. It seems this patch is the way to > go. Please take a look and confirm it. Ok good Acked-by: Marek Vasut <marex@denx.de> Best regards, Marek Vasut
On 15/05/2012 22:59, Otavio Salvador wrote: > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> > Cc: Marek Vasut <marex@denx.de> > Cc: Stefano Babic <sbabic@denx.de> > Cc: Wolfgang Denk <wd@denx.de> > --- Applied to u-boot-imx, thanks. Best regards, Stefano Babic
diff --git a/include/configs/m28evk.h b/include/configs/m28evk.h index a076aa5..29ea8eb 100644 --- a/include/configs/m28evk.h +++ b/include/configs/m28evk.h @@ -43,8 +43,6 @@ #define CONFIG_ARCH_CPU_INIT #define CONFIG_ARCH_MISC_INIT -#define CONFIG_OF_LIBFDT - /* * SPL */
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> Cc: Marek Vasut <marex@denx.de> Cc: Stefano Babic <sbabic@denx.de> Cc: Wolfgang Denk <wd@denx.de> --- include/configs/m28evk.h | 2 -- 1 file changed, 2 deletions(-)