Message ID | 4F89A0A5.5030806@samsung.com |
---|---|
State | New |
Headers | show |
Hi, On Sat, Apr 14, 2012 at 9:07 AM, Kukjin Kim <kgene.kim@samsung.com> wrote: > Hi Arnd, Olof, > > Please pull samsung fixes-2 for v3.4 from following: > git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git > v3.4-samsung-fixes-2 Pulled, thanks. > Most are for fix of build failure :( and warnings. > If any problems, please let me know. > > Note that according to changing the device name for sdhci controllers and > removing clk_type from sdhci platform_data after v3.4-rc1, need to update > regarding stuff in samsung arch part so I'm preparing its fix in > samsung-fixes-3. I will send it next turn. Looking at your current fixes-3 branch, it's unclear at a quick glance why the clk_type patch is a bugfix, and especially why it is a regression fix -- it looks like a cleanup. We're very close to 3.4-rc3 now, so we should only be merging fixes (and ideally only regressions since 3.3). So, if you do need it to go into 3.4 please motivate it when you send the pull request. Thanks, -Olof
Olof Johansson wrote: > Hi, [...] (Cc'ed Marek Szyprowsk) > Looking at your current fixes-3 branch, it's unclear at a quick glance > why the clk_type patch is a bugfix, and especially why it is a > regression fix -- it looks like a cleanup. We're very close to 3.4-rc3 I agree that the removing clk_type member in sdhci platform data should be included in cleanup stuff, it is useless in current mainline though. Marek, is this ok to you? > now, so we should only be merging fixes (and ideally only regressions > since 3.3). > > So, if you do need it to go into 3.4 please motivate it when you send > the pull request. > Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.
Hi Kukjin, On Wednesday, April 25, 2012 2:33 AM Kukjin Kim wrote: > > Looking at your current fixes-3 branch, it's unclear at a quick glance > > why the clk_type patch is a bugfix, and especially why it is a > > regression fix -- it looks like a cleanup. We're very close to 3.4-rc3 > > I agree that the removing clk_type member in sdhci platform data should > be included in cleanup stuff, it is useless in current mainline though. > > Marek, is this ok to you? Yes, this patch is not strictly needed to get SDHCI working again on v3.4-rcX. Best regards