| Message ID | 1331129943-17469-1-git-send-email-alevy@redhat.com |
|---|---|
| State | New |
| Headers | show |
Ping? This patch doesn't seem to have made it into master yet and I don't think it was in the last spice pullreq... (patchwork id http://patchwork.ozlabs.org/patch/145294/) thanks -- PMM On 7 March 2012 14:19, Alon Levy <alevy@redhat.com> wrote: > Requiring spice-server >= 0.8.2 is not enough since spice-server.pc > doesn't require spice-protocol (any version). Until that is fixed > upstream an explicit requirement in qemu fixes compilation broken since > > commit 2e1a98c9c1b90ca093278c6b43244dc46604d7b7 > Author: Alon Levy <alevy@redhat.com> > Date: Fri Feb 24 23:19:30 2012 +0200 > > qxl: introduce QXLCookie > > Reported-by: Peter Maydell <peter.maydell@linaro.org> > > Signed-off-by: Alon Levy <alevy@redhat.com> > --- > configure | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/configure b/configure > index a5eb832..ecdfe9a 100755 > --- a/configure > +++ b/configure > @@ -2544,6 +2544,7 @@ EOF > spice_cflags=$($pkg_config --cflags spice-protocol spice-server 2>/dev/null) > spice_libs=$($pkg_config --libs spice-protocol spice-server 2>/dev/null) > if $pkg_config --atleast-version=0.8.2 spice-server >/dev/null 2>&1 && \ > + $pkg_config --atleast-version=0.8.1 spice-protocol > /dev/null 2>&1 && \ > compile_prog "$spice_cflags" "$spice_libs" ; then > spice="yes" > libs_softmmu="$libs_softmmu $spice_libs" > -- > 1.7.9.1 >
On 04/23/12 15:52, Peter Maydell wrote: > Ping? This patch doesn't seem to have made it into master yet > and I don't think it was in the last spice pullreq... Somehow overlooked it in my inbox. Added to the spice patch queue now. Thanks for the reminder, Gerd
diff --git a/configure b/configure index a5eb832..ecdfe9a 100755 --- a/configure +++ b/configure @@ -2544,6 +2544,7 @@ EOF spice_cflags=$($pkg_config --cflags spice-protocol spice-server 2>/dev/null) spice_libs=$($pkg_config --libs spice-protocol spice-server 2>/dev/null) if $pkg_config --atleast-version=0.8.2 spice-server >/dev/null 2>&1 && \ + $pkg_config --atleast-version=0.8.1 spice-protocol > /dev/null 2>&1 && \ compile_prog "$spice_cflags" "$spice_libs" ; then spice="yes" libs_softmmu="$libs_softmmu $spice_libs"
Requiring spice-server >= 0.8.2 is not enough since spice-server.pc doesn't require spice-protocol (any version). Until that is fixed upstream an explicit requirement in qemu fixes compilation broken since commit 2e1a98c9c1b90ca093278c6b43244dc46604d7b7 Author: Alon Levy <alevy@redhat.com> Date: Fri Feb 24 23:19:30 2012 +0200 qxl: introduce QXLCookie Reported-by: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: Alon Levy <alevy@redhat.com> --- configure | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)