| Message ID | 4F7C3FCE.60806@msgid.tls.msk.ru |
|---|---|
| State | New |
| Headers | show |
On 04/04/2012 07:34 AM, Michael Tokarev wrote: > As mentioned in http://bugs.debian.org/660154 , finnish keyboard mapping > is kind of broken. Fix it as Timo Sirainen suggests in #660154. Needs a Signed-off-by. Regards, Anthony Liguori > > index 2a4e0f0..4be7586 100644 > --- a/pc-bios/keymaps/fi > +++ b/pc-bios/keymaps/fi > @@ -99,9 +99,7 @@ asterisk 0x2b shift > acute 0x2b altgr > multiply 0x2b shift altgr > guillemotleft 0x2c altgr > -less 0x2c shift altgr > guillemotright 0x2d altgr > -greater 0x2d shift altgr > copyright 0x2e altgr > leftdoublequotemark 0x2f altgr > grave 0x2f shift altgr > > > Thanks! > > /mjt >
On 14.04.2012 00:08, Anthony Liguori wrote: > On 04/04/2012 07:34 AM, Michael Tokarev wrote: >> As mentioned in http://bugs.debian.org/660154 , finnish keyboard mapping >> is kind of broken. Fix it as Timo Sirainen suggests in #660154. > > Needs a Signed-off-by. I haven't added a Signed-off-by because: a) I'm not the author of this patch, b) Timo didn't respond to my query, and c) it is really trivial thing. Can we go with just Tested-by or Reviewed-by? Thanks! /mjt > Regards, > > Anthony Liguori > >> >> index 2a4e0f0..4be7586 100644 >> --- a/pc-bios/keymaps/fi >> +++ b/pc-bios/keymaps/fi >> @@ -99,9 +99,7 @@ asterisk 0x2b shift >> acute 0x2b altgr >> multiply 0x2b shift altgr >> guillemotleft 0x2c altgr >> -less 0x2c shift altgr >> guillemotright 0x2d altgr >> -greater 0x2d shift altgr >> copyright 0x2e altgr >> leftdoublequotemark 0x2f altgr >> grave 0x2f shift altgr >> >> >> Thanks! >> >> /mjt >> >
Michael Tokarev <mjt@tls.msk.ru> writes: > On 14.04.2012 00:08, Anthony Liguori wrote: >> On 04/04/2012 07:34 AM, Michael Tokarev wrote: >>> As mentioned in http://bugs.debian.org/660154 , finnish keyboard mapping >>> is kind of broken. Fix it as Timo Sirainen suggests in #660154. >> >> Needs a Signed-off-by. > > I haven't added a Signed-off-by because: > > a) I'm not the author of this patch, Not required for s-o-b. > b) Timo didn't respond to my query, and > c) it is really trivial thing. Want to argue that with a lawyer? > Can we go with just Tested-by or Reviewed-by? No further reply from Anthony, which I'd say means "no". Reminder: The sign-off is a simple line at the end of the explanation for the patch, which certifies that you wrote it or otherwise have the right to pass it on as an open-source patch. The rules are pretty simple: if you can certify the below: Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. then you just add a line saying Signed-off-by: Random J Developer <random@developer.example.org> using your real name (sorry, no pseudonyms or anonymous contributions.)
On 04/27/2012 02:08 AM, Markus Armbruster wrote: > Michael Tokarev<mjt@tls.msk.ru> writes: > >> On 14.04.2012 00:08, Anthony Liguori wrote: >>> On 04/04/2012 07:34 AM, Michael Tokarev wrote: >>>> As mentioned in http://bugs.debian.org/660154 , finnish keyboard mapping >>>> is kind of broken. Fix it as Timo Sirainen suggests in #660154. >>> >>> Needs a Signed-off-by. >> >> I haven't added a Signed-off-by because: >> >> a) I'm not the author of this patch, > > Not required for s-o-b. > >> b) Timo didn't respond to my query, and >> c) it is really trivial thing. > > Want to argue that with a lawyer? > >> Can we go with just Tested-by or Reviewed-by? > > No further reply from Anthony, which I'd say means "no". Yes, it means no. I won't take patches without Signed-off-bys. There are no exceptions to that. Regards, Anthony Liguori
--- a/pc-bios/keymaps/fi +++ b/pc-bios/keymaps/fi @@ -99,9 +99,7 @@ asterisk 0x2b shift acute 0x2b altgr multiply 0x2b shift altgr guillemotleft 0x2c altgr -less 0x2c shift altgr guillemotright 0x2d altgr -greater 0x2d shift altgr copyright 0x2e altgr leftdoublequotemark 0x2f altgr grave 0x2f shift altgr